From patchwork Wed May 17 16:15:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 126927 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF8A542B2C; Wed, 17 May 2023 18:16:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF4D842D3E; Wed, 17 May 2023 18:16:15 +0200 (CEST) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id D37A040041 for ; Wed, 17 May 2023 18:16:11 +0200 (CEST) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-64390dc0a7fso142846b3a.1 for ; Wed, 17 May 2023 09:16:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1684340171; x=1686932171; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=j90Wcyywo7bWVqG+xeHiFrSS78DAjEgvWTa+IJquoEQ=; b=YKVe4sF2heRdy2UDmiw+uJ3bHKjpKqhYIiNYTTxYgTA5JD/9DMFwtYWrl4uRNoptdh UfkU1tVTWECWbbQm374eS0rA/LLMjdg5PuCozdKzdPPf1W5LYK1Q/IgO986sO2qJtsqj azHcgwClc93y8HlSgDHhqeS38Xr5uDMM/wpzkqm489TZs40ci4p5TpUHEB8NYqr82udh 8xyHUlYEQJn2KuZKIISKJa5o4uM4ysHU+pIa3ok//aaTok+Is/Cu3Vv4YWs4GOvUHgiY JAyUB+BZHqpySoCSxlD+rFJ6lU/jW6IBOgkusY6GjAyMmZd7mn94y3Tjeg8AWn+SO3KY 53Tg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684340171; x=1686932171; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=j90Wcyywo7bWVqG+xeHiFrSS78DAjEgvWTa+IJquoEQ=; b=X+kBc01sfq3rtwTJvRUxTqMGQpnMAVfv2+mmUKQuCcgTcyRBYY7Wbh5DeE/dUrFEn+ i89qMQhY5w1/Kit3Ik0/AvCa+vS4VZxm3aWBnzjhs95rV37F5vHyghIIkdDosAdSCqqD uLspH5yprqGHK+48ut61uK8PcGDiZvJCh6nOcyaQ9o5TlzQsiY6i5Wu9EyKEURyNsWNS p/rbNKikLXy/8m/fd+u7IAx8Uov6yBfp17jRFnF7VrEh8AJ5HWd3Fl8+tBgqVT6Cjj2H 8wbjACy1SHBuvnGACpA70LxD5WRFMHyxycE0eOIQOhlicyXHZMdlFgUsF9S1YFnqgBdp w+og== X-Gm-Message-State: AC+VfDz1IIFMSk9BSf3HCW6mTJdmHI964Hunr2zPlr+uEMWS8AAFbkpl Rccs5s9gJtNc1fXykTEPBF58DF4WqThXVyvcSuodBw== X-Google-Smtp-Source: ACHHUZ78ZRR8ILUUNJysDOcSR4pwjetGr4J39KMI6qLUu825lYCvARNOpm2JfaDdKXHbW6kwTCy2Tw== X-Received: by 2002:a05:6a00:2888:b0:63d:368c:97c2 with SMTP id ch8-20020a056a00288800b0063d368c97c2mr30826pfb.8.1684340170832; Wed, 17 May 2023 09:16:10 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id h5-20020a62b405000000b0063f33e216dasm15793009pfn.96.2023.05.17.09.16.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 09:16:10 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Bruce Richardson Subject: [PATCH 03/20] net/ring: replace use of sanity Date: Wed, 17 May 2023 09:15:46 -0700 Message-Id: <20230517161603.117728-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230517161603.117728-1-stephen@networkplumber.org> References: <20230517161603.117728-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --- drivers/net/ring/rte_eth_ring.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/net/ring/rte_eth_ring.c b/drivers/net/ring/rte_eth_ring.c index e8bc9b627102..e36742fda84f 100644 --- a/drivers/net/ring/rte_eth_ring.c +++ b/drivers/net/ring/rte_eth_ring.c @@ -34,7 +34,7 @@ struct ring_internal_args { struct rte_ring * const *tx_queues; const unsigned int nb_tx_queues; const unsigned int numa_node; - void *addr; /* self addr for sanity check */ + void *addr; /* self addr for verification */ }; enum dev_action { @@ -591,10 +591,7 @@ static int parse_kvlist(const char *key __rte_unused, *action = '\0'; action++; - /* - * Need to do some sanity checking here - */ - + /* Check the command argument is valid action */ if (strcmp(action, ETH_RING_ACTION_ATTACH) == 0) info->list[info->count].action = DEV_ATTACH; else if (strcmp(action, ETH_RING_ACTION_CREATE) == 0)