From patchwork Wed May 17 16:15:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 126931 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BFE6D42B2C; Wed, 17 May 2023 18:16:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7ED3342D5D; Wed, 17 May 2023 18:16:20 +0200 (CEST) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mails.dpdk.org (Postfix) with ESMTP id 690F141611 for ; Wed, 17 May 2023 18:16:16 +0200 (CEST) Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-643846c006fso925807b3a.0 for ; Wed, 17 May 2023 09:16:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1684340175; x=1686932175; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=T7MhSAwzukH5mb94ewYmhPl0jEaGJs1Stj1FkGbbHNs=; b=B5CtR0gHH6+vyeVO/l2l05ZF+8mkEdN61cBUQujmVZgE/KlwvWECmavXZ9vyAGyYl/ L4dkW3AuEylLBbR34ApmDMCHNu4FuqruGvdPZrtfTlG7MLGYaYcrP4lz5cckl72+WS9Y JZkhmxSwFyMCfeT9LPtq2iNzXmw9MkY19e7M+3KUApQa++mH+kbnc4KueST99sen7XBV VGQgMkljMFfr8rYJkydtsAXGS8Qbm0aQRAY1lvNOWyi+ZsBr4SSEqmk8pszCGKWeH60t /MUebwY5sWxib66Rksn61ttYGFr6d7ATrJ4FE8Q2GysbMCwhkgZk+Qb7dE9ICkUU42Dg W2vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684340175; x=1686932175; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=T7MhSAwzukH5mb94ewYmhPl0jEaGJs1Stj1FkGbbHNs=; b=CIZLj1ipatPzBq4l2qxKRFtvy1P+M/aBeigjeSXcd2Z7q3A2ko/ThkvL3uf2uSv4Sd RRyFot1KG9n1Kakld838CHQkBg6jxBQIEk5Rt3p5rIkuPdnSBlq6+gR4e01mb/QM+m/3 0zx43p3Su6VUKTp7bX/Gkaf45ClqZst8FEBmoOSi0xs/HjNbR3hxc53/hvyn+jM7D/ul wlaKiK8TOqufyV0BrdvG8n5O54LkRQ6D/NX/h0TrvCIsQ7zYvRkrYDbfNApVgj689dYB rt/PcuZzJ4ApIHhBZCPs2BD8P/QTh+y9CfZytzC5n9i8lPqrM4mwuUHbg83962HkyYl2 jinA== X-Gm-Message-State: AC+VfDyR8TbFNMYCOKEcDzRZs6HtKukWeiA9rQus/ETKsqaD7El/qrnI 8l8/b6OysTDQ8JQ2hx0wmi+iOFCO1qU2MO1IFKKh9w== X-Google-Smtp-Source: ACHHUZ4oHjPzlIzTfskYLjNeb9p21SOLZJm8bU7niuRsbq6Uo9sktWNWg1EQ4Up/b4KOJVs5wuNiZw== X-Received: by 2002:a05:6a00:1913:b0:644:ad29:fd5a with SMTP id y19-20020a056a00191300b00644ad29fd5amr207983pfi.21.1684340175403; Wed, 17 May 2023 09:16:15 -0700 (PDT) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id h5-20020a62b405000000b0063f33e216dasm15793009pfn.96.2023.05.17.09.16.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 May 2023 09:16:14 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Chaoyong He , =?utf-8?q?Niklas_S=C3=B6derlund?= Subject: [PATCH 07/20] net/nfp: remove word sanity Date: Wed, 17 May 2023 09:15:50 -0700 Message-Id: <20230517161603.117728-8-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230517161603.117728-1-stephen@networkplumber.org> References: <20230517161603.117728-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org There are two small uses of the non-inclusive term "sanity". One in comment is easily removed, other is in a macro that was defined but never used. Signed-off-by: Stephen Hemminger Reviewed-by: Chaoyong He --- drivers/net/nfp/nfp_flow.c | 2 +- drivers/net/nfp/nfpcore/nfp-common/nfp_resid.h | 13 ------------- 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c index 41b722f4d898..05507bc3a113 100644 --- a/drivers/net/nfp/nfp_flow.c +++ b/drivers/net/nfp/nfp_flow.c @@ -1944,7 +1944,7 @@ nfp_flow_compile_item_proc(struct nfp_flower_representor *repr, break; } - /* Perform basic sanity checks */ + /* Perform basic checks */ ret = nfp_flow_item_check(item, proc); if (ret != 0) { PMD_DRV_LOG(ERR, "nfp flow item %d check failed", item->type); diff --git a/drivers/net/nfp/nfpcore/nfp-common/nfp_resid.h b/drivers/net/nfp/nfpcore/nfp-common/nfp_resid.h index 394a7628e08a..b7e77d8fa051 100644 --- a/drivers/net/nfp/nfpcore/nfp-common/nfp_resid.h +++ b/drivers/net/nfp/nfpcore/nfp-common/nfp_resid.h @@ -183,19 +183,6 @@ NFP_CPP_ID_ISLAND_of(uint32_t id) (int)(((_a) << 4) | ((_b) + 4)) : -1) \ })) -/* - * Do a general sanity check on the ME ID. - * The check is on the highest possible island ID for the chip family and the - * microengine number must be a master ID. - * @param meid ME ID as created by NFP6000_MEID - */ -#define NFP6000_MEID_IS_VALID(meid) \ - (__extension__ ({ \ - typeof(meid) _a = (meid); \ - ((((_a) >> 4) < 64) && (((_a) >> 4) >= 0) && \ - (((_a) & 0xF) >= 4)) \ - })) - /* * Extract island ID from ME ID. * @param meid ME ID as created by NFP6000_MEID