[2/2] common/cnxk: fix uninitialized pointer read
Checks
Commit Message
From: Satheesh Paul <psatheesh@marvell.com>
Fix uninitialized pointer read reported in coverity scan.
Coverity issue: 375811
Fixes: 84d2ea9d4fb3 ("common/cnxk: support custom pre L2 header parsing as raw")
Cc: stable@dpdk.org
Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Kiran Kumar K <kirankumark@marvell.com>
---
drivers/common/cnxk/roc_npc_parse.c | 1 +
1 file changed, 1 insertion(+)
Comments
On Thu, May 18, 2023 at 3:35 PM <psatheesh@marvell.com> wrote:
>
> From: Satheesh Paul <psatheesh@marvell.com>
>
> Fix uninitialized pointer read reported in coverity scan.
>
> Coverity issue: 375811
> Fixes: 84d2ea9d4fb3 ("common/cnxk: support custom pre L2 header parsing as raw")
> Cc: stable@dpdk.org
>
> Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
> Reviewed-by: Kiran Kumar K <kirankumark@marvell.com>
Series applied to dpdk-next-net-mrvl/for-next-net. Thanks
> ---
> drivers/common/cnxk/roc_npc_parse.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/common/cnxk/roc_npc_parse.c b/drivers/common/cnxk/roc_npc_parse.c
> index f746b9cb6d..571fdb36fc 100644
> --- a/drivers/common/cnxk/roc_npc_parse.c
> +++ b/drivers/common/cnxk/roc_npc_parse.c
> @@ -97,6 +97,7 @@ npc_parse_pre_l2(struct npc_parse_state *pst)
> (const struct roc_npc_flow_item_raw *)pst->pattern->mask, &info,
> raw_spec_buf, raw_mask_buf);
>
> + info.def_mask = NULL;
> info.hw_mask = &hw_mask;
> npc_get_hw_supp_mask(pst, &info, lid, lt);
>
> --
> 2.39.2
>
@@ -97,6 +97,7 @@ npc_parse_pre_l2(struct npc_parse_state *pst)
(const struct roc_npc_flow_item_raw *)pst->pattern->mask, &info,
raw_spec_buf, raw_mask_buf);
+ info.def_mask = NULL;
info.hw_mask = &hw_mask;
npc_get_hw_supp_mask(pst, &info, lid, lt);