diff mbox series

freebsd/contigmem: fix function parameter list

Message ID 20230522092241.20773-1-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series freebsd/contigmem: fix function parameter list |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Performance success Performance Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-unit-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/github-robot: build success github build: passed
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS

Commit Message

Bruce Richardson May 22, 2023, 9:22 a.m. UTC 
  Functions which take no parameters should explicitly have "(void)" as
the parameter list, rather than "()".

Reported upstream on FreeBSD ports collection [1].

[1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271524

Fixes: 764bf26873b9 ("add FreeBSD support")
Cc: stable@dpdk.org

Reported-by: John Baldwin <jhb@FreeBSD.org>
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 kernel/freebsd/contigmem/contigmem.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Tyler Retzlaff May 22, 2023, 4:02 p.m. UTC | #1 
On Mon, May 22, 2023 at 10:22:41AM +0100, Bruce Richardson wrote:
> Functions which take no parameters should explicitly have "(void)" as
> the parameter list, rather than "()".
> 
> Reported upstream on FreeBSD ports collection [1].
> 
> [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271524
> 
> Fixes: 764bf26873b9 ("add FreeBSD support")
> Cc: stable@dpdk.org
> 
> Reported-by: John Baldwin <jhb@FreeBSD.org>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
Thomas Monjalon May 24, 2023, 4:03 p.m. UTC | #2 
22/05/2023 18:02, Tyler Retzlaff:
> On Mon, May 22, 2023 at 10:22:41AM +0100, Bruce Richardson wrote:
> > Functions which take no parameters should explicitly have "(void)" as
> > the parameter list, rather than "()".
> > 
> > Reported upstream on FreeBSD ports collection [1].
> > 
> > [1] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=271524
> > 
> > Fixes: 764bf26873b9 ("add FreeBSD support")
> > Cc: stable@dpdk.org
> > 
> > Reported-by: John Baldwin <jhb@FreeBSD.org>
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/kernel/freebsd/contigmem/contigmem.c b/kernel/freebsd/contigmem/contigmem.c
index bd72f4d620..7dd87599d9 100644
--- a/kernel/freebsd/contigmem/contigmem.c
+++ b/kernel/freebsd/contigmem/contigmem.c
@@ -111,7 +111,7 @@  static struct cdevsw contigmem_ops = {
 };
 
 static int
-contigmem_load()
+contigmem_load(void)
 {
 	char index_string[8], description[32];
 	int  i, error = 0;
@@ -178,7 +178,7 @@  contigmem_load()
 }
 
 static int
-contigmem_unload()
+contigmem_unload(void)
 {
 	int i;