From patchwork Tue May 23 17:39:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Kozyrev X-Patchwork-Id: 127225 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7162342B83; Tue, 23 May 2023 19:40:39 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45EC942BDA; Tue, 23 May 2023 19:40:39 +0200 (CEST) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2071.outbound.protection.outlook.com [40.107.101.71]) by mails.dpdk.org (Postfix) with ESMTP id 2B9CE40689 for ; Tue, 23 May 2023 19:40:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YkOZPIN3OrLcS8C0ifTmh5eCxdbixIv7jG3EjWcD2v+pPyO0bKCfERcqWhD0bqDA0vPJBnwynBoRCNeyOXTyy+8/oaRKHPWF75+vESJqb8ur9bqmRamsLJ8HQUciJoq71a/SnZOb4rry39rOsU6MeU+qTX0/i+iBwLdGrWcFmaYVY8cJXCxllcwsdRTeYldfqe/Bo0F1kzVpYJHCz/3eBfzJwRuVpex6Rk/hzraG9FmLHNzvFVVwBakoCv7qG41PeZCMFs3euQXTfo/kUG5HL4XPWCffjW85JCJhWCrMyMqPQ47o1vc0gY9N5U7Q8HAq3Bp1rDByBhapw+Gitil0Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=b1COzamyuotlviKBVQZxTihoCGiAnx+NErARyaBwCy8=; b=fnXfE5lWqXs2HWeZW7EhT8bcDW4dT98EMUYHoB+nMe5Xf/Y+MbeKpoa1Hs6C/3/nVJo8UzmergFwFnzrApCNXkM9L0CJmQYXGfyLr882o+RDFTA3cFw29E6Zcv/WV+LS5tcONKB15c/KU9VmOO0I6k8kuxe7LKzKJnAPcJaRqCOSnUiPuEmd2SFQwiraS8FmT+sPJ+S39ocypy+ZpcwvMZHNgOQlgpipBnmy1UwL4OjXQ2kNSuu1NQjV3AvurI6y9Ml2s+e7EqpQ67XIhHWF3e8KmQEpQYh9XeF6x3JIVngvceKxQ1M21TYtE60G7zp06LPLv1JNvr2YuzwHth77Sw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b1COzamyuotlviKBVQZxTihoCGiAnx+NErARyaBwCy8=; b=s8iGI2paZ/v/rfyWG7nX3y6C+eUfY5ArMZBpfRaRr3VyF94MgiC1ND/qDh0sUa9DCEMyJg4KRHz9T+ZPaN9D8J3EOMc3y56ihRk4TEggS0YxIXYG8f+RTInBYp6grP+TgDUP5P5dEAl5OYVDCjNSGQDDjqakiad1iRMo4cxRxJwz0MSzM+5qHDQIyPTcIfmTHz5mLk2SYNPo1IiEvBV83WbfzRnPyrwoKJ7xBun7Cwc24AfOUooZm4//LEstsAUvxYqVtsakoFlFEJUDnMNw8MryEBTdUElIQEWIkWrE7i6THJJQB19ViKTBGgZiWqp4fUhNe7aJ3n6C6Bsa65cUpA== Received: from MW4PR03CA0273.namprd03.prod.outlook.com (2603:10b6:303:b5::8) by PH8PR12MB7230.namprd12.prod.outlook.com (2603:10b6:510:226::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Tue, 23 May 2023 17:40:36 +0000 Received: from CO1NAM11FT022.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b5:cafe::ec) by MW4PR03CA0273.outlook.office365.com (2603:10b6:303:b5::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 17:40:36 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1NAM11FT022.mail.protection.outlook.com (10.13.175.199) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.29 via Frontend Transport; Tue, 23 May 2023 17:40:35 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Tue, 23 May 2023 10:40:20 -0700 Received: from pegasus01.mtr.labs.mlnx (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Tue, 23 May 2023 10:40:18 -0700 From: Alexander Kozyrev To: CC: , , , Subject: [PATCH v2] ethdev: fix asynchronous destroy and push tracepoints Date: Tue, 23 May 2023 20:39:42 +0300 Message-ID: <20230523173942.3360396-1-akozyrev@nvidia.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20230518215928.2366851-1-akozyrev@nvidia.com> References: <20230518215928.2366851-1-akozyrev@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT022:EE_|PH8PR12MB7230:EE_ X-MS-Office365-Filtering-Correlation-Id: 2ab2eb45-da94-44fd-baae-08db5bb4d0e6 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TqFa3v41Wcchep6nAQlB5FlDepRQdpj2j2U8SH6jfChDjoMTZPnhk/5vhHuEcewlJh4LDMZIIfc6cFej1lmrst2F8La5j1BZqK76eYaAcLs2UeMA3DHERIjcIkKnYBtWGtAPBFXpB8/mwAIL4mNs9GjgbPkLHfrFnVk5vhfzlju2+67GaRW6+P3Rbn54FEJkp9NmSmZcoTwOquvGH/iH6jcldJKTdnzxLuAb1x/7+DQdjMjEFuiWVw2mUGAiDJ65lBak1zxOvv0hQpE9ihRNSlUMw09/xwjwwcnZndD4j3MelWzcBKuYc2n+WqcYd32JNMYC+DEJ/UCPSKPDcu5y4cWFoXPxx8yuV+kRpzY9H+01cjp0uAvifCnTU3Icnyvb3vyqNIlhz1vqsLmojPggTjAMIycuggwQq7EbpRxsx8nATyG2jnkwo30xw5uwNWIwZI6Cz9JAcx/jwzI+RInTY5wxSXi73lvTgYkEHmh7zqXAIqwRYdiZgLRdZ2hbgva6Gyazzc5z9syuRX53RezfeBQITGKMyi3C2KiLNAz2PsBQTvlNgqtE5+MkxxU+EpB0RXC2IRhvUG3OYrZfFcf1rg8waVgz8zM8QpH0PScvNJ4IGyPvHqtYcigQY1j+Qmlt6NKY3ncSNgCLPspAkWwaF7PFIDnpzD42f4zWM1lpRYA7ykTtg3Mbi2UcGO92yIsY19EITvCOhJAGX6ij8zAgkj/we+V+TYHS4gyUba1rErk= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(346002)(376002)(396003)(39860400002)(136003)(451199021)(36840700001)(40470700004)(46966006)(186003)(356005)(7636003)(82740400003)(40460700003)(1076003)(26005)(2616005)(47076005)(36860700001)(36756003)(336012)(426003)(83380400001)(16526019)(2906002)(40480700001)(316002)(6666004)(70586007)(4326008)(6916009)(70206006)(41300700001)(54906003)(82310400005)(86362001)(478600001)(8676002)(8936002)(5660300002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 May 2023 17:40:35.8673 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2ab2eb45-da94-44fd-baae-08db5bb4d0e6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT022.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7230 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rte_flow_async_destroy() and rte_flow_push() API is intended to be as fast as possible and tracepoints for these functions must be marked as fast-path tracepoints. Fixes: 6679cf21d608 ("ethdev: add trace points") Signed-off-by: Alexander Kozyrev Acked-by: Ankur Dwivedi Acked-by: Ori Kam --- lib/ethdev/ethdev_trace.h | 42 +++++++++++++++++++-------------------- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/lib/ethdev/ethdev_trace.h b/lib/ethdev/ethdev_trace.h index 3dc7d028b8..18bf1a706f 100644 --- a/lib/ethdev/ethdev_trace.h +++ b/lib/ethdev/ethdev_trace.h @@ -1582,27 +1582,6 @@ RTE_TRACE_POINT( rte_trace_point_emit_int(ret); ) -RTE_TRACE_POINT( - rte_flow_trace_async_destroy, - RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, - const struct rte_flow_op_attr *op_attr, - const struct rte_flow *flow, const void *user_data, int ret), - rte_trace_point_emit_u16(port_id); - rte_trace_point_emit_u32(queue_id); - rte_trace_point_emit_ptr(op_attr); - rte_trace_point_emit_ptr(flow); - rte_trace_point_emit_ptr(user_data); - rte_trace_point_emit_int(ret); -) - -RTE_TRACE_POINT( - rte_flow_trace_push, - RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, int ret), - rte_trace_point_emit_u16(port_id); - rte_trace_point_emit_u32(queue_id); - rte_trace_point_emit_int(ret); -) - RTE_TRACE_POINT( rte_mtr_trace_capabilities_get, RTE_TRACE_POINT_ARGS(uint16_t port_id, @@ -2345,6 +2324,27 @@ RTE_TRACE_POINT_FP( rte_trace_point_emit_ptr(flow); ) +RTE_TRACE_POINT_FP( + rte_flow_trace_async_destroy, + RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, + const struct rte_flow_op_attr *op_attr, + const struct rte_flow *flow, const void *user_data, int ret), + rte_trace_point_emit_u16(port_id); + rte_trace_point_emit_u32(queue_id); + rte_trace_point_emit_ptr(op_attr); + rte_trace_point_emit_ptr(flow); + rte_trace_point_emit_ptr(user_data); + rte_trace_point_emit_int(ret); +) + +RTE_TRACE_POINT_FP( + rte_flow_trace_push, + RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id, int ret), + rte_trace_point_emit_u16(port_id); + rte_trace_point_emit_u32(queue_id); + rte_trace_point_emit_int(ret); +) + RTE_TRACE_POINT_FP( rte_flow_trace_pull, RTE_TRACE_POINT_ARGS(uint16_t port_id, uint32_t queue_id,