[v3] usertools/telemetry: fix unused parameter
Checks
Commit Message
This bug fix ensures that the runtime socket path is generated
correctly, based on the user-specified file_prefix value,
resolving the issue that occurred in the previous implementation.
Fixes: a15fc792cfb6 ("usertools/telemetry: add file prefix argument")
Cc: lihuisong@huawei.com
Signed-off-by: Samina Arshad <samina.arshad@intel.com>
Acked-by: Ciara Power <ciara.power@intel.com>
---
v2:
Made changes for previous commit to be efficient. Removed
"args" from "args.file_prefix".
---
v3:
Edit commit body by removing stable@dpdk.org from cc as
the fix is not needed to be backported to 21.11 or 22.11.
---
---
usertools/dpdk-telemetry-client.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
在 2023/5/25 23:50, Samina Arshad 写道:
> This bug fix ensures that the runtime socket path is generated
> correctly, based on the user-specified file_prefix value,
> resolving the issue that occurred in the previous implementation.
>
> Fixes: a15fc792cfb6 ("usertools/telemetry: add file prefix argument")
> Cc: lihuisong@huawei.com
>
> Signed-off-by: Samina Arshad <samina.arshad@intel.com>
> Acked-by: Ciara Power <ciara.power@intel.com>
> ---
> v2:
> Made changes for previous commit to be efficient. Removed
> "args" from "args.file_prefix".
> ---
> v3:
> Edit commit body by removing stable@dpdk.org from cc as
> the fix is not needed to be backported to 21.11 or 22.11.
> ---
> ---
> usertools/dpdk-telemetry-client.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/usertools/dpdk-telemetry-client.py b/usertools/dpdk-telemetry-client.py
> index d6718ca5b0..e3bb1c9ee0 100755
> --- a/usertools/dpdk-telemetry-client.py
> +++ b/usertools/dpdk-telemetry-client.py
> @@ -55,8 +55,8 @@ def getFilepath(self, file_path):
> # Gets arguments from Command-Line and assigns to instance of client
> self.file_path = file_path
>
> - def setRunpath(self, file_path):
> - self.run_path = os.path.join(get_dpdk_runtime_dir(args.file_prefix),
> + def setRunpath(self, file_prefix):
> + self.run_path = os.path.join(get_dpdk_runtime_dir(file_prefix),
> RUNTIME_SOCKET_NAME)
Apologise for the mistake.
Acked-by: lihuisong@huawei.com
>
> def register(self):
26/05/2023 05:41, lihuisong (C):
> 在 2023/5/25 23:50, Samina Arshad 写道:
> > This bug fix ensures that the runtime socket path is generated
> > correctly, based on the user-specified file_prefix value,
> > resolving the issue that occurred in the previous implementation.
In general we require to describe the issue,
but I'll accept this one as it is simple enough.
> >
> > Fixes: a15fc792cfb6 ("usertools/telemetry: add file prefix argument")
> > Cc: lihuisong@huawei.com
> >
> > Signed-off-by: Samina Arshad <samina.arshad@intel.com>
> > Acked-by: Ciara Power <ciara.power@intel.com>
> Acked-by: lihuisong@huawei.com
Applied, thanks.
@@ -55,8 +55,8 @@ def getFilepath(self, file_path):
# Gets arguments from Command-Line and assigns to instance of client
self.file_path = file_path
- def setRunpath(self, file_path):
- self.run_path = os.path.join(get_dpdk_runtime_dir(args.file_prefix),
+ def setRunpath(self, file_prefix):
+ self.run_path = os.path.join(get_dpdk_runtime_dir(file_prefix),
RUNTIME_SOCKET_NAME)
def register(self):