From patchwork Tue May 30 09:05:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jie Hai X-Patchwork-Id: 127692 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 682C742BE1; Tue, 30 May 2023 11:07:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F232742D33; Tue, 30 May 2023 11:07:44 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id D4B4442D0D for ; Tue, 30 May 2023 11:07:41 +0200 (CEST) Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QVmkW3k9MzSqQt; Tue, 30 May 2023 17:07:31 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 30 May 2023 17:07:39 +0800 From: Jie Hai To: Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko CC: , Subject: [PATCH 03/10] ethdev: support telemetry query flow ctrl info Date: Tue, 30 May 2023 17:05:03 +0800 Message-ID: <20230530090510.56812-4-haijie1@huawei.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20230530090510.56812-1-haijie1@huawei.com> References: <20230530090510.56812-1-haijie1@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.69.192.56] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemi500020.china.huawei.com (7.221.188.8) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch supports telemetry querying flow control info. The command is like: --> /ethdev/flow_ctrl,0 { "/ethdev/flow_ctrl": { "high_waterline": "0x0", "low_waterline": "0x0", "pause_time": "0xffff", "send_xon": "off", "mac_ctrl_frame_fwd": "off", "rx_pause": "off", "tx_pause": "off", "autoneg": "off" } } Signed-off-by: Jie Hai --- lib/ethdev/rte_ethdev.c | 51 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 51 insertions(+) diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c index 3207b3177256..5cdb310ca979 100644 --- a/lib/ethdev/rte_ethdev.c +++ b/lib/ethdev/rte_ethdev.c @@ -7121,6 +7121,55 @@ eth_dev_handle_port_macs(const char *cmd __rte_unused, return 0; } +static int +eth_dev_handle_port_flow_ctrl(const char *cmd __rte_unused, + const char *params, + struct rte_tel_data *d) +{ + struct rte_eth_fc_conf fc_conf; + unsigned long port_id; + char *end_param; + bool rx_fc_en; + bool tx_fc_en; + int ret; + + if (params == NULL || strlen(params) == 0 || !isdigit(*params)) + return -EINVAL; + + port_id = strtoul(params, &end_param, 0); + if (*end_param != '\0') + RTE_ETHDEV_LOG(NOTICE, + "Extra parameters passed to ethdev telemetry command, ignoring\n"); + + if (port_id >= UINT16_MAX || !rte_eth_dev_is_valid_port(port_id)) + return -EINVAL; + + ret = rte_eth_dev_flow_ctrl_get(port_id, &fc_conf); + if (ret != 0) { + RTE_ETHDEV_LOG(ERR, + "Failed to get flow ctrl info, ret = %d\n", ret); + return ret; + } + + rx_fc_en = fc_conf.mode == RTE_ETH_FC_RX_PAUSE || + fc_conf.mode == RTE_ETH_FC_FULL; + tx_fc_en = fc_conf.mode == RTE_ETH_FC_TX_PAUSE || + fc_conf.mode == RTE_ETH_FC_FULL; + + rte_tel_data_start_dict(d); + rte_tel_data_add_dict_uint_hex(d, "high_waterline", fc_conf.high_water, 0); + rte_tel_data_add_dict_uint_hex(d, "low_waterline", fc_conf.low_water, 0); + rte_tel_data_add_dict_uint_hex(d, "pause_time", fc_conf.pause_time, 0); + rte_tel_data_add_dict_string(d, "send_xon", fc_conf.send_xon ? "on" : "off"); + rte_tel_data_add_dict_string(d, "mac_ctrl_frame_fwd", + fc_conf.mac_ctrl_frame_fwd ? "on" : "off"); + rte_tel_data_add_dict_string(d, "rx_pause", rx_fc_en ? "on" : "off"); + rte_tel_data_add_dict_string(d, "tx_pause", tx_fc_en ? "on" : "off"); + rte_tel_data_add_dict_string(d, "autoneg", fc_conf.autoneg ? "on" : "off"); + + return 0; +} + RTE_LOG_REGISTER_DEFAULT(rte_eth_dev_logtype, INFO); RTE_INIT(ethdev_init_telemetry) @@ -7144,4 +7193,6 @@ RTE_INIT(ethdev_init_telemetry) "Returns module EEPROM info with SFF specs. Parameters: int port_id"); rte_telemetry_register_cmd("/ethdev/macs", eth_dev_handle_port_macs, "Returns the MAC addresses for a port. Parameters: int port_id"); + rte_telemetry_register_cmd("/ethdev/flow_ctrl", eth_dev_handle_port_flow_ctrl, + "Returns flow ctrl info for a port. Parameters: unsigned port_id"); }