pci: fix comment referencing renamed function
Checks
Commit Message
When renaming functions eal_parse_pci_*,
a referencing comment was missed in the function rte_pci_device_name().
Fixes: ca52fccbb3b9 ("pci: remove deprecated functions")
Cc: stable@dpdk.org
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
lib/pci/rte_pci.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
Comments
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Wednesday, May 31, 2023 12:02 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Gaetan Rivet <grive@u256.net>; David Marchand
> <david.marchand@redhat.com>
> Subject: [PATCH] pci: fix comment referencing renamed function
>
> When renaming functions eal_parse_pci_*,
> a referencing comment was missed in the function rte_pci_device_name().
>
> Fixes: ca52fccbb3b9 ("pci: remove deprecated functions")
> Cc: stable@dpdk.org
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> lib/pci/rte_pci.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/pci/rte_pci.h b/lib/pci/rte_pci.h
> index 5088157e74..aab761b918 100644
> --- a/lib/pci/rte_pci.h
> +++ b/lib/pci/rte_pci.h
> @@ -104,8 +104,7 @@ struct rte_pci_addr {
>
> /**
> * Utility function to write a pci device name, this device name can
> later be
> - * used to retrieve the corresponding rte_pci_addr using eal_parse_pci_*
> - * BDF helpers.
> + * used to retrieve the corresponding rte_pci_addr using
> rte_pci_addr_parse().
> *
> * @param addr
> * The PCI Bus-Device-Function address
> --
> 2.40.1
Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
31/05/2023 08:02, Xia, Chenbo:
> > -----Original Message-----
> > From: Thomas Monjalon <thomas@monjalon.net>
> > Sent: Wednesday, May 31, 2023 12:02 AM
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Gaetan Rivet <grive@u256.net>; David Marchand
> > <david.marchand@redhat.com>
> > Subject: [PATCH] pci: fix comment referencing renamed function
> >
> > When renaming functions eal_parse_pci_*,
> > a referencing comment was missed in the function rte_pci_device_name().
> >
> > Fixes: ca52fccbb3b9 ("pci: remove deprecated functions")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>
Applied
@@ -104,8 +104,7 @@ struct rte_pci_addr {
/**
* Utility function to write a pci device name, this device name can later be
- * used to retrieve the corresponding rte_pci_addr using eal_parse_pci_*
- * BDF helpers.
+ * used to retrieve the corresponding rte_pci_addr using rte_pci_addr_parse().
*
* @param addr
* The PCI Bus-Device-Function address