From patchwork Thu Jun 1 11:42:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Denis Pryazhennikov X-Patchwork-Id: 127832 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5230B42C02; Thu, 1 Jun 2023 13:42:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D52B742B8B; Thu, 1 Jun 2023 13:42:25 +0200 (CEST) Received: from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80]) by mails.dpdk.org (Postfix) with ESMTP id 8AB6D40DDC for ; Thu, 1 Jun 2023 13:42:23 +0200 (CEST) Received: from localhost.localdomain (unknown [37.252.90.53]) (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA512) (No client certificate requested) by agw.arknetworks.am (Postfix) with ESMTPSA id E3854E1241; Thu, 1 Jun 2023 15:42:22 +0400 (+04) From: Denis Pryazhennikov To: dev@dpdk.org Cc: Viacheslav Galaktionov , Ferruh Yigit , Andrew Rybchenko , Sandilya Bhagi , Andy Moreton Subject: [PATCH 1/4] common/sfc_efx/base: NIC Partitioning mode discovery using heuristic approach Date: Thu, 1 Jun 2023 15:42:17 +0400 Message-Id: <20230601114220.17796-2-denis.pryazhennikov@arknetworks.am> X-Mailer: git-send-email 2.37.0 (Apple Git-136) In-Reply-To: <20230601114220.17796-1-denis.pryazhennikov@arknetworks.am> References: <20230601114220.17796-1-denis.pryazhennikov@arknetworks.am> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org NIC Partitioning mode in SFN devices means multiple PFs per network port. When NIC Partitioning is configured, apart from the privileged adapter(s) the other unprivileged adapter(s) will share the same physical port. Determining NIC Partitioning mode is required to take necessary action(s) for unprivileged adapter to work seamlessly. NIC Partitioning is determined using heuristic approach - If the physical ports are shared between PFs then either NIC Partitioning or SR-IOV is in use. When NIC Partitioning is in use MAX MTU workaround should be applied so that the unprivileged functions can seamlessly configure any valid MTU. hg-changeset: 7f0abee725a8e9c6524e773e5e5d6286a3b027a4 Signed-off-by: Sandilya Bhagi Signed-off-by: Denis Pryazhennikov Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/base/ef10_nic.c | 109 +++++++++++++++++++++++++ drivers/common/sfc_efx/base/efx.h | 8 ++ 2 files changed, 117 insertions(+) diff --git a/drivers/common/sfc_efx/base/ef10_nic.c b/drivers/common/sfc_efx/base/ef10_nic.c index e1709d120093..db4834a65175 100644 --- a/drivers/common/sfc_efx/base/ef10_nic.c +++ b/drivers/common/sfc_efx/base/ef10_nic.c @@ -1044,6 +1044,89 @@ ef10_mcdi_get_pf_count( return (rc); } +static __checkReturn efx_rc_t +ef10_nic_get_physical_port_usage( + __in efx_nic_t *enp, + __in_ecount(pfs_to_ports_size) uint8_t *pfs_to_ports, + __in size_t pfs_to_ports_size, + __out efx_port_usage_t *port_usagep) +{ + efx_nic_cfg_t *encp = &(enp->en_nic_cfg); + efx_port_usage_t port_usage; + size_t pf; + uint8_t phy_port; + efx_rc_t rc; + + /* + * The sharing of physical ports between functions are determined + * in the following way. + * 1. If VFs are enabled then the physical port is shared. + * 2. Retrieve PFs to ports assignment. + * 3. If PF 0 assignment cannot be retrieved(ACCESS_DENIED), it + * implies this is an unprivileged function. An unprivileged + * function indicates the physical port must be shared with + * another privileged function. + * 4. If PF 0 assignment can be retrieved, it indicates this + * function is privileged. Now, read all other PF's physical + * port number assignment and check if the current PF's physical + * port is shared with any other PF's physical port. + * NOTE: Sharing of physical ports (using heuristic approach) can + * imply either NIC Partitioning or SR-IOV is in use. This info is + * sufficient to apply the max MTU workaround (WIN-628), but should + * not be used for other purposes. + * NOTE: PF 0 is always privileged function. + */ + + if (EFX_PCI_FUNCTION_IS_VF(encp)) { + port_usage = EFX_PORT_USAGE_SHARED; + goto out; + } + + if (pfs_to_ports[0] == + MC_CMD_GET_CAPABILITIES_V2_OUT_ACCESS_NOT_PERMITTED) { + /* + * This is unprivileged function as it do not have sufficient + * privileges to read the value, this implies the physical port + * is shared between this function and another privileged + * function + */ + port_usage = EFX_PORT_USAGE_SHARED; + goto out; + } + + if (encp->enc_pf >= pfs_to_ports_size) { + rc = EINVAL; + goto fail1; + } + phy_port = pfs_to_ports[encp->enc_pf]; + + /* + * This is privileged function as it is able read the value of + * PF 0. Now, check if any other function share the same physical + * port number as this function. + */ + for (pf = 0; pf < pfs_to_ports_size; pf++) { + + if ((encp->enc_pf != pf) && + (phy_port == pfs_to_ports[pf])) { + /* Found match, PFs share the same physical port */ + port_usage = EFX_PORT_USAGE_SHARED; + goto out; + } + } + + port_usage = EFX_PORT_USAGE_EXCLUSIVE; + +out: + *port_usagep = port_usage; + return (0); + +fail1: + EFSYS_PROBE1(fail1, efx_rc_t, rc); + + return (rc); +} + static __checkReturn efx_rc_t ef10_get_datapath_caps( __in efx_nic_t *enp) @@ -1307,6 +1390,32 @@ ef10_get_datapath_caps( encp->enc_tunnel_config_udp_entries_max = 0; } +#define CAP_PFS_TO_PORTS(_n) \ + (MC_CMD_GET_CAPABILITIES_V2_OUT_PFS_TO_PORTS_ASSIGNMENT_ ## _n) + + encp->enc_port_usage = EFX_PORT_USAGE_UNKNOWN; + + if (req.emr_out_length_used >= MC_CMD_GET_CAPABILITIES_V2_OUT_LEN) { + /* PFs to ports assignment */ + uint8_t pfs_to_ports[CAP_PFS_TO_PORTS(NUM)]; + efx_byte_t *bytep; + int i; + + bytep = MCDI_OUT(req, efx_byte_t, CAP_PFS_TO_PORTS(OFST)); + for (i = 0; i < EFX_ARRAY_SIZE(pfs_to_ports); i++) { + pfs_to_ports[i] = EFX_BYTE_FIELD(*bytep, EFX_BYTE_0); + bytep += CAP_PFS_TO_PORTS(LEN); + } + + if (ef10_nic_get_physical_port_usage(enp, + pfs_to_ports, EFX_ARRAY_SIZE(pfs_to_ports), + &encp->enc_port_usage) != 0) { + /* PF to port mapping lookup failed */ + encp->enc_port_usage = EFX_PORT_USAGE_UNKNOWN; + } + } +#undef CAP_PFS_TO_PORTS + /* * Check if firmware reports the VI window mode. * Medford2 has a variable VI window size (8K, 16K or 64K). diff --git a/drivers/common/sfc_efx/base/efx.h b/drivers/common/sfc_efx/base/efx.h index 49e29dcc1c69..93bb4916bfd6 100644 --- a/drivers/common/sfc_efx/base/efx.h +++ b/drivers/common/sfc_efx/base/efx.h @@ -311,6 +311,12 @@ efx_nic_check_pcie_link_speed( __in uint32_t pcie_link_gen, __out efx_pcie_link_performance_t *resultp); +typedef enum efx_port_usage_e { + EFX_PORT_USAGE_UNKNOWN = 0, + EFX_PORT_USAGE_EXCLUSIVE, /* Port only used by this PF */ + EFX_PORT_USAGE_SHARED, /* Port shared with other PFs */ +} efx_port_usage_t; + #define EFX_MAC_ADDR_LEN 6 #if EFSYS_OPT_MCDI @@ -1680,6 +1686,8 @@ typedef struct efx_nic_cfg_s { uint32_t enc_assigned_port; /* NIC DMA mapping type */ efx_nic_dma_mapping_t enc_dma_mapping; + /* Physical ports shared by PFs */ + efx_port_usage_t enc_port_usage; } efx_nic_cfg_t; #define EFX_PCI_VF_INVALID 0xffff