diff mbox series

[16/25] net/dpaa*: replace snprintf with strlcpy

Message ID	20230601150106.18375-17-stephen@networkplumber.org (mailing list archive)
State	Rejected, archived
Delegated to:	Thomas Monjalon
Headers	From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org>, Hemant Agrawal <hemant.agrawal@nxp.com>, Sachin Saxena <sachin.saxena@nxp.com> Subject: [PATCH 16/25] net/dpaa*: replace snprintf with strlcpy Date: Thu, 1 Jun 2023 08:00:57 -0700 Message-Id: <20230601150106.18375-17-stephen@networkplumber.org> In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	replace snprintf with strlcpy \| [00/25] replace snprintf with strlcpy [01/25] app: use strlcpy in tests [02/25] examples: use strlcpy instead of snprintf [03/25] lib: use strlcpy instead of snprintf [04/25] raw/ifpga: replace snprintf with strlcpy [05/25] common/cnxk: replace snprint with strlcpy [06/25] common/mlx5: replace snprintf with strlcpy [07/25] drivers/gpu: replace snprintf with strlcpy [08/25] crypto/ipsec_mb: remove unnecessary snprintf [09/25] crypto/dpaa_sec: replace snprintf with strlcpy [10/25] event/cnxk: replace snprintf with strlcpy [11/25] net/atlantic: replace snprintf with strlcpy [12/25] net/axgbe: replace snprintf with strlcpy [13/25] net/bnxt: replace snprintf with strlcpy [14/25] net/cpfl: replace snprintf with strlcpy [15/25] net/cxgbe: replace snprintf with strlcpy [16/25] net/dpaa*: replace snprintf with strlcpy [17/25] net/hinic: replace snptintf with strlcpy [18/25] net/hns3: replace snprint with strlcpy [19/25] net/intel: replace snprintf with strlcpy [20/25] net/ionic: replace snprintf with strlcpy [21/25] net/mlx5: replace snprintf with strlcpy [22/25] net/nfp: replace snprintf with strlcpy [23/25] net/ngbe: replace snprintf with strlcpy [24/25] net/qede: replace snprintf with strlcpy [25/25] net/txgbe: replace snprintf with strlcpy

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Stephen Hemminger June 1, 2023, 3 p.m. UTC

Suggested by devtools/cocci/strlcpy-with-header.cocci

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/dpaa/dpaa_ethdev.c   | 8 ++++----
 drivers/net/dpaa2/dpaa2_ethdev.c | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

Comments

Hemant Agrawal June 2, 2023, 4:24 a.m. UTC | #1

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

diff mbox series

Patch

diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index a6c86113d125..0076a531005b 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -620,8 +620,8 @@  dpaa_dev_rx_burst_mode_get(struct rte_eth_dev *dev,
 	/* Update Rx offload info */
 	for (i = 0; i < RTE_DIM(rx_offload_map); i++) {
 		if (eth_conf->rxmode.offloads & rx_offload_map[i].flags) {
-			snprintf(mode->info, sizeof(mode->info), "%s",
-				rx_offload_map[i].output);
+			strlcpy(mode->info, rx_offload_map[i].output,
+				sizeof(mode->info));
 			ret = 0;
 			break;
 		}
@@ -654,8 +654,8 @@  dpaa_dev_tx_burst_mode_get(struct rte_eth_dev *dev,
 	/* Update Tx offload info */
 	for (i = 0; i < RTE_DIM(tx_offload_map); i++) {
 		if (eth_conf->txmode.offloads & tx_offload_map[i].flags) {
-			snprintf(mode->info, sizeof(mode->info), "%s",
-				tx_offload_map[i].output);
+			strlcpy(mode->info, tx_offload_map[i].output,
+				sizeof(mode->info));
 			ret = 0;
 			break;
 		}
diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index 679f33ae1a08..baa1c2d1ea0f 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -313,8 +313,8 @@  dpaa2_dev_rx_burst_mode_get(struct rte_eth_dev *dev,
 	/* Update Rx offload info */
 	for (i = 0; i < RTE_DIM(rx_offload_map); i++) {
 		if (eth_conf->rxmode.offloads & rx_offload_map[i].flags) {
-			snprintf(mode->info, sizeof(mode->info), "%s",
-				rx_offload_map[i].output);
+			strlcpy(mode->info, rx_offload_map[i].output,
+				sizeof(mode->info));
 			ret = 0;
 			break;
 		}
@@ -348,8 +348,8 @@  dpaa2_dev_tx_burst_mode_get(struct rte_eth_dev *dev,
 	/* Update Tx offload info */
 	for (i = 0; i < RTE_DIM(tx_offload_map); i++) {
 		if (eth_conf->txmode.offloads & tx_offload_map[i].flags) {
-			snprintf(mode->info, sizeof(mode->info), "%s",
-				tx_offload_map[i].output);
+			strlcpy(mode->info, tx_offload_map[i].output,
+				sizeof(mode->info));
 			ret = 0;
 			break;
 		}