diff mbox series

[03/25] lib: use strlcpy instead of snprintf

Message ID	20230601150106.18375-4-stephen@networkplumber.org (mailing list archive)
State	Rejected, archived
Delegated to:	Thomas Monjalon
Headers	From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org>, Nicolas Chautru <nicolas.chautru@intel.com>, Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@amd.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru> Subject: [PATCH 03/25] lib: use strlcpy instead of snprintf Date: Thu, 1 Jun 2023 08:00:44 -0700 Message-Id: <20230601150106.18375-4-stephen@networkplumber.org> In-Reply-To: <20230601150106.18375-1-stephen@networkplumber.org> References: <20230601150106.18375-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	replace snprintf with strlcpy \| [00/25] replace snprintf with strlcpy [01/25] app: use strlcpy in tests [02/25] examples: use strlcpy instead of snprintf [03/25] lib: use strlcpy instead of snprintf [04/25] raw/ifpga: replace snprintf with strlcpy [05/25] common/cnxk: replace snprint with strlcpy [06/25] common/mlx5: replace snprintf with strlcpy [07/25] drivers/gpu: replace snprintf with strlcpy [08/25] crypto/ipsec_mb: remove unnecessary snprintf [09/25] crypto/dpaa_sec: replace snprintf with strlcpy [10/25] event/cnxk: replace snprintf with strlcpy [11/25] net/atlantic: replace snprintf with strlcpy [12/25] net/axgbe: replace snprintf with strlcpy [13/25] net/bnxt: replace snprintf with strlcpy [14/25] net/cpfl: replace snprintf with strlcpy [15/25] net/cxgbe: replace snprintf with strlcpy [16/25] net/dpaa*: replace snprintf with strlcpy [17/25] net/hinic: replace snptintf with strlcpy [18/25] net/hns3: replace snprint with strlcpy [19/25] net/intel: replace snprintf with strlcpy [20/25] net/ionic: replace snprintf with strlcpy [21/25] net/mlx5: replace snprintf with strlcpy [22/25] net/nfp: replace snprintf with strlcpy [23/25] net/ngbe: replace snprintf with strlcpy [24/25] net/qede: replace snprintf with strlcpy [25/25] net/txgbe: replace snprintf with strlcpy

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Stephen Hemminger June 1, 2023, 3 p.m. UTC

  Replace snprintf with strlcpy where possible.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/bbdev/rte_bbdev.c |  2 +-
 lib/ethdev/sff_8636.c | 11 +++++++----
 2 files changed, 8 insertions(+), 5 deletions(-)

diff mbox series

Patch

diff --git a/lib/bbdev/rte_bbdev.c b/lib/bbdev/rte_bbdev.c
index 581509b5a213..7cc126a0e7be 100644
--- a/lib/bbdev/rte_bbdev.c
+++ b/lib/bbdev/rte_bbdev.c
@@ -212,7 +212,7 @@  rte_bbdev_allocate(const char *name)
 	bbdev->data->dev_id = dev_id;
 	bbdev->state = RTE_BBDEV_INITIALIZED;
 
-	ret = snprintf(bbdev->data->name, RTE_BBDEV_NAME_MAX_LEN, "%s", name);
+	ret = strlcpy(bbdev->data->name, name, RTE_BBDEV_NAME_MAX_LEN);
 	if ((ret < 0) || (ret >= RTE_BBDEV_NAME_MAX_LEN)) {
 		rte_bbdev_log(ERR, "Copying device name \"%s\" failed", name);
 		return NULL;
diff --git a/lib/ethdev/sff_8636.c b/lib/ethdev/sff_8636.c
index 6b65f47efedf..a623e0d065d8 100644
--- a/lib/ethdev/sff_8636.c
+++ b/lib/ethdev/sff_8636.c
@@ -203,16 +203,19 @@  static void sff_8636_show_ext_identifier(const uint8_t *data, struct rte_tel_dat
 
 	switch (data[SFF_8636_EXT_ID_OFFSET] & SFF_8636_EXT_ID_EPWR_CLASS_MASK) {
 	case SFF_8636_EXT_ID_PWR_CLASS_LEGACY:
-		snprintf(val_string, sizeof(val_string), "%s", "");
+		strlcpy(val_string, "", sizeof(val_string));
 		break;
 	case SFF_8636_EXT_ID_PWR_CLASS_5:
-		snprintf(val_string, sizeof(val_string), "%s", "4.0W max. Power consumption, ");
+		strlcpy(val_string, "4.0W max. Power consumption, ",
+			sizeof(val_string));
 		break;
 	case SFF_8636_EXT_ID_PWR_CLASS_6:
-		snprintf(val_string, sizeof(val_string), "%s", "4.5W max. Power consumption, ");
+		strlcpy(val_string, "4.5W max. Power consumption, ",
+			sizeof(val_string));
 		break;
 	case SFF_8636_EXT_ID_PWR_CLASS_7:
-		snprintf(val_string, sizeof(val_string), "%s", "5.0W max. Power consumption, ");
+		strlcpy(val_string, "5.0W max. Power consumption, ",
+			sizeof(val_string));
 		break;
 	}