diff mbox series

[1/6] crypto/qat: fix sym device prototype

Message ID 20230609135450.476983-2-maxime.coquelin@redhat.com (mailing list archive)
State Superseded, archived
Delegated to: akhil goyal
Headers
Series Trivial crypto PMDs cleanup |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Maxime Coquelin June 9, 2023, 1:54 p.m. UTC 
  qat_dev_cmd_param parameter of qat_sym_dev_create() was
wrongly marked as unused, this patch fixes it.

Fixes: fb3b9f492205 ("crypto/qat: rework burst data path")
Cc: stable@dpdk.org

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 drivers/crypto/qat/qat_sym.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Zhang, Fan June 9, 2023, 2:03 p.m. UTC | #1 
On 6/9/2023 2:54 PM, Maxime Coquelin wrote:
> qat_dev_cmd_param parameter of qat_sym_dev_create() was
> wrongly marked as unused, this patch fixes it.
>
> Fixes: fb3b9f492205 ("crypto/qat: rework burst data path")
> Cc: stable@dpdk.org
>
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>   drivers/crypto/qat/qat_sym.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c
> index 08e92191a3..2450f042c8 100644
> --- a/drivers/crypto/qat/qat_sym.c
> +++ b/drivers/crypto/qat/qat_sym.c
> @@ -179,7 +179,7 @@ qat_sym_dequeue_burst(void *qp, struct rte_crypto_op **ops,
>   
>   int
>   qat_sym_dev_create(struct qat_pci_device *qat_pci_dev,
> -		struct qat_dev_cmd_param *qat_dev_cmd_param __rte_unused)
> +		struct qat_dev_cmd_param *qat_dev_cmd_param)
>   {
>   	int i = 0, ret = 0;
>   	uint16_t slice_map = 0;

Acked-by: Fan Zhang <fanzhang.oss@gmail.com>
Tyler Retzlaff June 9, 2023, 3:40 p.m. UTC | #2 
On Fri, Jun 09, 2023 at 03:03:25PM +0100, Zhang, Fan wrote:
> 
> On 6/9/2023 2:54 PM, Maxime Coquelin wrote:
> >qat_dev_cmd_param parameter of qat_sym_dev_create() was
> >wrongly marked as unused, this patch fixes it.
> >
> >Fixes: fb3b9f492205 ("crypto/qat: rework burst data path")
> >Cc: stable@dpdk.org
> >
> >Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> >---
> >  drivers/crypto/qat/qat_sym.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c
> >index 08e92191a3..2450f042c8 100644
> >--- a/drivers/crypto/qat/qat_sym.c
> >+++ b/drivers/crypto/qat/qat_sym.c
> >@@ -179,7 +179,7 @@ qat_sym_dequeue_burst(void *qp, struct rte_crypto_op **ops,
> >  int
> >  qat_sym_dev_create(struct qat_pci_device *qat_pci_dev,
> >-		struct qat_dev_cmd_param *qat_dev_cmd_param __rte_unused)
> >+		struct qat_dev_cmd_param *qat_dev_cmd_param)
> >  {
> >  	int i = 0, ret = 0;
> >  	uint16_t slice_map = 0;
> 
> Acked-by: Fan Zhang <fanzhang.oss@gmail.com>

Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
diff mbox series

Patch

diff --git a/drivers/crypto/qat/qat_sym.c b/drivers/crypto/qat/qat_sym.c
index 08e92191a3..2450f042c8 100644
--- a/drivers/crypto/qat/qat_sym.c
+++ b/drivers/crypto/qat/qat_sym.c
@@ -179,7 +179,7 @@  qat_sym_dequeue_burst(void *qp, struct rte_crypto_op **ops,
 
 int
 qat_sym_dev_create(struct qat_pci_device *qat_pci_dev,
-		struct qat_dev_cmd_param *qat_dev_cmd_param __rte_unused)
+		struct qat_dev_cmd_param *qat_dev_cmd_param)
 {
 	int i = 0, ret = 0;
 	uint16_t slice_map = 0;