From patchwork Mon Jun 12 16:21:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 128510 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 07E4642C50; Mon, 12 Jun 2023 18:21:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DAAEC41138; Mon, 12 Jun 2023 18:21:13 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 34A4740698 for ; Mon, 12 Jun 2023 18:21:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1686586872; x=1718122872; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=GHpc5EDfdbwYljNEe1JpWyD7xZ2Y/LRx4ZlLrlH2fWU=; b=XN4qZqm2M+XLS9yDH61gMY3Iex8idJeHoF2HRinNGGnkFPRJKjKVwD9V lV9w4zenPz3Lhblr2vBjmI7gumSWci7gXKRrYEl7I/cCp9AMA4H51mqaW Wme7MbHUrKipz8fv9OfylP2W9opuFxxXFrnq1kxUCwSo8aH6+VdfARHIU C5p3QqpoG8vflHpqLy4MS1RciwHzxgwbadih0QsguP2saY4MOmrHfKdOm gabRHQ8mty/mRfBr4ylxgu4BwGu1YtuXQpACDir8FW2Y9lpAx875jLurO EUWZztjEhumqHqFy4O4f+BksBVXvl85xP+k47sWMRr7OoXIxcOptAQ7Dj Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="337726736" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="337726736" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 Jun 2023 09:21:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10739"; a="801076179" X-IronPort-AV: E=Sophos;i="6.00,236,1681196400"; d="scan'208";a="801076179" Received: from silpixa00401385.ir.intel.com ([10.237.214.11]) by FMSMGA003.fm.intel.com with ESMTP; 12 Jun 2023 09:21:10 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson Subject: [PATCH 1/2] build: change flag variable type to boolean Date: Mon, 12 Jun 2023 17:21:03 +0100 Message-Id: <20230612162104.170749-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The has_libnuma flag was using 0 and 1 integer values, instead of the more appropriate boolean type. Change to use true/false instead. Signed-off-by: Bruce Richardson --- config/arm/meson.build | 2 +- config/meson.build | 4 ++-- lib/eal/linux/meson.build | 2 +- lib/vhost/meson.build | 2 +- 4 files changed, 5 insertions(+), 5 deletions(-) diff --git a/config/arm/meson.build b/config/arm/meson.build index 43f6a551a2..faba5e38cf 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -592,7 +592,7 @@ if update_flags part_number = soc_config['part_number'] soc_flags = soc_config.get('flags', []) if not soc_config.get('numa', true) - has_libnuma = 0 + has_libnuma = false endif disable_drivers += ',' + soc_config.get('disable_drivers', '') diff --git a/config/meson.build b/config/meson.build index 65087ce090..8aebccbbdc 100644 --- a/config/meson.build +++ b/config/meson.build @@ -174,7 +174,7 @@ if link_lib != '' endif # check for libraries used in multiple places in DPDK -has_libnuma = 0 +has_libnuma = false find_libnuma = true if meson.is_cross_build() and not meson.get_cross_property('numa', true) # don't look for libnuma if explicitly disabled in cross build @@ -184,7 +184,7 @@ if find_libnuma numa_dep = cc.find_library('numa', required: false) if numa_dep.found() and cc.has_header('numaif.h') dpdk_conf.set10('RTE_HAS_LIBNUMA', true) - has_libnuma = 1 + has_libnuma = true add_project_link_arguments('-lnuma', language: 'c') dpdk_extra_ldflags += '-lnuma' endif diff --git a/lib/eal/linux/meson.build b/lib/eal/linux/meson.build index 1b913acc06..e99ebed256 100644 --- a/lib/eal/linux/meson.build +++ b/lib/eal/linux/meson.build @@ -20,6 +20,6 @@ sources += files( ) deps += ['kvargs', 'telemetry'] -if has_libnuma == 1 +if has_libnuma dpdk_conf.set10('RTE_EAL_NUMA_AWARE_HUGEPAGES', true) endif diff --git a/lib/vhost/meson.build b/lib/vhost/meson.build index 0d1abf6283..9e39d221a1 100644 --- a/lib/vhost/meson.build +++ b/lib/vhost/meson.build @@ -5,7 +5,7 @@ if not is_linux build = false reason = 'only supported on Linux' endif -if has_libnuma == 1 +if has_libnuma dpdk_conf.set10('RTE_LIBRTE_VHOST_NUMA', true) endif if (toolchain == 'gcc' and cc.version().version_compare('>=8.3.0'))