[v4,1/4] kni: move IOVA build check
Checks
Commit Message
kni dependency to IOVA configuration does not need to be expressed in
the top level lib/meson.build file.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/kni/meson.build | 5 +++++
lib/meson.build | 3 ---
2 files changed, 5 insertions(+), 3 deletions(-)
Comments
On Wed, Jun 21, 2023 at 07:00:55PM +0200, David Marchand wrote:
> kni dependency to IOVA configuration does not need to be expressed in
> the top level lib/meson.build file.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> lib/kni/meson.build | 5 +++++
> lib/meson.build | 3 ---
> 2 files changed, 5 insertions(+), 3 deletions(-)
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
even if the rest of the set gets pushed to next release, I think this patch
should go in this one anyway. It's a simple cleanup.
Thanks.
@@ -7,6 +7,11 @@ if is_windows
subdir_done()
endif
+if dpdk_conf.get('RTE_IOVA_IN_MBUF') == 0
+ build = false
+ reason = 'requires IOVA in mbuf (set enable_iova_as_pa option)'
+endif
+
if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
build = false
reason = 'only supported on 64-bit Linux'
@@ -95,9 +95,6 @@ dpdk_libs_deprecated += [
disabled_libs = []
opt_disabled_libs = run_command(list_dir_globs, get_option('disable_libs'),
check: true).stdout().split()
-if dpdk_conf.get('RTE_IOVA_IN_MBUF') == 0
- opt_disabled_libs += ['kni']
-endif
foreach l:opt_disabled_libs
if not optional_libs.contains(l)
warning('Cannot disable mandatory library "@0@"'.format(l))