[v3] common/sfc_efx/base: set return code in case of the error
Checks
Commit Message
If the prefix for the rss hash was not chosen the
ENOTSUP error should be returned. Before this patch
the zero code was returned in case of an error.
Fixes: f784cdc5cbb1 ("common/sfc_efx/base: provide control to deliver RSS hash")
Signed-off-by: Artemii Morozov <artemii.morozov@arknetworks.am>
Reviewed-by: Andy Moreton <amoreton@xilinx.com>
---
v3: update commit log as fix commit
v2: don't use capital letters in email
drivers/common/sfc_efx/base/efx_rx.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
Comments
On 6/22/23 12:13, Artemii Morozov wrote:
> If the prefix for the rss hash was not chosen the
rss -> RSS
> ENOTSUP error should be returned. Before this patch
> the zero code was returned in case of an error.
>
> Fixes: f784cdc5cbb1 ("common/sfc_efx/base: provide control to deliver RSS hash")
I guess Cc: stable@dpdk.org is missing
>
> Signed-off-by: Artemii Morozov <artemii.morozov@arknetworks.am>
> Reviewed-by: Andy Moreton <amoreton@xilinx.com>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
@@ -937,8 +937,10 @@ efx_rx_qcreate_internal(
rss_hash_field =
&erplp->erpl_fields[EFX_RX_PREFIX_FIELD_RSS_HASH];
- if (rss_hash_field->erpfi_width_bits == 0)
+ if (rss_hash_field->erpfi_width_bits == 0) {
+ rc = ENOTSUP;
goto fail5;
+ }
}
enp->en_rx_qcount++;