From patchwork Fri Jun 30 05:48:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bing Zhao X-Patchwork-Id: 129131 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50A2142D67; Fri, 30 Jun 2023 07:49:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3EE01410FC; Fri, 30 Jun 2023 07:49:21 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2065.outbound.protection.outlook.com [40.107.94.65]) by mails.dpdk.org (Postfix) with ESMTP id E8D1A4021F for ; Fri, 30 Jun 2023 07:49:08 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OLme++n2fmeLDO6hEnTC5aVPI6VhJWGivxkiUr2rW0nrn8amoF08HD+HJJgxWyW3dfyzOVlN7eKsD3vXTc8xwYohnYq4RH7w3CNgX7/eegbZX7Z3k6OULy0CiqiOGcnOEiWVVD7MLXNC8gxDgcojXzBR3/n6Ve3Ou3sCIAo0frSye9M97E51PFmxkhAbAIda1/abUbsnCYwVQrPg3JDfO8ob+x2Ony+TlzIq3jOmn+da9+acm6pnKrbvscqygBlQfWu9/9mXhzCr7ZPKlWhzzLRZ1EnxlO224IxE9EiOqQjyO/6AOtMpZhsM0/9lASkQbY5hd7pG5PxalEWQsI77VQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XriTst/3+BuXdkhSQI1b52x3okyuHYhoJhww5oWj0AE=; b=UZmcKfljxrchIZ5F9oqh2xtQo4c/ne7Zeen3GDi69YCilKLAhKkcHqcHOiFjdYYpKyz6IaY4h0TENZOJw3ncx2AGKPu+hyob8QfnYH+yBPAV0kM3/7LLTEhIdlpDysUe9zQsdy3QpRYZTo0OdVOlMsRkMLoTCpMB6c86RqTtCZ41zVbqnHHhVkpJ+gGeI8YIiwFy2GHxMjUXnVncXxUoycCUQFanqI5vXmUniC0dpN+Tza6Ce8Datf27l+mLoncW9FqjldjlfJC07bxpCHK1+3zAnMKSEiarp8TqIf3/oczU8bxuVeqvuI49v3HEpXMSeB6+9PHIz5C+VECIh/jD8Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XriTst/3+BuXdkhSQI1b52x3okyuHYhoJhww5oWj0AE=; b=crkPCIEALTA4o5sj4ltw4BAuRaPUCZnMsX2J8PvEqRm/nXFUog87zEcDdvL6ZuHdyGh31os4JN+PLZJhgvIkM7jkTz32UVkeJaPTNIX3ZV0u7FEEBN1Exs/FanhiCQVIuENc4Tx1fHiguuK8k8CgYcp9UlCGuGDIAEnSOaHB9jdqRyA4bVniZGn72Q+B5XomvdON8/Y+Sl2Lf/UyHHMfntAVku/TxAQfD2s/HUebO0HC1RCh9NRqmzUcPbKDpBl1LLFqeLDFY7MFV27U1mJsPDnBV2Oh+vBx7XXjOGdIDLzCyc+rJFwGJi9FlkaoZcTK4es4R5/oov30AfWFOKo1PA== Received: from BN0PR03CA0059.namprd03.prod.outlook.com (2603:10b6:408:e7::34) by CH2PR12MB4215.namprd12.prod.outlook.com (2603:10b6:610:ab::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.19; Fri, 30 Jun 2023 05:49:05 +0000 Received: from BN8NAM11FT016.eop-nam11.prod.protection.outlook.com (2603:10b6:408:e7:cafe::a7) by BN0PR03CA0059.outlook.office365.com (2603:10b6:408:e7::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.22 via Frontend Transport; Fri, 30 Jun 2023 05:49:05 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT016.mail.protection.outlook.com (10.13.176.97) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.49 via Frontend Transport; Fri, 30 Jun 2023 05:49:04 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 29 Jun 2023 22:48:57 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Thu, 29 Jun 2023 22:48:55 -0700 From: Bing Zhao To: , , , , CC: , Subject: [PATCH 2/7] net/mlx5: fix the error set in quota init Date: Fri, 30 Jun 2023 08:48:41 +0300 Message-ID: <20230630054841.432300-1-bingz@nvidia.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT016:EE_|CH2PR12MB4215:EE_ X-MS-Office365-Filtering-Correlation-Id: cb6590de-0565-4a66-7fcc-08db792db6a5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GU0o4BwIlYaXQmpNL/FzUeb/Aiwf2yTzVpDqzFvysSIBfgp7UYsBG2nnWNovKg6X+fOWdrV31MFGX4Z2gB7JPU5esIq94DY+U39d/kjMva0Udcwb1wwlcxSKwy/VtO0JuKAe9nqzD9YXdY/KHzX58lEQFs1hSdX9zn2dGoC5pToHgwGoH+v7k7Ke0n9eufeLgub2HiQ4ksaroQFCyVBpnPghd1EM8HTKiR04EEtgj0qnSMztt5purgiDeVPXA/l7k+u2Bt5msg/nI033S108HqkF2K2BoexWIZBUUso6NI6GtqXB5S8EnmTT6wK4eXHz4RcKll0ObTQg6no8nSnbCE00xDEvJ/uBjHgIdHIw3vUAWRbobqZFRXLhCEH8nNMSke2n/fVmLabmscBkvcnfiafLIvk0ntDUQ9RpJpXHGfimYaQOEteRtUqEiuOjXbSwvAbObhqBB+lULNliFy+s4zuRI+EC7zP4dKs2t4P6aSukpY182+1ZNyUF9HfSkK1vXgknr8uXkdqimrKGXozyL18o8NcPzgXVgOrIfmvIPKjFjgwhA7LLKBzqHiFXIhK3LOBcj3/J8AGah2IBVlmhietBvo1YgCnrce40701Cs1UaN/6w9+ngQ1OP06Hk2+8m0jnXjzeVvnUdC6Q84gXuye5DhCRb7I752c3CCAj4qvsr795iX8QBckM6lZO8v5TTSl1K1WPvG2zjw4f6aii0On+/SsQ2IvHqRayOkAjeHegOTDvcuiFb2Flvt55GZaNc X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(376002)(396003)(136003)(39860400002)(346002)(451199021)(46966006)(36840700001)(40470700004)(86362001)(107886003)(54906003)(8936002)(8676002)(5660300002)(82310400005)(110136005)(26005)(1076003)(7696005)(478600001)(6636002)(4326008)(70206006)(70586007)(41300700001)(316002)(6666004)(6286002)(16526019)(186003)(2616005)(2906002)(47076005)(40460700003)(83380400001)(55016003)(336012)(426003)(15650500001)(36860700001)(40480700001)(36756003)(82740400003)(356005)(7636003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 05:49:04.5970 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cb6590de-0565-4a66-7fcc-08db792db6a5 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT016.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4215 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When there was a failure in the quota initialization, only the return value was set. The "rte_errno" and the "rte_flow_error" were not set. The application may get a crash when trying to access the "message" field. Fixes: 15896eaf9d71 ("net/mlx5: support indirect quota create/query/modify") Cc: getelson@nvidia.com Signed-off-by: Bing Zhao Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_hw.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index b5137a822a..ba2f1f7c92 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -7789,8 +7789,11 @@ flow_hw_configure(struct rte_eth_dev *dev, /* Initialize quotas */ if (port_attr->nb_quotas) { ret = mlx5_flow_quota_init(dev, port_attr->nb_quotas); - if (ret) + if (ret) { + rte_flow_error_set(error, -ret, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, + "Failed to initialize quota."); goto err; + } } /* Initialize meter library*/ if (port_attr->nb_meters || (host_priv && host_priv->hws_mpool))