From patchwork Fri Jun 30 09:21:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bing Zhao X-Patchwork-Id: 129151 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D1A3D42D94; Fri, 30 Jun 2023 11:22:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BF45D406B5; Fri, 30 Jun 2023 11:22:06 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2076.outbound.protection.outlook.com [40.107.93.76]) by mails.dpdk.org (Postfix) with ESMTP id 3342C406B5; Fri, 30 Jun 2023 11:22:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PH28uQLqtZ47Ut61yStkSdDYI9HXHPPNMl+r4rCDWtb2uEYPic1UNYy0duPcK3Bcfa0TJtQmIS9LSExMdOeR7IhHwkbEPySuamgM9KFl38naXVYzofbNh+Jn2oNdi8Yda+0+DzRax6kEoJgkXfaqOp69TWoFGsJJom3SOAkKxjSZGs70if+OcX4sT8NIDoZjmsJqaksCb1DWg2d7rRv+xUvwZdB7FGHbDyHXZjyDtQ+CaBnG009PAL0GoHQJn4xSX4Droc9uakOJ1bS19S7ycpePwHSqyK2PpSIIKxEYqQgIdlhPaNYt4N/zfBCBlIAn90f7Ii8xJJWWcC44x1eZ8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=foZZz+v5O2eCH1DnBrS4xMSZ7WzuV+2aQI6XyaGfi18=; b=lx3IHpyocWmB1Lc1WNGrQqxGpqBBafFAVEq7uboLxWTy8rPPlo0SrsMGCY+P/ybZs63SEIURDJWON3Q0pZh9eCyJJb4zYAqepqTKwLozURmeT0YlGVYdIHynQxUlDp5V26Rby6yKjvk7T4GQlCZ4bODhRxjvNTynoSzuwnsfdc5GQ9rPjnILm/90h6G4vSMBnURIiLTD3LI0a4TjG3gEDt6LblAfRXoNnnge9YJLan4viT/Cm1uS1APIiBoiF1KL4TTj8/Amb3jcfL8sLpmGHIDrIxYMTr8eSVXOZCY5eUgn7JdoPtWuhv1RWh7tOF+tmxDwm1cjBo9wC8116APuAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=foZZz+v5O2eCH1DnBrS4xMSZ7WzuV+2aQI6XyaGfi18=; b=IHZcEfI8lVH/XDMB0R/NHy0dHezMSX9Lqd6LtCz0HKxi1yU2GeFT1YF8/99A2my2WBetr0oHfh20UTCz66vwnXUOqB30269Ulhd6AM9DBxjcL8qTvopwqM+uMc8Nc3qdiSNC8HRXJ9H68dp8Vo3wfxaJR9oCI1CAxzZQ4pzYcvbqj/uCjhDkGux5+kC+Sp8OUkOxNv5iGKZ/SffaKkKRcQyRmMZyqPx4BnpUTTqcnocp8xEUzmVWQGg9ua//0Q2K1M1tGUwbqz3SVRkiMlNebmgi+tsqx+OCbK2HZl0YyKNAUqtfRPUmubYcRjO1FtHK4DXuL2x7dXHSLkdz5WxJXw== Received: from MW4PR04CA0221.namprd04.prod.outlook.com (2603:10b6:303:87::16) by PH0PR12MB7077.namprd12.prod.outlook.com (2603:10b6:510:21d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.19; Fri, 30 Jun 2023 09:22:01 +0000 Received: from CO1NAM11FT099.eop-nam11.prod.protection.outlook.com (2603:10b6:303:87:cafe::32) by MW4PR04CA0221.outlook.office365.com (2603:10b6:303:87::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.22 via Frontend Transport; Fri, 30 Jun 2023 09:22:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT099.mail.protection.outlook.com (10.13.175.171) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.42 via Frontend Transport; Fri, 30 Jun 2023 09:22:00 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Fri, 30 Jun 2023 02:21:50 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Fri, 30 Jun 2023 02:21:47 -0700 From: Bing Zhao To: , , , , CC: , , Subject: [PATCH v2] net/mlx5: fix the return value of vport action Date: Fri, 30 Jun 2023 12:21:34 +0300 Message-ID: <20230630092134.433965-1-bingz@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230630063329.432508-1-bingz@nvidia.com> References: <20230630063329.432508-1-bingz@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT099:EE_|PH0PR12MB7077:EE_ X-MS-Office365-Filtering-Correlation-Id: 9e83d8cf-40f5-4663-cefa-08db794b75e5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5BVjQKyMYb1dfYsRfYWbX7AT1l7b7KaCjAv16FuEHIcNqtSiU0P1SAJr6ihwRxyRqlm443KAg45V1ofEiHZb8bHErZtEcfrpL7g630dN57bv7HUDN673G9TpY/rNS2KMWlGkfC6gWCgqO5zAYjAgap7f1DeB7pLXMJejL9onWPYn+pB52mjm8jTEmJDybChZYtLmG663CWEQKmUI9qYxRSCt9HPTRYvxgFz6u2LYbzZrVpALl4aoNYxhcFeI5m/a8qz+LXxTnQ6rlJk5MfRIQygdpEPef2xp5J8n5Zt1CZxr6sJ4y3uPvH8cKBa8dyBUelOHMKKNPryGDKtdERHQDocjc82ZMw8pAzRJPkaCrcg2nBUTSdSJtx+0GrA8JXrBbGJzPwxRac9gscVssSTURWA8Kp7K/D6WrLrgfNE8rH9LasUp51Q2mNDhxbEpHZG53Q4tu2PwqFYpjIcqNU/KHLhaO271g4oN+NvadEdt88hueWT1kPZsde9yJvVQ6GMSkcbQ7DeEcAeVipyaTbHkWwMMm6mya5yRuqnwiK83ePYLxD28N33mRxpLlT1RFsb/TXRw8jg6bWHBJ+XEhRp+jTOgPTKtylPPqm10tsoLedCIFRu7xkobRTXsrTLuaZN32HWWsP72uxqee60dR0ewx7Db4CPEPy4TRgIfFORuzqOiHb8Sz2AibT+JBMwTmAKp7XHEzA01E1KUn7NFfnlzxX47Sa8bNlutyQQnxCtrETSfWgTsYF/BYW8+nMv7yOR/ X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(346002)(39860400002)(136003)(376002)(396003)(451199021)(36840700001)(40470700004)(46966006)(55016003)(336012)(426003)(47076005)(40460700003)(83380400001)(2616005)(2906002)(4744005)(7636003)(356005)(82740400003)(36860700001)(40480700001)(36756003)(8936002)(8676002)(82310400005)(110136005)(5660300002)(86362001)(450100002)(54906003)(41300700001)(70586007)(6636002)(4326008)(70206006)(6666004)(316002)(7696005)(478600001)(16526019)(6286002)(186003)(1076003)(26005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Jun 2023 09:22:00.9466 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9e83d8cf-40f5-4663-cefa-08db794b75e5 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT099.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR12MB7077 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The "rte_flow_error" should be set in case a invalid pointer access to the message member. Fixes: 1939eb6f660c ("net/mlx5: support flow port action with HWS") Cc: dsosnowski@nvidia.com Cc: stable@dpdk.org Signed-off-by: Bing Zhao Acked-by: Ori Kam --- v2: add CC stable --- drivers/net/mlx5/mlx5_flow_hw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 6683bcbc7f..87584c1e94 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -7830,7 +7830,8 @@ flow_hw_configure(struct rte_eth_dev *dev, if (is_proxy) { ret = flow_hw_create_vport_actions(priv); if (ret) { - rte_errno = -ret; + rte_flow_error_set(error, -ret, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, + NULL, "Failed to create vport actions."); goto err; } ret = flow_hw_create_ctrl_tables(dev);