From patchwork Tue Jul 4 10:46:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 129244 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8D1A42DD1; Tue, 4 Jul 2023 12:48:05 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 86D3840E03; Tue, 4 Jul 2023 12:48:05 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2043.outbound.protection.outlook.com [40.107.100.43]) by mails.dpdk.org (Postfix) with ESMTP id C4AD640042 for ; Tue, 4 Jul 2023 12:48:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y0BaYITmjQmxethjaoMGODmOhXXtVhJBWfmmg35gAPc5TqMzbnKx42KX90MPoZxcRFtnUuI4YcdV2JsXJYYwdNqloj7PMrzFkmEr/cZCSaXyA4QEtYkJkXY6ETjHCq64Bk0clw0L8skxhCT0yF8ATz1wtha4bXJ6Xcz7dF1K7MdqkUH6Q6GsuWL0XMySoZ7fCfYNP0KatgSa/14bFklf9vOXi9AdElz781XQPD7OxAVzrE/+2vbLb0VLzkXvfO1VL3me5YBW6Yh45bjrF/88V9Sv1EXPkUpBCGnJjxjMW4QqCsfwgZGCjWYcSz+O79UnIyjw7EhJx9z5a6bwyw2+5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cx7G65NElZqvqbnFj16+Afv+XDVDlwCNj7vVJhgFJI8=; b=DFdLnkUN27m6zhC8HjGedj4+f/B9CUUwYw4cNcFsWe+yEIzhuiDipGbDbpyu/IzlHtSrsOh0cHq1p67zfA6xMg8V7tKF3ZHWtozJuCZz91HZoTemagjLLEUqnvmEgU952HsgVwAcTuphW2MGWCp7sl671KyjirXzH/DlfGRMtllp3Afv2z7zEm3WDuSbje9gcYCLdSQSJPcLedimMSGP5MWqSVOxBa25Kzd3gyzJAJIq5xc2h/VvVtKQoKFifs5rxWJMUshrHke50p0+PNZezWajNImIDqm1i9zBVzTtGlCkP+pVmLyvOIKI5M8h0spvTAGCNGCTVUP46SOyOK23Mg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cx7G65NElZqvqbnFj16+Afv+XDVDlwCNj7vVJhgFJI8=; b=k3mRgaa0/P42fgNoS1xQw+tU2AMpkaom2T0yKH6IZedNuTB7Xe63khVJSZJ1UVfGTVQGHKwF25aIJcEG/PziJPiUDySnS4DblDD84eqrUh9LRxutPlb11Dtm5ajcna/lw9vfr9Ohj1ZvPluGW/0tYYRs60JR2+QEXQJBb10O5/2VeqCyAh1lJ5O2M6PBIY+VuwwfHgNNhtUxVOz8cM0Pk+HnRebC0+xT7XVp5mLL4LrBBCbVTHYATlc14HRmn+M6UN147z+KR65JlzermIFesJz3BNGo0zPX1FvuKIb7TD+kDZ1yDE5m9Hm7tGJAm6ZRnX2uAjkf5tHcM1gBdZKxEA== Received: from DS7PR06CA0031.namprd06.prod.outlook.com (2603:10b6:8:54::11) by SJ2PR12MB8181.namprd12.prod.outlook.com (2603:10b6:a03:4f6::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul 2023 10:47:59 +0000 Received: from DM6NAM11FT049.eop-nam11.prod.protection.outlook.com (2603:10b6:8:54:cafe::a4) by DS7PR06CA0031.outlook.office365.com (2603:10b6:8:54::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.31 via Frontend Transport; Tue, 4 Jul 2023 10:47:59 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by DM6NAM11FT049.mail.protection.outlook.com (10.13.172.188) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.43 via Frontend Transport; Tue, 4 Jul 2023 10:47:58 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Tue, 4 Jul 2023 03:47:48 -0700 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Tue, 4 Jul 2023 03:47:47 -0700 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37 via Frontend Transport; Tue, 4 Jul 2023 03:47:45 -0700 From: Itamar Gozlan To: , , , , , Ori Kam CC: Subject: [v1 1/5] net/mlx5/hws: remove uneeded new line for DR_LOG Date: Tue, 4 Jul 2023 13:46:41 +0300 Message-ID: <20230704104645.19800-1-igozlan@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20230702045758.23244-4-igozlan@nvidia.com> References: <20230702045758.23244-4-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT049:EE_|SJ2PR12MB8181:EE_ X-MS-Office365-Filtering-Correlation-Id: d80ddd4a-56c6-4d16-c1a2-08db7c7c21e3 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 11Ru2hj5QKveNjQ1kFPoBDzpcVc1pIhx2L4JFnV54tnqu4DJ+c4NqL1UsTa+SgA7RQIdlECqRuo8pNrPQ5hlKwSsQB3SeNqVT/xGOvPZ8X6URgqYxEnH8T9jfj0bw6leAu1P3FPgymE2RJrAFNwGk5pMYDYTfJb5stlnJ0psdLyWQauG+njRKWvYQi0JhMC9THKKf1xM29VnGqPxDaUxQY433sqnxQqAtaoCsUmO/IYyG9EXWfaTAFbTGaLkcDqK1WHls/xfAQ/W+KkCdtNYG9knV6fMlCh3m6xUa5T5Dn5kx0WMrqPLxVXzkDKY7VfazC3PeSTcPRvkk0cTs68+sYZtShrOqZFOeJoBVVPFhiBTKUK4G9BFhtOBCzKNvBDrp/nSL0jqxuLRbsiEl2ZMV/Qb667AebUwa9reqYDCqHTgJhIfI6dRlm8Ueym3DLYKC9LsCevXOb/hjS5sjF+2lLCLWwEIrFzkyAZK3/gfz4jKnx1tiECLsXG/Lgudx67bVInXLck0rRo98HNfE8CNVg4bf3MjV6kkqeeEw71Ql1f4chxUiiZETm9cLyQ4JzhEAekKzzdiHE+h2iLvLmePUqAuTeyK288pQuvEZLT3oFux7NGwmKK6lJOJhvWEOrk+NzOsiLxwI1VGRMykLYiMa9mszYtwwaIOOefwt99nYleu668u2msZ1YSXXW8x8vsJx2UZRHbvWpAkhz9HfnNpEVw/fWZfgQD1hR4p6byEUbn85OdmaF1ui7sq8/RxjrLO X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(346002)(39860400002)(376002)(396003)(136003)(451199021)(40470700004)(46966006)(36840700001)(336012)(40460700003)(41300700001)(7696005)(6666004)(82310400005)(26005)(7636003)(356005)(82740400003)(83380400001)(2616005)(426003)(186003)(1076003)(6286002)(47076005)(40480700001)(36860700001)(55016003)(86362001)(110136005)(478600001)(36756003)(2906002)(316002)(4326008)(70206006)(70586007)(8936002)(8676002)(6636002)(5660300002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Jul 2023 10:47:58.8014 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d80ddd4a-56c6-4d16-c1a2-08db7c7c21e3 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT049.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB8181 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Alex Vesker In some places an extra new line was added, remove to have clean prints. Signed-off-by: Alex Vesker Acked-by: Matan Azrad --- v2->v3 1. Right patches instead of wrong patches in the previous series v1->v2 1. Last patch in the series (net/mlx5/hws: support default miss action on FDB) needed some fixes to be properly rebased. drivers/net/mlx5/hws/mlx5dr_action.c | 30 +++++++++++++-------------- drivers/net/mlx5/hws/mlx5dr_cmd.c | 2 +- drivers/net/mlx5/hws/mlx5dr_definer.c | 4 ++-- drivers/net/mlx5/hws/mlx5dr_pat_arg.c | 4 ++-- 4 files changed, 20 insertions(+), 20 deletions(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_action.c b/drivers/net/mlx5/hws/mlx5dr_action.c index 01d30b8442..e2db85940c 100644 --- a/drivers/net/mlx5/hws/mlx5dr_action.c +++ b/drivers/net/mlx5/hws/mlx5dr_action.c @@ -112,7 +112,7 @@ static int mlx5dr_action_get_shared_stc_nic(struct mlx5dr_context *ctx, stc_attr.remove_words.num_of_words = MLX5DR_ACTION_HDR_LEN_L2_VLAN; break; default: - DR_LOG(ERR, "No such type : stc_type\n"); + DR_LOG(ERR, "No such type : stc_type"); assert(false); rte_errno = EINVAL; goto unlock_and_out; @@ -469,7 +469,7 @@ static uint32_t mlx5dr_action_get_mh_stc_type(__be64 pattern) return MLX5_IFC_STC_ACTION_TYPE_COPY; default: assert(false); - DR_LOG(ERR, "Unsupported action type: 0x%x\n", action_type); + DR_LOG(ERR, "Unsupported action type: 0x%x", action_type); rte_errno = ENOTSUP; return MLX5_IFC_STC_ACTION_TYPE_NOP; } @@ -1017,7 +1017,7 @@ static int mlx5dr_action_create_dest_vport_hws(struct mlx5dr_context *ctx, ret = mlx5dr_cmd_query_ib_port(ctx->ibv_ctx, &vport_caps, ib_port_num); if (ret) { - DR_LOG(ERR, "Failed querying port %d\n", ib_port_num); + DR_LOG(ERR, "Failed querying port %d", ib_port_num); return ret; } action->vport.vport_num = vport_caps.vport_num; @@ -1025,7 +1025,7 @@ static int mlx5dr_action_create_dest_vport_hws(struct mlx5dr_context *ctx, ret = mlx5dr_action_create_stcs(action, NULL); if (ret) { - DR_LOG(ERR, "Failed creating stc for port %d\n", ib_port_num); + DR_LOG(ERR, "Failed creating stc for port %d", ib_port_num); return ret; } @@ -1041,7 +1041,7 @@ mlx5dr_action_create_dest_vport(struct mlx5dr_context *ctx, int ret; if (!(flags & MLX5DR_ACTION_FLAG_HWS_FDB)) { - DR_LOG(ERR, "Vport action is supported for FDB only\n"); + DR_LOG(ERR, "Vport action is supported for FDB only"); rte_errno = EINVAL; return NULL; } @@ -1052,7 +1052,7 @@ mlx5dr_action_create_dest_vport(struct mlx5dr_context *ctx, ret = mlx5dr_action_create_dest_vport_hws(ctx, action, ib_port_num); if (ret) { - DR_LOG(ERR, "Failed to create vport action HWS\n"); + DR_LOG(ERR, "Failed to create vport action HWS"); goto free_action; } @@ -1081,7 +1081,7 @@ mlx5dr_action_create_push_vlan(struct mlx5dr_context *ctx, uint32_t flags) ret = mlx5dr_action_create_stcs(action, NULL); if (ret) { - DR_LOG(ERR, "Failed creating stc for push vlan\n"); + DR_LOG(ERR, "Failed creating stc for push vlan"); goto free_action; } @@ -1115,7 +1115,7 @@ mlx5dr_action_create_pop_vlan(struct mlx5dr_context *ctx, uint32_t flags) ret = mlx5dr_action_create_stcs(action, NULL); if (ret) { - DR_LOG(ERR, "Failed creating stc for pop vlan\n"); + DR_LOG(ERR, "Failed creating stc for pop vlan"); goto free_shared; } @@ -1418,7 +1418,7 @@ mlx5dr_action_handle_tunnel_l3_to_l2(struct mlx5dr_context *ctx, if (data_sz != MLX5DR_ACTION_HDR_LEN_L2 && data_sz != MLX5DR_ACTION_HDR_LEN_L2_W_VLAN) { - DR_LOG(ERR, "Data size is not supported for decap-l3\n"); + DR_LOG(ERR, "Data size is not supported for decap-l3"); rte_errno = EINVAL; return rte_errno; } @@ -1430,7 +1430,7 @@ mlx5dr_action_handle_tunnel_l3_to_l2(struct mlx5dr_context *ctx, ret = mlx5dr_pat_arg_create_modify_header(ctx, action, mh_data_size, (__be64 *)mh_data, bulk_size); if (ret) { - DR_LOG(ERR, "Failed allocating modify-header for decap-l3\n"); + DR_LOG(ERR, "Failed allocating modify-header for decap-l3"); return ret; } @@ -1528,7 +1528,7 @@ mlx5dr_action_create_reformat(struct mlx5dr_context *ctx, if (!mlx5dr_action_is_hws_flags(flags) || ((flags & MLX5DR_ACTION_FLAG_SHARED) && log_bulk_size)) { - DR_LOG(ERR, "Reformat flags don't fit HWS (flags: %x0x)\n", + DR_LOG(ERR, "Reformat flags don't fit HWS (flags: %x0x)", flags); rte_errno = EINVAL; goto free_action; @@ -1536,7 +1536,7 @@ mlx5dr_action_create_reformat(struct mlx5dr_context *ctx, ret = mlx5dr_action_create_reformat_hws(ctx, data_sz, inline_data, log_bulk_size, action); if (ret) { - DR_LOG(ERR, "Failed to create reformat.\n"); + DR_LOG(ERR, "Failed to create reformat."); rte_errno = EINVAL; goto free_action; } @@ -1605,14 +1605,14 @@ mlx5dr_action_create_modify_header(struct mlx5dr_context *ctx, if (!mlx5dr_action_is_hws_flags(flags) || ((flags & MLX5DR_ACTION_FLAG_SHARED) && log_bulk_size)) { - DR_LOG(ERR, "Flags don't fit hws (flags: %x0x, log_bulk_size: %d)\n", + DR_LOG(ERR, "Flags don't fit hws (flags: %x0x, log_bulk_size: %d)", flags, log_bulk_size); rte_errno = EINVAL; goto free_action; } if (!mlx5dr_pat_arg_verify_actions(pattern, pattern_sz / MLX5DR_MODIFY_ACTION_SIZE)) { - DR_LOG(ERR, "One of the actions is not supported\n"); + DR_LOG(ERR, "One of the actions is not supported"); rte_errno = EINVAL; goto free_action; } @@ -1628,7 +1628,7 @@ mlx5dr_action_create_modify_header(struct mlx5dr_context *ctx, ret = mlx5dr_pat_arg_create_modify_header(ctx, action, pattern_sz, pattern, log_bulk_size); if (ret) { - DR_LOG(ERR, "Failed allocating modify-header\n"); + DR_LOG(ERR, "Failed allocating modify-header"); goto free_action; } } diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.c b/drivers/net/mlx5/hws/mlx5dr_cmd.c index f1ae256a7e..f9f220cc6a 100644 --- a/drivers/net/mlx5/hws/mlx5dr_cmd.c +++ b/drivers/net/mlx5/hws/mlx5dr_cmd.c @@ -1134,7 +1134,7 @@ int mlx5dr_cmd_query_caps(struct ibv_context *ctx, ret = mlx5_glue->devx_general_cmd(ctx, in, sizeof(in), out, sizeof(out)); if (ret) { - DR_LOG(ERR, "Query eswitch capabilities failed %d\n", ret); + DR_LOG(ERR, "Query eswitch capabilities failed %d", ret); rte_errno = errno; return rte_errno; } diff --git a/drivers/net/mlx5/hws/mlx5dr_definer.c b/drivers/net/mlx5/hws/mlx5dr_definer.c index 7b01f4c9ec..33d0f2d18e 100644 --- a/drivers/net/mlx5/hws/mlx5dr_definer.c +++ b/drivers/net/mlx5/hws/mlx5dr_definer.c @@ -535,7 +535,7 @@ mlx5dr_definer_get_mpls_fc(struct mlx5dr_definer_conv_data *cd, bool inner) break; default: rte_errno = ENOTSUP; - DR_LOG(ERR, "MPLS index %d is not supported\n", mpls_idx); + DR_LOG(ERR, "MPLS index %d is not supported", mpls_idx); return NULL; } @@ -571,7 +571,7 @@ mlx5dr_definer_get_mpls_oks_fc(struct mlx5dr_definer_conv_data *cd, bool inner) break; default: rte_errno = ENOTSUP; - DR_LOG(ERR, "MPLS index %d is not supported\n", mpls_idx); + DR_LOG(ERR, "MPLS index %d is not supported", mpls_idx); return NULL; } diff --git a/drivers/net/mlx5/hws/mlx5dr_pat_arg.c b/drivers/net/mlx5/hws/mlx5dr_pat_arg.c index 830bc08678..bedaedb677 100644 --- a/drivers/net/mlx5/hws/mlx5dr_pat_arg.c +++ b/drivers/net/mlx5/hws/mlx5dr_pat_arg.c @@ -449,7 +449,7 @@ bool mlx5dr_pat_arg_verify_actions(__be64 pattern[], uint16_t num_of_actions) u8 action_id = MLX5_GET(set_action_in, &pattern[i], action_type); if (action_id >= MLX5_MODIFICATION_TYPE_MAX) { - DR_LOG(ERR, "Invalid action %u\n", action_id); + DR_LOG(ERR, "Invalid action %u", action_id); return false; } } @@ -468,7 +468,7 @@ int mlx5dr_pat_arg_create_modify_header(struct mlx5dr_context *ctx, num_of_actions = pattern_sz / MLX5DR_MODIFY_ACTION_SIZE; if (num_of_actions == 0) { - DR_LOG(ERR, "Invalid number of actions %u\n", num_of_actions); + DR_LOG(ERR, "Invalid number of actions %u", num_of_actions); rte_errno = EINVAL; return rte_errno; }