[v2] mailmap: fix sorting

Message ID 20230706023248.362902-1-stephen@networkplumber.org (mailing list archive)
State Rejected, archived
Delegated to: Thomas Monjalon
Headers
Series [v2] mailmap: fix sorting |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS

Commit Message

Stephen Hemminger July 6, 2023, 2:32 a.m. UTC
  The mailmap file is supposed to be in sorted order,
but several entries are in the wrong place.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
v2 - use en_us.UTF-8 sort order

 .mailmap | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
  

Comments

Stephen Hemminger July 6, 2023, 2:42 a.m. UTC | #1
On Wed,  5 Jul 2023 19:32:48 -0700
Stephen Hemminger <stephen@networkplumber.org> wrote:

> The mailmap file is supposed to be in sorted order,
> but several entries are in the wrong place.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> v2 - use en_us.UTF-8 sort order
> 
>  .mailmap | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/.mailmap b/.mailmap
> index d200f363394d..bfd3528cf734 100644
> --- a/.mailmap
> +++ b/.mailmap
> @@ -115,8 +115,8 @@ Anoob Joseph <anoobj@marvell.com> <anoob.joseph@caviumnetworks.com>
>  Antara Ganesh Kolar <antara.ganesh.kolar@intel.com>
>  Anthony Fee <anthonyx.fee@intel.com>
>  Antonio Fischetti <antonio.fischetti@intel.com>
> -Anup Prabhu <aprabhu@marvell.com>
>  Anupam Kapoor <anupam.kapoor@gmail.com>
> +Anup Prabhu <aprabhu@marvell.com>
>  Apeksha Gupta <apeksha.gupta@nxp.com>
>  Archana Muniganti <marchana@marvell.com> <muniganti.archana@caviumnetworks.com>
>  Archit Pandey <architpandeynitk@gmail.com>

Never mind, something is off if Anup shows up after Anupam
  
Ferruh Yigit July 11, 2023, 9:12 a.m. UTC | #2
On 7/6/2023 3:42 AM, Stephen Hemminger wrote:
> On Wed,  5 Jul 2023 19:32:48 -0700
> Stephen Hemminger <stephen@networkplumber.org> wrote:
> 
>> The mailmap file is supposed to be in sorted order,
>> but several entries are in the wrong place.
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>> ---
>> v2 - use en_us.UTF-8 sort order
>>
>>  .mailmap | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/.mailmap b/.mailmap
>> index d200f363394d..bfd3528cf734 100644
>> --- a/.mailmap
>> +++ b/.mailmap
>> @@ -115,8 +115,8 @@ Anoob Joseph <anoobj@marvell.com> <anoob.joseph@caviumnetworks.com>
>>  Antara Ganesh Kolar <antara.ganesh.kolar@intel.com>
>>  Anthony Fee <anthonyx.fee@intel.com>
>>  Antonio Fischetti <antonio.fischetti@intel.com>
>> -Anup Prabhu <aprabhu@marvell.com>
>>  Anupam Kapoor <anupam.kapoor@gmail.com>
>> +Anup Prabhu <aprabhu@marvell.com>
>>  Apeksha Gupta <apeksha.gupta@nxp.com>
>>  Archana Muniganti <marchana@marvell.com> <muniganti.archana@caviumnetworks.com>
>>  Archit Pandey <architpandeynitk@gmail.com>
> 
> Never mind, something is off if Anup shows up after Anupam
>

This sorting logic already in the file:
 Yanjie Xu <yanjie.xu@intel.com>
 Yan Xia <yanx.xia@intel.com>

and I don't know how to take following (may sort be ignoring the
white-space between name and surname?):
 Yi Li <liyi1@chinatelecom.cn>
 Yi Liu <yi.liu@nxp.com>
 Yilong Lv <lvyilong.lyl@alibaba-inc.com>
 Yi Lu <luyi68@live.com>


But to be able to sort whole file with 'sort' and no need to manually
fix above quirks, I am OK with the change, hence:

Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
  
Bruce Richardson July 17, 2023, 2:38 p.m. UTC | #3
On Tue, Jul 11, 2023 at 10:12:02AM +0100, Ferruh Yigit wrote:
> On 7/6/2023 3:42 AM, Stephen Hemminger wrote:
> > On Wed,  5 Jul 2023 19:32:48 -0700
> > Stephen Hemminger <stephen@networkplumber.org> wrote:
> > 
> >> The mailmap file is supposed to be in sorted order,
> >> but several entries are in the wrong place.
> >>
> >> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> >> ---
> >> v2 - use en_us.UTF-8 sort order
> >>
> >>  .mailmap | 6 +++---
> >>  1 file changed, 3 insertions(+), 3 deletions(-)
> >>
> >> diff --git a/.mailmap b/.mailmap
> >> index d200f363394d..bfd3528cf734 100644
> >> --- a/.mailmap
> >> +++ b/.mailmap
> >> @@ -115,8 +115,8 @@ Anoob Joseph <anoobj@marvell.com> <anoob.joseph@caviumnetworks.com>
> >>  Antara Ganesh Kolar <antara.ganesh.kolar@intel.com>
> >>  Anthony Fee <anthonyx.fee@intel.com>
> >>  Antonio Fischetti <antonio.fischetti@intel.com>
> >> -Anup Prabhu <aprabhu@marvell.com>
> >>  Anupam Kapoor <anupam.kapoor@gmail.com>
> >> +Anup Prabhu <aprabhu@marvell.com>
> >>  Apeksha Gupta <apeksha.gupta@nxp.com>
> >>  Archana Muniganti <marchana@marvell.com> <muniganti.archana@caviumnetworks.com>
> >>  Archit Pandey <architpandeynitk@gmail.com>
> > 
> > Never mind, something is off if Anup shows up after Anupam
> >
> 
> This sorting logic already in the file:
>  Yanjie Xu <yanjie.xu@intel.com>
>  Yan Xia <yanx.xia@intel.com>
> 
> and I don't know how to take following (may sort be ignoring the
> white-space between name and surname?):
>  Yi Li <liyi1@chinatelecom.cn>
>  Yi Liu <yi.liu@nxp.com>
>  Yilong Lv <lvyilong.lyl@alibaba-inc.com>
>  Yi Lu <luyi68@live.com>
> 
> 
> But to be able to sort whole file with 'sort' and no need to manually
> fix above quirks, I am OK with the change, hence:
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>

It's a good first step, but I tend to agree with Stephen that having Yan
appear after Yanjie indicates incorrect sorting.  Testing with "sort" on my
system, "sort -f" [or "sort --ignore-case"] seems to do the right thing.
The capital letter on the second names in the list may be throwing things
off.

/Bruce
  

Patch

diff --git a/.mailmap b/.mailmap
index d200f363394d..bfd3528cf734 100644
--- a/.mailmap
+++ b/.mailmap
@@ -115,8 +115,8 @@  Anoob Joseph <anoobj@marvell.com> <anoob.joseph@caviumnetworks.com>
 Antara Ganesh Kolar <antara.ganesh.kolar@intel.com>
 Anthony Fee <anthonyx.fee@intel.com>
 Antonio Fischetti <antonio.fischetti@intel.com>
-Anup Prabhu <aprabhu@marvell.com>
 Anupam Kapoor <anupam.kapoor@gmail.com>
+Anup Prabhu <aprabhu@marvell.com>
 Apeksha Gupta <apeksha.gupta@nxp.com>
 Archana Muniganti <marchana@marvell.com> <muniganti.archana@caviumnetworks.com>
 Archit Pandey <architpandeynitk@gmail.com>
@@ -148,8 +148,8 @@  Balakrishna Bhamidipati <bbhamidipati@marvell.com>
 Balasubramanian Manoharan <balasubramanian.manoharan@caviumnetworks.com>
 Balazs Nemeth <bnemeth@redhat.com> <balazs.nemeth@intel.com>
 Bao-Long Tran <longtb5@viettel.com.vn>
-Bar Neuman <bneuman@nvidia.com>
 Barak Enat <barak@saguna.net>
+Bar Neuman <bneuman@nvidia.com>
 Barry Cao <barry.cao@nxp.com>
 Baruch Siach <baruch@tkos.co.il>
 Bassam Zaid AlKilani <bzalkilani@nvidia.com>
@@ -1077,8 +1077,8 @@  Peter Mccarthy <peter.mccarthy@intel.com>
 Peter Spreadborough <peter.spreadborough@broadcom.com>
 Petr Houska <t-pehous@microsoft.com>
 Phanendra Vukkisala <pvukkisala@marvell.com>
-Phil Yang <phil.yang@arm.com>
 Philip Prindeville <philipp@redfish-solutions.com>
+Phil Yang <phil.yang@arm.com>
 Pier Damouny  <pdamouny@nvidia.com>
 Pierre Pfister <ppfister@cisco.com>
 Piotr Azarewicz <piotr.azarewicz@intel.com> <piotrx.t.azarewicz@intel.com>