From patchwork Wed Jul 12 10:07:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jieqiang Wang X-Patchwork-Id: 129498 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51F9642E53; Wed, 12 Jul 2023 12:07:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E8A2C40A7D; Wed, 12 Jul 2023 12:07:52 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mails.dpdk.org (Postfix) with ESMTP id 7C205406BA; Wed, 12 Jul 2023 12:07:50 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2FA6E2F4; Wed, 12 Jul 2023 03:08:32 -0700 (PDT) Received: from net-x86-dell-8268.shanghai.arm.com (net-x86-dell-8268.shanghai.arm.com [10.169.210.116]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id AA7423F73F; Wed, 12 Jul 2023 03:07:45 -0700 (PDT) From: Jieqiang Wang To: Thomas Monjalon , Yuying Zhang , Beilei Xing , David Christensen , Ruifeng Wang , Bruce Richardson , Konstantin Ananyev , Jeff Guo , =?utf-8?q?Morten_Br=C3=B8rup?= , Qi Zhang Cc: dev@dpdk.org, nd@arm.com, Jieqiang Wang , stable@dpdk.org Subject: [PATCH] net/i40e: fix comments Date: Wed, 12 Jul 2023 18:07:32 +0800 Message-Id: <20230712100732.3469594-1-jieqiang.wang@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The limitation of burst size in i40e vector rx has been removed, but the comment lines have not been updated to reflect the code changes. Remove those lines to avoid confusion. Additionally, fix a typo in i40e_tx_queue. Fixes: 9e27f00f3a61 ("net/i40e: fix vector Rx") Cc: jia.guo@intel.com Cc: stable@dpdk.org Signed-off-by: Jieqiang Wang Reviewed-by: Ruifeng Wang --- .mailmap | 1 + drivers/net/i40e/i40e_rxtx.h | 2 +- drivers/net/i40e/i40e_rxtx_vec_altivec.c | 2 -- drivers/net/i40e/i40e_rxtx_vec_neon.c | 2 -- drivers/net/i40e/i40e_rxtx_vec_sse.c | 2 -- 5 files changed, 2 insertions(+), 7 deletions(-) diff --git a/.mailmap b/.mailmap index 6eccf0c555..670d312f84 100644 --- a/.mailmap +++ b/.mailmap @@ -628,6 +628,7 @@ Jie Liu Jie Pan Jie Wang Jie Zhou +Jieqiang Wang Jijiang Liu Jilei Chen Jim Harris diff --git a/drivers/net/i40e/i40e_rxtx.h b/drivers/net/i40e/i40e_rxtx.h index 0376c219be..a8686224e5 100644 --- a/drivers/net/i40e/i40e_rxtx.h +++ b/drivers/net/i40e/i40e_rxtx.h @@ -169,7 +169,7 @@ struct i40e_tx_queue { bool q_set; /**< indicate if tx queue has been configured */ bool tx_deferred_start; /**< don't start this queue in dev start */ uint8_t dcb_tc; /**< Traffic class of tx queue */ - uint64_t offloads; /**< Tx offload flags of RTE_ETH_RX_OFFLOAD_* */ + uint64_t offloads; /**< Tx offload flags of RTE_ETH_TX_OFFLOAD_* */ const struct rte_memzone *mz; }; diff --git a/drivers/net/i40e/i40e_rxtx_vec_altivec.c b/drivers/net/i40e/i40e_rxtx_vec_altivec.c index 8672ad1c41..4cd78f4e58 100644 --- a/drivers/net/i40e/i40e_rxtx_vec_altivec.c +++ b/drivers/net/i40e/i40e_rxtx_vec_altivec.c @@ -449,8 +449,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts, /* Notice: * - nb_pkts < RTE_I40E_DESCS_PER_LOOP, just return no packet - * - nb_pkts > RTE_I40E_VPMD_RX_BURST, only scan RTE_I40E_VPMD_RX_BURST - * numbers of DD bits */ uint16_t i40e_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts, diff --git a/drivers/net/i40e/i40e_rxtx_vec_neon.c b/drivers/net/i40e/i40e_rxtx_vec_neon.c index 49391fe4c7..d873e30972 100644 --- a/drivers/net/i40e/i40e_rxtx_vec_neon.c +++ b/drivers/net/i40e/i40e_rxtx_vec_neon.c @@ -574,8 +574,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *__rte_restrict rxq, /* * Notice: * - nb_pkts < RTE_I40E_DESCS_PER_LOOP, just return no packet - * - nb_pkts > RTE_I40E_VPMD_RX_BURST, only scan RTE_I40E_VPMD_RX_BURST - * numbers of DD bits */ uint16_t i40e_recv_pkts_vec(void *__rte_restrict rx_queue, diff --git a/drivers/net/i40e/i40e_rxtx_vec_sse.c b/drivers/net/i40e/i40e_rxtx_vec_sse.c index baf83cb3df..b94c37cbb8 100644 --- a/drivers/net/i40e/i40e_rxtx_vec_sse.c +++ b/drivers/net/i40e/i40e_rxtx_vec_sse.c @@ -596,8 +596,6 @@ _recv_raw_pkts_vec(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_pkts, /* * Notice: * - nb_pkts < RTE_I40E_DESCS_PER_LOOP, just return no packet - * - nb_pkts > RTE_I40E_VPMD_RX_BURST, only scan RTE_I40E_VPMD_RX_BURST - * numbers of DD bits */ uint16_t i40e_recv_pkts_vec(void *rx_queue, struct rte_mbuf **rx_pkts,