From patchwork Thu Jul 13 11:19:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Bing Zhao X-Patchwork-Id: 129521 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C16C42E5F; Thu, 13 Jul 2023 13:20:13 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D375D40DDB; Thu, 13 Jul 2023 13:20:12 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2042.outbound.protection.outlook.com [40.107.243.42]) by mails.dpdk.org (Postfix) with ESMTP id 2ED4E40DDA; Thu, 13 Jul 2023 13:20:11 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dvrEZecSWXOcLbLfRpx+pjpyUgSyQyeyka4m/4DJdE5ugtXpKZEr9q4gnq14bMg3GJcnPU7LyqXtUqr+KR81zxsBEndL/7cz4W2fKk2z50lmWwp5XMAyO+a9UdIArIdWFM4UGYJn8blyMEjB/9x9OQOnSU6Ts/R7qwMiEP6LX8QhoNPKcTD21IASX1YuxP8FTIZRVs5a8XuSkWs2ystYnN964wCajHrcC/yiHhBUkvWZmvluPH4cynWSH4KHdmgokwUP7sxAZ4vt33skaE8QI2B5ksypfqCa7JxCNO02B9P+uveHdwhHLh9TXxMEQr49KgYLD7cLV0A8Fdi3aS4p2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=V66YF1oS8DTFDhDs6nU/SoVthdiiMTETMSiDosbA1Ew=; b=O7htWDBY2uCxdHGXyTREXdlIhxpMCyvWKwzdnP0c+Z4GKg/QZofbiZcb/wvClxQW5hRggMiNjgP6GkEPzxAGp5f5beclQRbpGD1maJVum+Mlrk5EpaFLjDojQ1WGSWXvwI80p0mJ3yBMGQgdiCS6vfivHRrlU3Gd1ojDYO9oMQRa5S2Mlfece48U5pDy4ZDUwi+Bt3c8BjMsmhoYZizEztCFgo4tZk8jKz1sx4JmgXGMmtI+Kjl5XaAINq0oGolUJK5MCppFgxHChi0mcMP0zL5cxBlqSFm+XhmlquSBrTxdzuSjvWeFGwNb81C7LGVq8l00wosduUjAmlFiNnIYpA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=V66YF1oS8DTFDhDs6nU/SoVthdiiMTETMSiDosbA1Ew=; b=XzcrIhWRGFNN1JmSfC5BREVziJGizfhKHtb7eIml+jk/VQP24RGUQyyRpoezhRsU97+4nIYKBiuVxzMKONHKxeudQk/EUQKflAg1VgtjJ/Dah/ulPH9LuuSkmLF6+Isvn2qsiacpZ+jBKH1WJ6DTv1MEOEv6v+rXNipy6FYk4ODEyYOBYbl3xjLmFo69QRexXqw0nozvde0xM0BjDPYFLzv72pBaliiyzTpLrp9MCJx2uSD8lx/pnAHtxHOyMoBf4pvj9w5vd8HhSrRXLpa4gSYoG1BRW34KY3NpxP7osB48eYMfpJ83Lt8BEVGxdHJ56KCz6WtZ7MxWix254f/8EA== Received: from MW4PR04CA0236.namprd04.prod.outlook.com (2603:10b6:303:87::31) by PH7PR12MB5854.namprd12.prod.outlook.com (2603:10b6:510:1d5::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.20; Thu, 13 Jul 2023 11:20:08 +0000 Received: from CO1NAM11FT090.eop-nam11.prod.protection.outlook.com (2603:10b6:303:87:cafe::5e) by MW4PR04CA0236.outlook.office365.com (2603:10b6:303:87::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.20 via Frontend Transport; Thu, 13 Jul 2023 11:20:08 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT090.mail.protection.outlook.com (10.13.175.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6588.24 via Frontend Transport; Thu, 13 Jul 2023 11:20:08 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 13 Jul 2023 04:19:59 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Thu, 13 Jul 2023 04:19:56 -0700 From: Bing Zhao To: , , , , CC: , , David Marchand , =?utf-8?q?M=C3=A1rio_Kuka?= Subject: [PATCH v2] net/mlx5: fix the drop action memory leak Date: Thu, 13 Jul 2023 14:19:41 +0300 Message-ID: <20230713111941.427361-1-bingz@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230713110643.427264-1-bingz@nvidia.com> References: <20230713110643.427264-1-bingz@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT090:EE_|PH7PR12MB5854:EE_ X-MS-Office365-Filtering-Correlation-Id: 326a7557-59f9-4e77-6439-08db83931dd1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: zpx34jM6WiljLOcG3KDzegIdGPAR2n08E/uEFNRuCsEmB+N/wS2VYgo0p+vU9l3Cfdea7qie4wW1C8CYxi3yDxB3tvYcq7NCZfknOYoPXuMMusFe8OGQkaGJ1Tpdq+Xv7VroteDCGetV2Qp69hZj+gCNmxVMDHfLqCDtrR2jMF3R158eMp4TjPtjdydqB0scMoc+MQPGV8dqnzUU/YwM95KF9NfiYcaDFyRZioA/hRJK3/4/7F3Dw8Av7Y0hzmsD26NwvGkMaI62jgeQGgBNimFUrOVHtAOlrcIlc0YYCrrxK5deI/BHGz8e6zasPllv1GLx240OOSYHW7zO4wjG+HMr4yVsnLJ7oozRT7bSi1dGTt6MO53fHE/kn1Do8dvTs9JC90/eSuXlpLmJ1FmaQOg3o2c8EgHN13mtU1JRS2033taaz/GLfKtc2BBQSyMIExXGuy3LaOPohJBZpxaBkma+QXqvIp9QvUO1ZuB22i7E+yA8dkSr2uh5c4ZNnho1f05ldHFaKU3BjkbTvYcYzwp+GoCer2tRx5DhA2gdYNx10kXeCX5YMybm63E71993xa8yp1oOl4G0HFuBUk7RwI+9QqCsTfzSe37JOYkkL4ucYOXt703IG4vs0a07hIya+m+fCiB01AQ08FUDA4eAkr+XqMwehQvF+s6hYl9GaSwPOo1UsFibPWWQAOA3l/vL5OOP1m/Dfi4PuwC5CygabgnWuKczeA/zJC5CuheBZOIP6RQifYaSt5wfImhA8WZH X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(376002)(346002)(136003)(39860400002)(396003)(451199021)(46966006)(40470700004)(36840700001)(36860700001)(7696005)(478600001)(6666004)(110136005)(54906003)(47076005)(16526019)(186003)(26005)(1076003)(6286002)(70206006)(2906002)(82310400005)(41300700001)(316002)(5660300002)(8936002)(4326008)(6636002)(70586007)(356005)(82740400003)(8676002)(7636003)(40460700003)(86362001)(36756003)(426003)(336012)(2616005)(40480700001)(55016003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Jul 2023 11:20:08.5656 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 326a7557-59f9-4e77-6439-08db83931dd1 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT090.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB5854 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In DV mode, when quitting an application, the default drop action and its resources should be released. The Devx action for the TIR was not destroyed and it would cause 80B memory leak. With this commit, in DV mode, the action should be destroyed in the mlx5_devx_drop_action_destroy() explicitly. Bugzilla ID: 1192 Bugzilla ID: 1255 Fixes: bc5bee028ebc ("net/mlx5: create drop queue using DevX") Cc: stable@dpdk.org Reported-by: David Marchand Reported-by: Mário Kuka Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- v2: added the reporter --- drivers/net/mlx5/mlx5_devx.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c index d286cfe864..9fa400fc48 100644 --- a/drivers/net/mlx5/mlx5_devx.c +++ b/drivers/net/mlx5/mlx5_devx.c @@ -1134,6 +1134,10 @@ mlx5_devx_drop_action_destroy(struct rte_eth_dev *dev) struct mlx5_priv *priv = dev->data->dev_private; struct mlx5_hrxq *hrxq = priv->drop_queue.hrxq; +#if defined(HAVE_IBV_FLOW_DV_SUPPORT) || !defined(HAVE_INFINIBAND_VERBS_H) + if (hrxq->action != NULL) + mlx5_flow_os_destroy_flow_action(hrxq->action); +#endif if (hrxq->tir != NULL) mlx5_devx_tir_destroy(hrxq); if (hrxq->ind_table->ind_table != NULL)