diff mbox series

[v3,3/3] doc: announce bonding function change

Message ID 20230718082856.2235450-4-chaoyong.he@corigine.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series announce bonding macro and function change |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Functional success Functional PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-unit-testing fail Testing issues
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS

Commit Message

Chaoyong He July 18, 2023, 8:28 a.m. UTC 
  In order to support inclusive naming, some of the function in DPDK will
need to be renamed. Do this through deprecation process now for 23.07.

Signed-off-by: Long Wu <long.wu@corigine.com>
Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
---
 doc/guides/rel_notes/deprecation.rst | 11 +++++++++++
 1 file changed, 11 insertions(+)

Comments

Ferruh Yigit July 18, 2023, 11:40 a.m. UTC | #1 
On 7/18/2023 9:28 AM, Chaoyong He wrote:
> In order to support inclusive naming, some of the function in DPDK will
> need to be renamed. Do this through deprecation process now for 23.07.
> 
> Signed-off-by: Long Wu <long.wu@corigine.com>
> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
>

Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
Stephen Hemminger July 18, 2023, 3:52 p.m. UTC | #2 
On Tue, 18 Jul 2023 16:28:56 +0800
Chaoyong He <chaoyong.he@corigine.com> wrote:

> In order to support inclusive naming, some of the function in DPDK will
> need to be renamed. Do this through deprecation process now for 23.07.
> 
> Signed-off-by: Long Wu <long.wu@corigine.com>
> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>

Acked-by: Stephen Hemminger <stephen@networkplumber.org>
lihuisong (C) July 19, 2023, 1:31 a.m. UTC | #3 
Hi Chaoyong,

All something about slave in variables and logs should be fixed.
Is this in your plan?

/Huisong


在 2023/7/18 16:28, Chaoyong He 写道:
> In order to support inclusive naming, some of the function in DPDK will
> need to be renamed. Do this through deprecation process now for 23.07.
>
> Signed-off-by: Long Wu <long.wu@corigine.com>
> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> ---
>   doc/guides/rel_notes/deprecation.rst | 11 +++++++++++
>   1 file changed, 11 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 8cf972a9ab..45da0361e6 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -123,6 +123,17 @@ Deprecation Notices
>     ``RTE_ETH_DEV_BONDING_MEMBER``.
>     The data structure ``struct rte_eth_bond_8023ad_slave_info`` will be
>     renamed to ``struct rte_eth_bond_8023ad_member_info`` in DPDK 23.11.
> +  The following functions will be removed in DPDK 23.11. The old functions:
> +  ``rte_eth_bond_8023ad_slave_info``,
> +  ``rte_eth_bond_active_slaves_get``,
> +  ``rte_eth_bond_slave_add``,
> +  ``rte_eth_bond_slave_remove``, and
> +  ``rte_eth_bond_slaves_get`` will be replaced by:
> +  ``rte_eth_bond_8023ad_member_info``,
> +  ``rte_eth_bond_active_members_get``,
> +  ``rte_eth_bond_member_add``,
> +  ``rte_eth_bond_member_remove``, and
> +  ``rte_eth_bond_members_get``.
>   
>   * cryptodev: The function ``rte_cryptodev_cb_fn`` will be updated
>     to have another parameter ``qp_id`` to return the queue pair ID
Chaoyong He July 19, 2023, 1:37 a.m. UTC | #4 
> [Some people who received this message don't often get email from
> lihuisong@huawei.com. Learn why this is important at
> https://aka.ms/LearnAboutSenderIdentification ]
> 
> Hi Chaoyong,
> 
> All something about slave in variables and logs should be fixed.
> Is this in your plan?
> 
> /Huisong
> 

Oh, yes, we have a patch series to do that (replace master/slave in everywhere for bonding PMD).
And that patch series has been delay to v23.11 version.

> 
> 在 2023/7/18 16:28, Chaoyong He 写道:
> > In order to support inclusive naming, some of the function in DPDK
> > will need to be renamed. Do this through deprecation process now for
> 23.07.
> >
> > Signed-off-by: Long Wu <long.wu@corigine.com>
> > Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> > ---
> >   doc/guides/rel_notes/deprecation.rst | 11 +++++++++++
> >   1 file changed, 11 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/deprecation.rst
> > b/doc/guides/rel_notes/deprecation.rst
> > index 8cf972a9ab..45da0361e6 100644
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > @@ -123,6 +123,17 @@ Deprecation Notices
> >     ``RTE_ETH_DEV_BONDING_MEMBER``.
> >     The data structure ``struct rte_eth_bond_8023ad_slave_info`` will be
> >     renamed to ``struct rte_eth_bond_8023ad_member_info`` in DPDK 23.11.
> > +  The following functions will be removed in DPDK 23.11. The old functions:
> > +  ``rte_eth_bond_8023ad_slave_info``,
> > +  ``rte_eth_bond_active_slaves_get``,
> > +  ``rte_eth_bond_slave_add``,
> > +  ``rte_eth_bond_slave_remove``, and
> > +  ``rte_eth_bond_slaves_get`` will be replaced by:
> > +  ``rte_eth_bond_8023ad_member_info``,
> > +  ``rte_eth_bond_active_members_get``,
> > +  ``rte_eth_bond_member_add``,
> > +  ``rte_eth_bond_member_remove``, and  ``rte_eth_bond_members_get``.
> >
> >   * cryptodev: The function ``rte_cryptodev_cb_fn`` will be updated
> >     to have another parameter ``qp_id`` to return the queue pair ID
lihuisong (C) July 19, 2023, 1:53 a.m. UTC | #5 
在 2023/7/19 9:37, Chaoyong He 写道:
>> [Some people who received this message don't often get email from
>> lihuisong@huawei.com. Learn why this is important at
>> https://aka.ms/LearnAboutSenderIdentification ]
>>
>> Hi Chaoyong,
>>
>> All something about slave in variables and logs should be fixed.
>> Is this in your plan?
>>
>> /Huisong
>>
> Oh, yes, we have a patch series to do that (replace master/slave in everywhere for bonding PMD).
> And that patch series has been delay to v23.11 version.
great.
Acked-by: Huisong Li <lihuisong@huawei.com>
>
>> 在 2023/7/18 16:28, Chaoyong He 写道:
>>> In order to support inclusive naming, some of the function in DPDK
>>> will need to be renamed. Do this through deprecation process now for
>> 23.07.
>>> Signed-off-by: Long Wu <long.wu@corigine.com>
>>> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
>>> ---
>>>    doc/guides/rel_notes/deprecation.rst | 11 +++++++++++
>>>    1 file changed, 11 insertions(+)
>>>
>>> diff --git a/doc/guides/rel_notes/deprecation.rst
>>> b/doc/guides/rel_notes/deprecation.rst
>>> index 8cf972a9ab..45da0361e6 100644
>>> --- a/doc/guides/rel_notes/deprecation.rst
>>> +++ b/doc/guides/rel_notes/deprecation.rst
>>> @@ -123,6 +123,17 @@ Deprecation Notices
>>>      ``RTE_ETH_DEV_BONDING_MEMBER``.
>>>      The data structure ``struct rte_eth_bond_8023ad_slave_info`` will be
>>>      renamed to ``struct rte_eth_bond_8023ad_member_info`` in DPDK 23.11.
>>> +  The following functions will be removed in DPDK 23.11. The old functions:
>>> +  ``rte_eth_bond_8023ad_slave_info``,
>>> +  ``rte_eth_bond_active_slaves_get``,
>>> +  ``rte_eth_bond_slave_add``,
>>> +  ``rte_eth_bond_slave_remove``, and
>>> +  ``rte_eth_bond_slaves_get`` will be replaced by:
>>> +  ``rte_eth_bond_8023ad_member_info``,
>>> +  ``rte_eth_bond_active_members_get``,
>>> +  ``rte_eth_bond_member_add``,
>>> +  ``rte_eth_bond_member_remove``, and  ``rte_eth_bond_members_get``.
>>>
>>>    * cryptodev: The function ``rte_cryptodev_cb_fn`` will be updated
>>>      to have another parameter ``qp_id`` to return the queue pair ID
diff mbox series

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 8cf972a9ab..45da0361e6 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -123,6 +123,17 @@  Deprecation Notices
   ``RTE_ETH_DEV_BONDING_MEMBER``.
   The data structure ``struct rte_eth_bond_8023ad_slave_info`` will be
   renamed to ``struct rte_eth_bond_8023ad_member_info`` in DPDK 23.11.
+  The following functions will be removed in DPDK 23.11. The old functions:
+  ``rte_eth_bond_8023ad_slave_info``,
+  ``rte_eth_bond_active_slaves_get``,
+  ``rte_eth_bond_slave_add``,
+  ``rte_eth_bond_slave_remove``, and
+  ``rte_eth_bond_slaves_get`` will be replaced by:
+  ``rte_eth_bond_8023ad_member_info``,
+  ``rte_eth_bond_active_members_get``,
+  ``rte_eth_bond_member_add``,
+  ``rte_eth_bond_member_remove``, and
+  ``rte_eth_bond_members_get``.
 
 * cryptodev: The function ``rte_cryptodev_cb_fn`` will be updated
   to have another parameter ``qp_id`` to return the queue pair ID