usertools/rss: fix byte order of the default i40e key

Message ID 20230720081500.156361-2-rjarry@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series usertools/rss: fix byte order of the default i40e key |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-aarch-unit-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-unit-testing fail Testing issues
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS

Commit Message

Robin Jarry July 20, 2023, 8:15 a.m. UTC
  The key is represented as uint32 words in the driver source code but it
is actually stored as little endian in the NIC registers. Fix the byte
ordering in the python script.

Fixes: 106a231ae528 ("usertools: add tool to generate balanced rss traffic flows")

Reported-by: Abhiram R N <arn@redhat.com>
Signed-off-by: Robin Jarry <rjarry@redhat.com>
---
 usertools/dpdk-rss-flows.py | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)
  

Comments

Thomas Monjalon July 22, 2023, 12:40 p.m. UTC | #1
20/07/2023 10:15, Robin Jarry:
> The key is represented as uint32 words in the driver source code but it
> is actually stored as little endian in the NIC registers. Fix the byte
> ordering in the python script.
> 
> Fixes: 106a231ae528 ("usertools: add tool to generate balanced rss traffic flows")
> 
> Reported-by: Abhiram R N <arn@redhat.com>
> Signed-off-by: Robin Jarry <rjarry@redhat.com>

Applied, thanks.
  

Patch

diff --git a/usertools/dpdk-rss-flows.py b/usertools/dpdk-rss-flows.py
index 4cdc524ddcb4..73821eb47125 100755
--- a/usertools/dpdk-rss-flows.py
+++ b/usertools/dpdk-rss-flows.py
@@ -179,13 +179,13 @@  def balanced_traffic(
 # i40e is the only driver that takes 52 bytes keys
 RSS_KEY_I40E = bytes(
     (
-        0x6b, 0x79, 0x39, 0x44, 0x23, 0x50, 0x4c, 0xb5,
-        0x5b, 0xea, 0x75, 0xb6, 0x30, 0x9f, 0x4f, 0x12,
-        0x3d, 0xc0, 0xa2, 0xb8, 0x02, 0x4d, 0xdc, 0xdf,
-        0x33, 0x9b, 0x8c, 0xa0, 0x4c, 0x4a, 0xf6, 0x4a,
-        0x34, 0xfa, 0xc6, 0x05, 0x55, 0xd8, 0x58, 0x39,
-        0x3a, 0x58, 0x99, 0x7d, 0x2e, 0xc9, 0x38, 0xe1,
-        0x66, 0x03, 0x15, 0x81,
+        0x44, 0x39, 0x79, 0x6b, 0xb5, 0x4c, 0x50, 0x23,
+        0xb6, 0x75, 0xea, 0x5b, 0x12, 0x4f, 0x9f, 0x30,
+        0xb8, 0xa2, 0xc0, 0x3d, 0xdf, 0xdc, 0x4d, 0x02,
+        0xa0, 0x8c, 0x9b, 0x33, 0x4a, 0xf6, 0x4a, 0x4c,
+        0x05, 0xc6, 0xfa, 0x34, 0x39, 0x58, 0xd8, 0x55,
+        0x7d, 0x99, 0x58, 0x3a, 0xe1, 0x38, 0xc9, 0x2e,
+        0x81, 0x15, 0x03, 0x66,
     )
 )
 # fmt: on