diff mbox series

app/test: fix include of standard header

Message ID 20230721105719.53927-1-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series app/test: fix include of standard header |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/github-robot: build success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-unit-testing fail Testing issues
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-testing warning Testing issues
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS

Commit Message

Bruce Richardson July 21, 2023, 10:57 a.m. UTC 
  Standard headers, or headers not in the current directory generally,
should be wrapped in "<>" rather than in regular quotes "". Fix one
instance of unistd.h being included using quotes

Fixes: df468c4937bb ("app/test: refactor bonding checks with macros")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 app/test/test_link_bonding.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Morten Brørup July 21, 2023, 11:24 a.m. UTC | #1 
> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> Sent: Friday, 21 July 2023 12.57
> 
> Standard headers, or headers not in the current directory generally,
> should be wrapped in "<>" rather than in regular quotes "". Fix one
> instance of unistd.h being included using quotes
> 
> Fixes: df468c4937bb ("app/test: refactor bonding checks with macros")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---

Acked-by: Morten Brørup <mb@smartsharesystems.com>
Ferruh Yigit July 21, 2023, 5:24 p.m. UTC | #2 
On 7/21/2023 12:24 PM, Morten Brørup wrote:
>> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
>> Sent: Friday, 21 July 2023 12.57
>>
>> Standard headers, or headers not in the current directory generally,
>> should be wrapped in "<>" rather than in regular quotes "". Fix one
>> instance of unistd.h being included using quotes
>>
>> Fixes: df468c4937bb ("app/test: refactor bonding checks with macros")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
>> ---
> 
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
> 

Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>

Applied to dpdk-next-net/main, thanks.
diff mbox series

Patch

diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c
index 5c496352c2..2f46e4c6ee 100644
--- a/app/test/test_link_bonding.c
+++ b/app/test/test_link_bonding.c
@@ -2,7 +2,7 @@ 
  * Copyright(c) 2010-2014 Intel Corporation
  */
 
-#include "unistd.h"
+#include <unistd.h>
 #include <string.h>
 #include <stdarg.h>
 #include <stdio.h>