From patchwork Wed Aug 2 23:25:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 129863 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7863A42FBA; Thu, 3 Aug 2023 01:27:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 58E9043299; Thu, 3 Aug 2023 01:26:18 +0200 (CEST) Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) by mails.dpdk.org (Postfix) with ESMTP id 1C80E4327B for ; Thu, 3 Aug 2023 01:26:14 +0200 (CEST) Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-54290603887so190558a12.1 for ; Wed, 02 Aug 2023 16:26:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1691018773; x=1691623573; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wdtrx1bt+pXSG4ENagRsn7sFIbbPdBYL6XQe/0CCe7g=; b=Cjy5ns2KeSEv7krhSxAqGpSdQz5Uc2PeLbIhu6WfqOBqnIS1/HEnMenTPdiRcsV4p/ 54hALxX7O9XjyAJEqUDCZhHZukXm8WK4RWoZKO5J2XMSrb/He474+5F5QvCXGzTlASZl KQBd6qpiBxKir4Eq6c4PY9gNCjD/sfXVkDbObTBvYEdymT/+nW6BHOeMOxqK0Gsvkdcm eMO7c+Ca4uNqIVSVsC2NTGC1c82HHQsH0GOrDyax8FTKayAgagAmA65ja+3GNWuBgzSl CZH+yzJBCGy43L/GB5i6pT5omuhXNBKgZ2sp3y1+Ti/7ClZmKm9Ehw3IqN8I8ja4JnVc x3+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691018773; x=1691623573; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wdtrx1bt+pXSG4ENagRsn7sFIbbPdBYL6XQe/0CCe7g=; b=LVhgM72O9IZfT6GWS/IhIMjDt6/kahk987U+uUpDTl5PyrZ8qYFN0xmEQOLvHKHeBW GoVM6w2NJu8scgntJzja3EdUcJv3McpO/hwi/Vlfzj4ISYKD4Mmf+KmMsYn6UI+gBcsj Rwv93cn60Cdvd5pREHuEqW9o4KdDwQKe63u3OxCtWVYLTCw3OeRgXv78glelXXYSZrFO U4Ul7/3t8QeuXAjMipvv2zpUKH97ToULSuaXF0GHZ+r7/ZlZoPcc4I5RvvvZQnUYIW8h 1mj0jSKl3EtVA5Rp2ctWCM+DKQjDNsAXDx4Q5p5DOrC3pSHsKRfKSYRnx2Jv03onMXIy Yx1Q== X-Gm-Message-State: ABy/qLYcbLjP/jIGhdynLnqOj02udLh6YS8Tb+ATHblYqTq/LQusB8Is jOam/OSs5GJNzZ4gQYib6wmlvhZApFFihLGOH1o2nw== X-Google-Smtp-Source: APBJJlGBifiE9Fq7ZhEq8MD4ZJFFUK+DPBngFbgpv7AFTKwLINrJmCE20bBpZY6riDZamt5w/Hnu8A== X-Received: by 2002:a05:6a20:3d1e:b0:13e:8ce5:cacd with SMTP id y30-20020a056a203d1e00b0013e8ce5cacdmr6373678pzi.26.1691018773043; Wed, 02 Aug 2023 16:26:13 -0700 (PDT) Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207]) by smtp.gmail.com with ESMTPSA id jd20-20020a170903261400b001b8b0ac2258sm12960870plb.174.2023.08.02.16.26.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Aug 2023 16:26:12 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Julien Aube Subject: [PATCH v4 13/19] net/bnx2x: remove reference to sanity Date: Wed, 2 Aug 2023 16:25:44 -0700 Message-Id: <20230802232550.125487-14-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230802232550.125487-1-stephen@networkplumber.org> References: <20230517161603.117728-1-stephen@networkplumber.org> <20230802232550.125487-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace "sanity check" Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x.c | 2 +- drivers/net/bnx2x/bnx2x_stats.c | 8 ++++---- drivers/net/bnx2x/ecore_sp.c | 2 +- drivers/net/bnx2x/elink.c | 4 ++-- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/bnx2x/bnx2x.c b/drivers/net/bnx2x/bnx2x.c index 29c16bb207c7..0d2dc2d3b3fa 100644 --- a/drivers/net/bnx2x/bnx2x.c +++ b/drivers/net/bnx2x/bnx2x.c @@ -7821,7 +7821,7 @@ static int bnx2x_check_valid_mf_cfg(struct bnx2x_softc *sc) uint32_t ovlan2; uint8_t i, j; - /* various MF mode sanity checks... */ + /* various MF mode checks... */ if (mf_info->mf_config[SC_VN(sc)] & FUNC_MF_CFG_FUNC_HIDE) { PMD_DRV_LOG(NOTICE, sc, diff --git a/drivers/net/bnx2x/bnx2x_stats.c b/drivers/net/bnx2x/bnx2x_stats.c index c07b01510a06..86d90679ac0a 100644 --- a/drivers/net/bnx2x/bnx2x_stats.c +++ b/drivers/net/bnx2x/bnx2x_stats.c @@ -187,7 +187,7 @@ bnx2x_stats_pmf_update(struct bnx2x_softc *sc) */ return; } - /* sanity */ + /* input valid? */ if (!sc->port.pmf || !sc->port.port_stx) { PMD_DRV_LOG(ERR, sc, "BUG!"); return; @@ -237,7 +237,7 @@ bnx2x_port_stats_init(struct bnx2x_softc *sc) uint32_t mac_addr; uint32_t *stats_comp = BNX2X_SP(sc, stats_comp); - /* sanity */ + /* input valid? */ if (!sc->link_vars.link_up || !sc->port.pmf) { PMD_DRV_LOG(ERR, sc, "BUG!"); return; @@ -461,7 +461,7 @@ bnx2x_func_stats_init(struct bnx2x_softc *sc) struct dmae_command *dmae = &sc->stats_dmae; uint32_t *stats_comp = BNX2X_SP(sc, stats_comp); - /* sanity */ + /* input valid? */ if (!sc->func_stx) { PMD_DRV_LOG(ERR, sc, "BUG!"); return; @@ -1301,7 +1301,7 @@ bnx2x_port_stats_base_init(struct bnx2x_softc *sc) struct dmae_command *dmae; uint32_t *stats_comp = BNX2X_SP(sc, stats_comp); - /* sanity */ + /* input valid? */ if (!sc->port.pmf || !sc->port.port_stx) { PMD_DRV_LOG(ERR, sc, "BUG!"); return; diff --git a/drivers/net/bnx2x/ecore_sp.c b/drivers/net/bnx2x/ecore_sp.c index c6c3857778f7..158205266f62 100644 --- a/drivers/net/bnx2x/ecore_sp.c +++ b/drivers/net/bnx2x/ecore_sp.c @@ -207,7 +207,7 @@ static int ecore_exe_queue_step(struct bnx2x_softc *sc, break; } - /* Sanity check */ + /* Argument check */ if (!cur_len) return ECORE_SUCCESS; diff --git a/drivers/net/bnx2x/elink.c b/drivers/net/bnx2x/elink.c index 2c81f85b9605..6ebd47d927f8 100644 --- a/drivers/net/bnx2x/elink.c +++ b/drivers/net/bnx2x/elink.c @@ -1088,7 +1088,7 @@ static void elink_get_epio(struct bnx2x_softc *sc, uint32_t epio_pin, { uint32_t epio_mask, gp_oenable; *en = 0; - /* Sanity check */ + /* Input check */ if (epio_pin > 31) { ELINK_DEBUG_P1(sc, "Invalid EPIO pin %d to get", epio_pin); return; @@ -1105,7 +1105,7 @@ static void elink_set_epio(struct bnx2x_softc *sc, uint32_t epio_pin, uint32_t e { uint32_t epio_mask, gp_output, gp_oenable; - /* Sanity check */ + /* Input check */ if (epio_pin > 31) { ELINK_DEBUG_P1(sc, "Invalid EPIO pin %d to set", epio_pin); return;