From patchwork Wed Aug 2 23:25:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 129864 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5FE6A42FBA; Thu, 3 Aug 2023 01:27:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 31A674329D; Thu, 3 Aug 2023 01:26:19 +0200 (CEST) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 21B724327D for ; Thu, 3 Aug 2023 01:26:15 +0200 (CEST) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1bbf8cb694aso3743235ad.3 for ; Wed, 02 Aug 2023 16:26:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1691018774; x=1691623574; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KOlEl4zdnsHIxSulAnvEygSojed2GgSF7XI43/ZPEOs=; b=poocDlMijbpyM3bBvUjNULFV2dJXhKpLRanq3iMKIaVyf7Lz+YBJUW8avyLzzewzcr 9lnHUQrFZqC1FgX1QMVJc3k6m2HjHB+DeXqxKtTqyzmAHnt3KiTryITkC0U4MuhO2hOv IexVrHWfUOuk9DHY0Q8HXlwnq/35L+mFqmKRGi6kJQRAwP+0SSgya7U8IdnlUgPi85wt jzUbZtD9xXtSTyVJSuAqNZqIofE+b/aHng1gEWoKF3sTIivSuv2AfwSbaYUxgT5mhq5L xWsDIaibtFwPERS7FEaNwstgyludrf3TY3ivvilbc33elIWF4eGMcUKuJK+jS6NSxJso dZbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691018774; x=1691623574; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KOlEl4zdnsHIxSulAnvEygSojed2GgSF7XI43/ZPEOs=; b=dU52L0PsL8k55j6toh0bWHaBBr9cZUKCAl93nN9JSZOtiUqvBaeWtzUeUtK30u2wB4 OImWLu5ppamY30KzEjlhgewQyb/in8DXdkCU9d+EFiiXw+PZS6nthEaFq6vdVn5CIZAe JhIinCGZvUSBrsSs/YS35z7nX5NLtwcwCs3xPh+qcFgH1MGOBq+XlSnXlO5Tw8vpfmRX HheYaAICfqPuIm4enHvSMdZW+c8JYSCFGEY2HW7NJaqQtHnTFL3eMjTcKfat6h1/LpIH EsEaz4+pfC8Y7iiLI/Mps6yHBY58uwPUeNFZxkU+arR2JutcvfjB3zxtzJufVaVNPkwu dHXQ== X-Gm-Message-State: ABy/qLa/wEuriuO3Aq/fQHbG4vH4bVGQKBLG5FBpcxalPFgVpnvRP65z i+dueA8W1WYWob7VFdJyH9U7KnKeTf+iDeWVgIdf7w== X-Google-Smtp-Source: APBJJlHDOMQm+oQL5E7l+U1E9Z71UJSi/ZWAZ+vgRtCvolvKA+RdSRvFdhQrHIu5dxvf8eQCOY8vOA== X-Received: by 2002:a17:903:41cf:b0:1b8:a65f:b49d with SMTP id u15-20020a17090341cf00b001b8a65fb49dmr20848319ple.12.1691018774124; Wed, 02 Aug 2023 16:26:14 -0700 (PDT) Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207]) by smtp.gmail.com with ESMTPSA id jd20-20020a170903261400b001b8b0ac2258sm12960870plb.174.2023.08.02.16.26.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Aug 2023 16:26:13 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao Subject: [PATCH v4 14/19] cnxk: replace term sanity Date: Wed, 2 Aug 2023 16:25:45 -0700 Message-Id: <20230802232550.125487-15-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230802232550.125487-1-stephen@networkplumber.org> References: <20230517161603.117728-1-stephen@networkplumber.org> <20230802232550.125487-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Do not use non-inclusive naming. Signed-off-by: Stephen Hemminger --- drivers/common/cnxk/roc_nix_tm_ops.c | 2 +- drivers/common/cnxk/roc_npa.c | 4 ++-- drivers/net/cnxk/cnxk_ethdev.c | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/common/cnxk/roc_nix_tm_ops.c b/drivers/common/cnxk/roc_nix_tm_ops.c index 4e88ad1beb71..d837e2247634 100644 --- a/drivers/common/cnxk/roc_nix_tm_ops.c +++ b/drivers/common/cnxk/roc_nix_tm_ops.c @@ -527,7 +527,7 @@ roc_nix_tm_hierarchy_disable(struct roc_nix *roc_nix) node->flags &= ~NIX_TM_NODE_ENABLED; } - /* Verify sanity of all tx queues */ + /* Verify all tx queues */ for (i = 0; i < sq_cnt; i++) { sq = nix->sqs[i]; if (!sq) diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c index 3b9a70028ba2..e796878ba634 100644 --- a/drivers/common/cnxk/roc_npa.c +++ b/drivers/common/cnxk/roc_npa.c @@ -456,7 +456,7 @@ npa_aura_pool_pair_alloc(struct npa_lf *lf, const uint32_t block_size, char name[PLT_MEMZONE_NAMESIZE]; const struct plt_memzone *mz; - /* Sanity check */ + /* argument checks */ if (!lf || !block_size || !block_count || !pool || !aura || !aura_handle) return NPA_ERR_PARAM; @@ -1076,7 +1076,7 @@ npa_dev_init(struct npa_lf *lf, uintptr_t base, struct mbox *mbox) uint8_t aura_sz; int rc; - /* Sanity checks */ + /* Input checks */ if (!lf || !base || !mbox) return NPA_ERR_PARAM; diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethdev.c index 4b98faa72980..e7d311337f27 100644 --- a/drivers/net/cnxk/cnxk_ethdev.c +++ b/drivers/net/cnxk/cnxk_ethdev.c @@ -636,7 +636,7 @@ cnxk_nix_rx_queue_setup(struct rte_eth_dev *eth_dev, uint16_t qid, struct rte_mempool *lpb_pool = mp; struct rte_mempool *spb_pool = NULL; - /* Sanity checks */ + /* input checks */ if (rx_conf->rx_deferred_start == 1) { plt_err("Deferred Rx start is not supported"); goto fail; @@ -1205,7 +1205,7 @@ cnxk_nix_configure(struct rte_eth_dev *eth_dev) rc = -EINVAL; - /* Sanity checks */ + /* baseline checks */ if (rte_eal_has_hugepages() == 0) { plt_err("Huge page is not configured"); goto fail_configure;