From patchwork Wed Aug 2 23:25:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 129858 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA3BE42FBA; Thu, 3 Aug 2023 01:26:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8220243276; Thu, 3 Aug 2023 01:26:13 +0200 (CEST) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id 7DCAA4326B for ; Thu, 3 Aug 2023 01:26:09 +0200 (CEST) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1bb84194bf3so3165075ad.3 for ; Wed, 02 Aug 2023 16:26:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1691018768; x=1691623568; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IqplCRQfeclXUmxgg44KzbjzMEITpGwERbTcw6uIYAE=; b=JwIx1B0GMZfAlWJFtuz4ktPpWI0G6NEyRftV+V1NzObiee2PRPlDOD1bsgp1EoRDtI CN/vzVmXVNGHKtcXwUP/uZ5GtkbXzLsw8tNkGCbGzHzg/CKbFmafjdi1tWFZC3Vvwjyf gWinQeo97+aLG5Q+fD7o8WM72ASX4EafhGCWFtfvBL0ww/8jgv15Kc9PjgfnXj4j1/j7 AlBLpankazTyGWeAJ0U7yT8v8YgDI3m4W5e2Xn+2PoBp/takBvqfCEjFD02MvXOdaWQx PD33n6Bri3BCxrkFYz2aaWVu+7nQxRSyUiPw8fNoAbRpGZLfFDxPp/zDhYDEoUvw7GvP MuNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691018768; x=1691623568; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IqplCRQfeclXUmxgg44KzbjzMEITpGwERbTcw6uIYAE=; b=UDU5F5L7FnBWXkQn9F9R46IjA63ZboySPb9p6kVhYoez8Lax3ShaY+IIJtQLK9YFIf wiuIyxVq1DGWwCEv/+fg0hwF6YgQLsIvZ3SaoQYKvlSk3m5SRsdXFr8H7z0bLEVO459s +P7EOCXGslCDfO3rgxzu8Y92DZ/1Iyo9XBl3+3OFwQGnUYCiBLubPiLJABeFcuTH8ONA filTGyO2p0dt41u7Vx/nqamSrhwfi5xe0T4BcAttegdrE77yxYe7UbV/eD36XqFgHIcM WBHu/hnlGehC/ROle3F3UwoK4rfoolxI38LIq8gltk5e+M4HU6EUt8Bxz9VzTJ18jTI6 6FRA== X-Gm-Message-State: ABy/qLb5/BkESsnqjK1XZo7vZ+55le8gt5Oy4D7KNcVqjQMfWwjnQcou GWem4XCEdrBibUroX0bR5lmVHZH3pG+pwNgf2wEEOA== X-Google-Smtp-Source: APBJJlFkWg0MEz4gnG8ovy/MvzKv3JzrDmOpPndrj/UpNvoVqp9p/ovsI6cdonnO9VV4DedPnhfuQQ== X-Received: by 2002:a17:903:1107:b0:1bb:3a7:6af7 with SMTP id n7-20020a170903110700b001bb03a76af7mr19747807plh.23.1691018768542; Wed, 02 Aug 2023 16:26:08 -0700 (PDT) Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207]) by smtp.gmail.com with ESMTPSA id jd20-20020a170903261400b001b8b0ac2258sm12960870plb.174.2023.08.02.16.26.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Aug 2023 16:26:08 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Qi Zhang , Xiao Wang , Qiming Yang , Wenjun Wu Subject: [PATCH v4 08/19] net/fm10k, net/ixgbe: remove word sanity Date: Wed, 2 Aug 2023 16:25:39 -0700 Message-Id: <20230802232550.125487-9-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230802232550.125487-1-stephen@networkplumber.org> References: <20230517161603.117728-1-stephen@networkplumber.org> <20230802232550.125487-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove non-inclusive term sanity from these Intel drivers. Signed-off-by: Stephen Hemminger --- drivers/net/fm10k/fm10k_ethdev.c | 2 +- drivers/net/fm10k/fm10k_rxtx.c | 2 +- drivers/net/ixgbe/ixgbe_fdir.c | 2 +- drivers/net/ixgbe/ixgbe_ipsec.c | 2 +- drivers/net/ixgbe/ixgbe_rxtx.c | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c index 4d3c4c10cfa4..894cf8c8a6b5 100644 --- a/drivers/net/fm10k/fm10k_ethdev.c +++ b/drivers/net/fm10k/fm10k_ethdev.c @@ -1757,7 +1757,7 @@ mempool_element_size_valid(struct rte_mempool *mp) /* account for up to 512B of alignment */ min_size -= FM10K_RX_DATABUF_ALIGN; - /* sanity check for overflow */ + /* check for overflow */ if (min_size > mp->elt_size) return 0; diff --git a/drivers/net/fm10k/fm10k_rxtx.c b/drivers/net/fm10k/fm10k_rxtx.c index c0841ab8cb34..94345299b22a 100644 --- a/drivers/net/fm10k/fm10k_rxtx.c +++ b/drivers/net/fm10k/fm10k_rxtx.c @@ -647,7 +647,7 @@ fm10k_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, if (q->nb_free < mb->nb_segs) break; - /* sanity check to make sure the mbuf is valid */ + /* check to make sure the mbuf is valid */ if ((mb->nb_segs == 0) || ((mb->nb_segs > 1) && (mb->next == NULL))) break; diff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c index 06d6e2126de5..51bbf577e3fe 100644 --- a/drivers/net/ixgbe/ixgbe_fdir.c +++ b/drivers/net/ixgbe/ixgbe_fdir.c @@ -1130,7 +1130,7 @@ ixgbe_fdir_filter_program(struct rte_eth_dev *dev, return -ENOTSUP; /* - * Sanity check for x550. + * Check for x550. * When adding a new filter with flow type set to IPv4, * the flow director mask should be configed before, * and the L4 protocol and ports are masked. diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/net/ixgbe/ixgbe_ipsec.c index d3313085560d..d4aa3e9ede8e 100644 --- a/drivers/net/ixgbe/ixgbe_ipsec.c +++ b/drivers/net/ixgbe/ixgbe_ipsec.c @@ -615,7 +615,7 @@ ixgbe_crypto_enable_ipsec(struct rte_eth_dev *dev) rx_offloads = dev->data->dev_conf.rxmode.offloads; tx_offloads = dev->data->dev_conf.txmode.offloads; - /* sanity checks */ + /* input validation */ if (rx_offloads & RTE_ETH_RX_OFFLOAD_TCP_LRO) { PMD_DRV_LOG(ERR, "RSC and IPsec not supported"); return -1; diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c index 954ef241a082..81f4cf2b271b 100644 --- a/drivers/net/ixgbe/ixgbe_rxtx.c +++ b/drivers/net/ixgbe/ixgbe_rxtx.c @@ -4975,7 +4975,7 @@ ixgbe_set_rsc(struct rte_eth_dev *dev) uint32_t rdrxctl; uint32_t rfctl; - /* Sanity check */ + /* Offload check */ dev->dev_ops->dev_infos_get(dev, &dev_info); if (dev_info.rx_offload_capa & RTE_ETH_RX_OFFLOAD_TCP_LRO) rsc_capable = true;