From patchwork Tue Aug 8 17:35:26 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 129964 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4416C4300E; Tue, 8 Aug 2023 19:37:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DDF9A432B7; Tue, 8 Aug 2023 19:36:02 +0200 (CEST) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id 7A323432A7 for ; Tue, 8 Aug 2023 19:35:58 +0200 (CEST) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-686f8614ce5so5867515b3a.3 for ; Tue, 08 Aug 2023 10:35:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1691516157; x=1692120957; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=pWrUcrx3QY2veudIAyIB9UEXA03L7m5PhCWZDX9VwMU=; b=4XxC8Av6HmRk3mVGd5OI1Sezgj6xmNg4OG2IwILn0S97OMWcvpgPPITIznUuizbCDy FQY/ePm3qcBBmHfVuTfLBrYkAdQl//yRRy2wYlayPsPFPk6R+NaNSV3QKSM85HWyN9+x haePlngAydr13D2+3vs9EqSQnaiLUgwHzQEu7xcbdmAs5E46MMEbL3CV/l2wS4/BinOR gOMs/+oyOB30rMqoABKd4KI/biLkyPRLUzVb0VfQ77YRvhpxNwaBSrmUSHdVorEVt4vM zeaazehCJfu7DVmSFORN9jENYggki5TSfzaaYrM/QMw+ts38gxQCPR/Ce01sXK6zgsxQ tRUA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691516157; x=1692120957; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pWrUcrx3QY2veudIAyIB9UEXA03L7m5PhCWZDX9VwMU=; b=LjVsszKSPKcJvf3LILEbR2fOUOFSSonxEsoUBTVFP2lEEvKLL4njAQbwoJbAnpwBKN GFPg8ZVHoNwiUaQcy2AWwIedI7ANQHh3m5c0JCnCtojPhL1jkEFB0nEBdDMJPuHDYoii DCJqO5YU8GeM7typcIWG69fWURKeJWaR9b7a4hXcHqj6tBCmiZNw1OTIvZ/srwe5XJ3J eBTYJ8/Afj6EakCp5TeLxrboRpvYsY89cH4rIFTrmFbgd5n5M5vlBe8abjo/B/qv6kTb amPNBajVChrq9aNSdtlLktsQ0Cs42oVgD5KLAWN93y/2TrYSDjaCf1u1L3SNP53Tk3kH MvMw== X-Gm-Message-State: AOJu0YwGiHft/PA2ozjCT8/Rx4BqWrHaA4rbCI+1ZtkNmCD8REAJJxRe ZSQ+diQ6xqAvEaihHWlYcLXoQPqBP7O9DHslKIlYSw== X-Google-Smtp-Source: AGHT+IHpv2luisJAXQ7DgHvN9ysnSUrbxsyr9N3EtTNKbJyN2O0iBCv6jNkGiAJ/10e2Fb2gRITHzQ== X-Received: by 2002:a05:6a00:1691:b0:687:7a30:deb with SMTP id k17-20020a056a00169100b006877a300debmr238339pfc.15.1691516157474; Tue, 08 Aug 2023 10:35:57 -0700 (PDT) Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207]) by smtp.gmail.com with ESMTPSA id m13-20020aa7900d000000b00682562bf479sm8328945pfo.53.2023.08.08.10.35.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 10:35:57 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Yipeng Wang , Sameh Gobriel Subject: [PATCH 19/20] member: remove experimental tag Date: Tue, 8 Aug 2023 10:35:26 -0700 Message-Id: <20230808173527.186042-20-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230808173527.186042-1-stephen@networkplumber.org> References: <20230808173527.186042-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The member library last received new API's in 22.11. All the API's should be marked stable by now. Signed-off-by: Stephen Hemminger --- lib/member/rte_member.h | 54 ----------------------------------------- lib/member/version.map | 12 +++------ 2 files changed, 3 insertions(+), 63 deletions(-) diff --git a/lib/member/rte_member.h b/lib/member/rte_member.h index a15e0d69e696..a6bf22651700 100644 --- a/lib/member/rte_member.h +++ b/lib/member/rte_member.h @@ -15,9 +15,6 @@ * bloom filter (vBF). For HT setsummary, two subtypes or modes are available, * cache and non-cache modes. The table below summarize some properties of * the different implementations. - * - * @warning - * @b EXPERIMENTAL: this API may change without prior notice */ /** @@ -117,17 +114,11 @@ extern int librte_member_logtype; struct rte_member_setsum; /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Parameter struct used to create set summary */ struct rte_member_parameters; /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Define different set summary types */ enum rte_member_setsum_type { @@ -207,9 +198,6 @@ struct rte_member_setsum { } __rte_cache_aligned; /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Parameters used when create the set summary table. Currently user can * specify two types of setsummary: HT based and vBF. For HT based, user can * specify cache or non-cache mode. Here is a table to describe some differences @@ -351,9 +339,6 @@ struct rte_member_parameters { } __rte_cache_aligned; /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Find an existing set-summary and return a pointer to it. * * @param name @@ -367,9 +352,6 @@ struct rte_member_setsum * rte_member_find_existing(const char *name); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Create set-summary (SS). * * @param params @@ -382,9 +364,6 @@ struct rte_member_setsum * rte_member_create(const struct rte_member_parameters *params); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Lookup key in set-summary (SS). * Single key lookup and return as soon as the first match found * @@ -402,9 +381,6 @@ rte_member_lookup(const struct rte_member_setsum *setsum, const void *key, member_set_t *set_id); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Lookup bulk of keys in set-summary (SS). * Each key lookup returns as soon as the first match found * @@ -427,9 +403,6 @@ rte_member_lookup_bulk(const struct rte_member_setsum *setsum, member_set_t *set_ids); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Lookup a key in set-summary (SS) for multiple matches. * The key lookup will find all matched entries (multiple match). * Note that for cache mode of HT, each key can have at most one match. This is @@ -456,9 +429,6 @@ rte_member_lookup_multi(const struct rte_member_setsum *setsum, member_set_t *set_id); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Lookup a bulk of keys in set-summary (SS) for multiple matches each key. * Each key lookup will find all matched entries (multiple match). * Note that for cache mode HT, each key can have at most one match. So @@ -489,9 +459,6 @@ rte_member_lookup_multi_bulk(const struct rte_member_setsum *setsum, member_set_t *set_ids); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Insert key into set-summary (SS). * * @param setsum @@ -522,9 +489,6 @@ rte_member_add(const struct rte_member_setsum *setsum, const void *key, member_set_t set_id); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Add the packet byte size into the sketch. * * @param setsum @@ -536,15 +500,11 @@ rte_member_add(const struct rte_member_setsum *setsum, const void *key, * @return * Return -EINVAL for invalid parameters, otherwise return 0. */ -__rte_experimental int rte_member_add_byte_count(const struct rte_member_setsum *setsum, const void *key, uint32_t byte_count); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Query packet count for a certain flow-key. * * @param setsum @@ -556,16 +516,12 @@ rte_member_add_byte_count(const struct rte_member_setsum *setsum, * @return * Return -EINVAL for invalid parameters. */ -__rte_experimental int rte_member_query_count(const struct rte_member_setsum *setsum, const void *key, uint64_t *count); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Report heavyhitter flow-keys into set-summary (SS). * * @param setsum @@ -578,16 +534,12 @@ rte_member_query_count(const struct rte_member_setsum *setsum, * Return -EINVAL for invalid parameters. Return a positive integer indicate * how many heavy hitters are reported. */ -__rte_experimental int rte_member_report_heavyhitter(const struct rte_member_setsum *setsum, void **keys, uint64_t *counts); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * De-allocate memory used by set-summary. * * @param setsum @@ -598,9 +550,6 @@ void rte_member_free(struct rte_member_setsum *setsum); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Reset the set-summary tables. E.g. reset bits to be 0 in BF, * reset set_id in each entry to be RTE_MEMBER_NO_MATCH in HT based SS. * @@ -611,9 +560,6 @@ void rte_member_reset(const struct rte_member_setsum *setsum); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Delete items from the set-summary. Note that vBF does not support deletion * in current implementation. For vBF, error code of -EINVAL will be returned. * diff --git a/lib/member/version.map b/lib/member/version.map index 9be5068d68fb..3aeba8826ba1 100644 --- a/lib/member/version.map +++ b/lib/member/version.map @@ -2,6 +2,7 @@ DPDK_24 { global: rte_member_add; + rte_member_add_byte_count; rte_member_create; rte_member_delete; rte_member_find_existing; @@ -10,16 +11,9 @@ DPDK_24 { rte_member_lookup_bulk; rte_member_lookup_multi; rte_member_lookup_multi_bulk; + rte_member_query_count; + rte_member_report_heavyhitter; rte_member_reset; local: *; }; - -EXPERIMENTAL { - global: - - # added in 22.11 - rte_member_add_byte_count; - rte_member_query_count; - rte_member_report_heavyhitter; -};