From patchwork Tue Aug 8 17:35:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 129950 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36D954300E; Tue, 8 Aug 2023 19:36:20 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 97C2A4326F; Tue, 8 Aug 2023 19:35:46 +0200 (CEST) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id 633C043265 for ; Tue, 8 Aug 2023 19:35:44 +0200 (CEST) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-686e29b058cso4246309b3a.1 for ; Tue, 08 Aug 2023 10:35:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1691516143; x=1692120943; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Xn81oAq1m1gfdSq2LkJzwfUYnEjF85fpIDHQS1AtQuY=; b=5BExX+tsmUzGTe/nFfhRRffGgvnKyku4H97shUo7vjNbQSwIW0wt3ZBCikAXYzMpQV pZfE3QqhTSFX7TXt9U3LmibNDkH/gODh2Y0EPuuYLnR2e8UnNiBLkwBLAcELt+Sumldk v5HFu+CCW7WO2+FLbG/MTSqMvlhe78s1yaC9pDsSPFVfODrbzYZuJ9T15u/bwv4wtS0v KZtxI5qn9ao4bQFp704tspBryWJxDl3MlV1/N7G/BZ4PMcvIQCqf3/+BXxvX8rmu8w3R UJ5EAmc+FT8be0lU6v3zm+yJhhyXEPz/wByFaohRAIFEh52rXeCAuO16a7zNr+FCawPp xGiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691516143; x=1692120943; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xn81oAq1m1gfdSq2LkJzwfUYnEjF85fpIDHQS1AtQuY=; b=bQT/k+3UPcIjOPkSSWf5vwZPjPAtHV/v06qNKz8xw/yU1Ys2wkbzbZIXilR9D98qy5 Q0U4A9c/GYsxFn2QIgB0ouRNXnqNUMTNvMFvFhGYQyKMJoLuOOAh2Bwlm5rAEkfsxzzS qU226FxKIM7W2WDmTF8QRanHaS+LtqLzShkBFSFIny/fk4J4IEdXgnznYCEWslTi7V4J 3md1YZeFQY3Pe3H1ZYtdPaQ1esqtKpED6CqWu1IVXEbRWSH5+kEFhd9LmdoZ0IIWFOa8 dsfzdIGLCeDbb+6EliCaeZOY02bXzj2WEUy7uto51yJTRdkW3Cp3mWelYfGfGBqctzo5 NveA== X-Gm-Message-State: AOJu0YzTSUubHn9hBEiVqbMP13fylzujB4ZYUbzwMpJU4LWvW4Atn4O1 XkEpNj9Mbkv5ir+vlpJMdSkMSO4FOZhtpRTuusC2rQ== X-Google-Smtp-Source: AGHT+IEEA27cMKPxiT9QEQ1J5nsOcdDDBHlRA5b3j1Kp8OUhW1c08f9q3mlhxuitZjHA+NPWSGj56A== X-Received: by 2002:a05:6a20:394a:b0:13e:904b:5f8 with SMTP id r10-20020a056a20394a00b0013e904b05f8mr144299pzg.61.1691516143330; Tue, 08 Aug 2023 10:35:43 -0700 (PDT) Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207]) by smtp.gmail.com with ESMTPSA id m13-20020aa7900d000000b00682562bf479sm8328945pfo.53.2023.08.08.10.35.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 10:35:42 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Reshma Pattan Subject: [PATCH 05/20] pdump: make API's stable Date: Tue, 8 Aug 2023 10:35:12 -0700 Message-Id: <20230808173527.186042-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230808173527.186042-1-stephen@networkplumber.org> References: <20230808173527.186042-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The filtering API's were added in 23.11 and can now be marked as not experimental. Signed-off-by: Stephen Hemminger --- lib/pdump/rte_pdump.h | 12 ------------ lib/pdump/version.map | 11 +++-------- 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/lib/pdump/rte_pdump.h b/lib/pdump/rte_pdump.h index b1a391830c1d..414931a12cce 100644 --- a/lib/pdump/rte_pdump.h +++ b/lib/pdump/rte_pdump.h @@ -83,9 +83,6 @@ rte_pdump_enable(uint16_t port, uint16_t queue, uint32_t flags, void *filter); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Enables packet capturing on given port and queue with filtering. * * @param port_id @@ -109,7 +106,6 @@ rte_pdump_enable(uint16_t port, uint16_t queue, uint32_t flags, * @return * 0 on success, -1 on error, rte_errno is set accordingly. */ -__rte_experimental int rte_pdump_enable_bpf(uint16_t port_id, uint16_t queue, uint32_t flags, uint32_t snaplen, @@ -169,9 +165,6 @@ rte_pdump_enable_by_deviceid(char *device_id, uint16_t queue, void *filter); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Enables packet capturing on given device id and queue with filtering. * device_id can be name or pci address of device. * @@ -196,7 +189,6 @@ rte_pdump_enable_by_deviceid(char *device_id, uint16_t queue, * @return * 0 on success, -1 on error, rte_errno is set accordingly. */ -__rte_experimental int rte_pdump_enable_bpf_by_deviceid(const char *device_id, uint16_t queue, uint32_t flags, uint32_t snaplen, @@ -242,9 +234,6 @@ struct rte_pdump_stats { }; /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Retrieve the packet capture statistics for a queue. * * @param port_id @@ -254,7 +243,6 @@ struct rte_pdump_stats { * @return * Zero if successful. -1 on error and rte_errno is set. */ -__rte_experimental int rte_pdump_stats(uint16_t port_id, struct rte_pdump_stats *stats); diff --git a/lib/pdump/version.map b/lib/pdump/version.map index 225830dc85a7..ea5bd157cdb1 100644 --- a/lib/pdump/version.map +++ b/lib/pdump/version.map @@ -4,17 +4,12 @@ DPDK_24 { rte_pdump_disable; rte_pdump_disable_by_deviceid; rte_pdump_enable; + rte_pdump_enable_bpf; + rte_pdump_enable_bpf_by_deviceid; rte_pdump_enable_by_deviceid; rte_pdump_init; + rte_pdump_stats; rte_pdump_uninit; local: *; }; - -EXPERIMENTAL { - global: - - rte_pdump_enable_bpf; - rte_pdump_enable_bpf_by_deviceid; - rte_pdump_stats; -};