From patchwork Wed Aug 9 00:09:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 129970 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B2DA43011; Wed, 9 Aug 2023 02:11:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3C50743265; Wed, 9 Aug 2023 02:10:36 +0200 (CEST) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id DB1CC43269 for ; Wed, 9 Aug 2023 02:10:33 +0200 (CEST) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1bbf8cb61aeso41263105ad.2 for ; Tue, 08 Aug 2023 17:10:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1691539833; x=1692144633; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Xn81oAq1m1gfdSq2LkJzwfUYnEjF85fpIDHQS1AtQuY=; b=CpYpUHcitsr5kMv9UHpJtKO9KZTgZBAjdL+NKlPnVJN1hP9Cc3UW5dg0CrEdV20KYM pk5dflisq2LzKdiPMBYeGclDtN2kXj4CZYy41gXDMk97PdcY8oDNzB9VXKaRyNR7lcxM AqysrXIdc30UOIJJ7O9G6pQkb5H2qw285/h8dErufXvxN+egjL1+sv6w48FG3cMZ6Qs+ zKT6oCopqsSlhHEThPYqrUMUZwWPvB+58aJ2Oej0S4emjl+LG+Q5YBFlwNprLgKAiejm mJS2lIq9mlX2YFKkxow4uAuihjcFqfTDj+F/vGYAJApFwBtuHbfK8hjrpORUfHxKtklY 47yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691539833; x=1692144633; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Xn81oAq1m1gfdSq2LkJzwfUYnEjF85fpIDHQS1AtQuY=; b=FhAqMlF6wuOIR1uR5p0VXPDvIYst27Hk8Jaka6GnM13qhtSWEhLtXioHq2b/8d1ZLq H5+biKbqK9Op/8iWy1VIec2c+rpfUtR8EFa9Ok1alpstObfQRxO5TJv+G9MzimC9oGRn O9UBbRDSzecKcf3qYwQ5iS+hisXV5RBhVui6Ngfe+9H2K+WIiOFbNfHHwojKSF68VAQB AKlYIyoL+6kOZHVEM72ei/rn5w9cijF43oVCQY5HJcjdh8fIiQelot0vY99vfn0dAOUc FSy8jyeRctxLotjm4uxM5hyvKMAZN74Ua48JM/50ATqepiDPpH6QbBNWDg5vt0j+UQzL 4X8A== X-Gm-Message-State: AOJu0Yz0oZKsRc7tjKiB7vBzvKh0jVnQIuSjSuJQTexw0ISxODjSys00 /Ga5RXZr811LIly0RK+f6z46SbRCOLpwFO+IscbwBA== X-Google-Smtp-Source: AGHT+IFu1rV6Qur0uZYYmIoOoEk2FBgfAYywRb6on7KOacG+inq0463qjHeXlJ/PcKoL4pEk5FzJJA== X-Received: by 2002:a17:903:2283:b0:1b8:1b79:a78c with SMTP id b3-20020a170903228300b001b81b79a78cmr1257120plh.44.1691539832898; Tue, 08 Aug 2023 17:10:32 -0700 (PDT) Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207]) by smtp.gmail.com with ESMTPSA id ix11-20020a170902f80b00b001bc676df6a9sm5745629plb.132.2023.08.08.17.10.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Aug 2023 17:10:32 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Reshma Pattan Subject: [PATCH v2 05/29] pdump: make API's stable Date: Tue, 8 Aug 2023 17:09:53 -0700 Message-Id: <20230809001017.293037-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230809001017.293037-1-stephen@networkplumber.org> References: <20230808173527.186042-1-stephen@networkplumber.org> <20230809001017.293037-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The filtering API's were added in 23.11 and can now be marked as not experimental. Signed-off-by: Stephen Hemminger --- lib/pdump/rte_pdump.h | 12 ------------ lib/pdump/version.map | 11 +++-------- 2 files changed, 3 insertions(+), 20 deletions(-) diff --git a/lib/pdump/rte_pdump.h b/lib/pdump/rte_pdump.h index b1a391830c1d..414931a12cce 100644 --- a/lib/pdump/rte_pdump.h +++ b/lib/pdump/rte_pdump.h @@ -83,9 +83,6 @@ rte_pdump_enable(uint16_t port, uint16_t queue, uint32_t flags, void *filter); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Enables packet capturing on given port and queue with filtering. * * @param port_id @@ -109,7 +106,6 @@ rte_pdump_enable(uint16_t port, uint16_t queue, uint32_t flags, * @return * 0 on success, -1 on error, rte_errno is set accordingly. */ -__rte_experimental int rte_pdump_enable_bpf(uint16_t port_id, uint16_t queue, uint32_t flags, uint32_t snaplen, @@ -169,9 +165,6 @@ rte_pdump_enable_by_deviceid(char *device_id, uint16_t queue, void *filter); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Enables packet capturing on given device id and queue with filtering. * device_id can be name or pci address of device. * @@ -196,7 +189,6 @@ rte_pdump_enable_by_deviceid(char *device_id, uint16_t queue, * @return * 0 on success, -1 on error, rte_errno is set accordingly. */ -__rte_experimental int rte_pdump_enable_bpf_by_deviceid(const char *device_id, uint16_t queue, uint32_t flags, uint32_t snaplen, @@ -242,9 +234,6 @@ struct rte_pdump_stats { }; /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Retrieve the packet capture statistics for a queue. * * @param port_id @@ -254,7 +243,6 @@ struct rte_pdump_stats { * @return * Zero if successful. -1 on error and rte_errno is set. */ -__rte_experimental int rte_pdump_stats(uint16_t port_id, struct rte_pdump_stats *stats); diff --git a/lib/pdump/version.map b/lib/pdump/version.map index 225830dc85a7..ea5bd157cdb1 100644 --- a/lib/pdump/version.map +++ b/lib/pdump/version.map @@ -4,17 +4,12 @@ DPDK_24 { rte_pdump_disable; rte_pdump_disable_by_deviceid; rte_pdump_enable; + rte_pdump_enable_bpf; + rte_pdump_enable_bpf_by_deviceid; rte_pdump_enable_by_deviceid; rte_pdump_init; + rte_pdump_stats; rte_pdump_uninit; local: *; }; - -EXPERIMENTAL { - global: - - rte_pdump_enable_bpf; - rte_pdump_enable_bpf_by_deviceid; - rte_pdump_stats; -};