From patchwork Wed Aug 9 01:33:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wenjing Qiao X-Patchwork-Id: 130005 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E39F43011; Wed, 9 Aug 2023 03:34:38 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3842E43282; Wed, 9 Aug 2023 03:33:52 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id E1E3543280 for ; Wed, 9 Aug 2023 03:33:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691544831; x=1723080831; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=40y6DRRbJimk3AyYJY/gG8jY7gO6PYDjliu4C/JYF0E=; b=ibMX8lgNGe7A/qrtwgUb58Uf9vIJ4N1K0YhvtZjaB7UYNrNFluXiZVA9 zH0ZYRY0EZrDFdFMkGjp31ixGD/GE0uqU8mH8bvOtvw77Z8nVtHu1g4mx GWQQKvJinz0Z2OQoLydG6lZs6PVlad0CDc8Zyy2rN2YvbQX8nFt5euUAT DqBjYXngc0Q9R+rg7vdP8tzIqxi7EzEBadPfgP6pWKQlZANOO0Y7fnmWP Q9Tb3Rq064m9qR0nN5RmMRKMcvvhaj6KGeyeA67KILpVIslUs/y0kwOIp tPQaFccr6ZDpeJtZ4PVpplfRcMbUXRTW0tlnHlVJwnPLh/8K3WluovF2n w==; X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="374704509" X-IronPort-AV: E=Sophos;i="6.01,157,1684825200"; d="scan'208";a="374704509" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Aug 2023 18:33:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10795"; a="845735152" X-IronPort-AV: E=Sophos;i="6.01,157,1684825200"; d="scan'208";a="845735152" Received: from dpdk-wenjing-02.sh.intel.com ([10.67.119.75]) by fmsmga002.fm.intel.com with ESMTP; 08 Aug 2023 18:33:48 -0700 From: Wenjing Qiao To: jingjing.wu@intel.com, beilei.xing@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org, mingxia.liu@intel.com, wenjing.qiao@intel.com, Simei Su , Pavan Kumar Linga Subject: [PATCH 11/14] common/idpf/base: refactor descriptor 'ret val' stripping Date: Wed, 9 Aug 2023 01:33:05 +0000 Message-Id: <20230809013308.1449103-12-wenjing.qiao@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230809013308.1449103-1-wenjing.qiao@intel.com> References: <20230809013308.1449103-1-wenjing.qiao@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Simei Su Conditional check is not necessary to strip and get status bits from the descriptor. Signed-off-by: Pavan Kumar Linga Signed-off-by: Simei Su --- drivers/common/idpf/base/idpf_controlq.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/common/idpf/base/idpf_controlq.c b/drivers/common/idpf/base/idpf_controlq.c index 7b12dfab18..da5c930578 100644 --- a/drivers/common/idpf/base/idpf_controlq.c +++ b/drivers/common/idpf/base/idpf_controlq.c @@ -426,11 +426,8 @@ static int __idpf_ctlq_clean_sq(struct idpf_ctlq_info *cq, u16 *clean_count, if (!force && !(LE16_TO_CPU(desc->flags) & IDPF_CTLQ_FLAG_DD)) break; - desc_err = LE16_TO_CPU(desc->ret_val); - if (desc_err) { - /* strip off FW internal code */ - desc_err &= 0xff; - } + /* strip off FW internal code */ + desc_err = LE16_TO_CPU(desc->ret_val) & 0xff; msg_status[i] = cq->bi.tx_msg[ntc]; if (!msg_status[i])