From patchwork Thu Aug 10 06:00:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: jhascoet X-Patchwork-Id: 130089 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26AE54302B; Thu, 10 Aug 2023 17:07:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F365A40DFB; Thu, 10 Aug 2023 17:07:09 +0200 (CEST) Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by mails.dpdk.org (Postfix) with ESMTP id 76E10406B6 for ; Thu, 10 Aug 2023 08:00:34 +0200 (CEST) Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-523100882f2so592912a12.2 for ; Wed, 09 Aug 2023 23:00:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1691647234; x=1692252034; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=d9Q09I0LtHFmXf2vFpeusB0iurOxqBmRKJhdrl0c+rk=; b=JC9CEduE6eG1jwpmT3HsOFRggWE6DiAKaR2E3hVgVc2VRR4lmMmAoo2BeWWQKRhbYP qBWngOWNJYm36SImziPVJfhbNuywgmD0nDUbr4X8q0jFKYMz4wOmJO+VUaQSsNB2YRa5 0PLIB8MvUeQzp67i1lmYOKa2FQj/+eL6bqzomOs7eZmKNZ48qpCPmldvRjXH1tpT4D5T SEMOk1FvkydS+zmNn06BH3WZLcv84rpxv0eSXjWMEJDkRfKXLipTgiMZtJtFIg+irHIf P6lA1rqJk/QhlzbN6TdNp+gJmztZuA2nIOWguEGwpZkNEUAoL9E8v4fLMUmevy4Gm7RC nHtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691647234; x=1692252034; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d9Q09I0LtHFmXf2vFpeusB0iurOxqBmRKJhdrl0c+rk=; b=ESXNBH2/F9c2LqYTt7z1bu3880XnRTPOi0+dRsE8gBElSrxkVf/y7UkbLqk7NwMGXF Cd520DgzDHq8BDyWUyDdnXNBUiWLJ5+jjclv0ZQ/Gf0ApgPzHBRPpP18PXYy8vYlL3en 3mRHcxxagKuzoFX6frSngw95p30f+uM25U9lX5+0kBBQPSzAZBMmuCfi7DBEsTbKO8JU vapJkfHsU63rW4qEVioSC/4vffzjRBfDY/Rf+fCju5zFQaV/T9cvLoP9b3gCX8OlZa9u QzWBn+K+Fjl/fL6+9P2GbrrVf/Assr7R3+At+UVvG4Sma5jRSpuA3iduw1EHYgI1lRtk lGag== X-Gm-Message-State: AOJu0Yx3DrEr15djuz+R2BRG3ZxGQ6OIWh/V8eXyzqO1BmgEtKVgcjls bLdVcbOdLLttdm+nwVIkKrU= X-Google-Smtp-Source: AGHT+IGPSCxDCkZAa/apZODZxd7pA0BnPDAnSjQjPCxeThX4lW1V2Y7FV939IHlnPKlK90f5xo7gYg== X-Received: by 2002:a50:fa84:0:b0:522:2711:863 with SMTP id w4-20020a50fa84000000b0052227110863mr1326766edr.1.1691647233781; Wed, 09 Aug 2023 23:00:33 -0700 (PDT) Received: from coolup54.lin.mbt.kalray.eu ([217.181.231.53]) by smtp.gmail.com with ESMTPSA id bf20-20020a0564021a5400b0051d9dbf5edfsm358382edb.55.2023.08.09.23.00.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Aug 2023 23:00:33 -0700 (PDT) From: jhascoet X-Google-Original-From: jhascoet To: david.marchand@redhat.com Cc: dev@dpdk.org, Julien Hascoet Subject: [PATCH] app: fix silent enqueue fail in test_mbuf test_refcnt_iter Date: Thu, 10 Aug 2023 08:00:30 +0200 Message-Id: <20230810060030.3759835-1-jhascoet@kalray.eu> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230809053843.3698537-1-jhascoet@kalray.eu> References: <20230809053843.3698537-1-jhascoet@kalray.eu> MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 10 Aug 2023 17:07:08 +0200 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Julien Hascoet In case of ring full state, we retry the enqueue operation in order to avoid mbuf loss. Fixes: af75078fece ("first public release") Signed-off-by: Julien Hascoet --- app/test/test_mbuf.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index efac01806b..be114e3302 100644 --- a/app/test/test_mbuf.c +++ b/app/test/test_mbuf.c @@ -1033,12 +1033,17 @@ test_refcnt_iter(unsigned int lcore, unsigned int iter, tref += ref; if ((ref & 1) != 0) { rte_pktmbuf_refcnt_update(m, ref); - while (ref-- != 0) - rte_ring_enqueue(refcnt_mbuf_ring, m); + while (ref-- != 0) { + /* retry in case of failure */ + while (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0) + ; + } } else { while (ref-- != 0) { rte_pktmbuf_refcnt_update(m, 1); - rte_ring_enqueue(refcnt_mbuf_ring, m); + /* retry in case of failure */ + while (rte_ring_enqueue(refcnt_mbuf_ring, m) != 0) + ; } } rte_pktmbuf_free(m);