From patchwork Mon Aug 14 16:31:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 130286 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 88CE243066; Mon, 14 Aug 2023 18:31:51 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC48F432B1; Mon, 14 Aug 2023 18:31:40 +0200 (CEST) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 18CA843270 for ; Mon, 14 Aug 2023 18:31:39 +0200 (CEST) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1bdef6f5449so4760055ad.3 for ; Mon, 14 Aug 2023 09:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1692030698; x=1692635498; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zIjbnS0VA7c/0TNibr+87iA48OVWwN8D8hQ1p/gnmpk=; b=Naq/NRkzy1JzWyIWuP4W+fHA4EjPEdFn8dnbJuBrG4ZkFzsZ/BTX8euLXDOGe2ja+g NLj7J8OzFK/Uy3K6NINL464L86QYe9gonvrQETmpSCxeHbIN/fIheG1MhQ5GDed/j6Cx EB5nvAqny0mEUu3XS4zHT04wz1VlTubZG/rOGpsX+UdTmDw1xw7AjDGwjvUZC+2m8oKd eTZbzHwdPVH2RFMT8XgJLWu8cOTR31vB7UjgI2WwFp+2hWFjJb1ThMXw/AqsVzzn0YYI CdoCWY490hxeR08xiXtNodCEDwFtJG5cSWNCqLD3rx+bJqAWJRSUQcpnYIWYigCVN+tn JLNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692030698; x=1692635498; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zIjbnS0VA7c/0TNibr+87iA48OVWwN8D8hQ1p/gnmpk=; b=SYE4y363gxSOVuY1H31T4UA31ChweO9Q3UaKJQVPM5bmqpBnmljVAL6TX4fJlCG6HV LB2HkOEwEpgiXYFSR8U4qwvPLECU240c0uwZpK1E+MIO/uysMpkq+Eh5BKQLEI5TW8H8 9OYw0IlxO8bQhkMHvBgnP6hymLqVhrVZu4g1gmxau4zyh6iCayw7oLPy1bY9gwgACoN8 ZNguwJ7WEwkJJTnLtj+xEoITuycDvsrFH78/wCA/TeOZrkKDcg8ey2YY/lWnsQ6jI/F5 VuRiItAPWTe/xs9X9B+HpZFFE6mMPelcwk4CNaBrusj0O4Ssshgz4ww8DYXM8o2svOHx B7sA== X-Gm-Message-State: AOJu0YwlFAzsoiNb9q6qBKZ/MC1mPP9b/WGzaIvnal4gQuqdVtrdnt1L LZwt2eDf7zrtaBDUVtiHFuQsa1zOd7qZ0+Y6Dv2miL8EtvM= X-Google-Smtp-Source: AGHT+IHuMT39b5AurogduqnVR99aFDzkNVbn8/0P/owYu3LPyfme/ijzytWkO7L37X8RsZdXSYVzrQ== X-Received: by 2002:a17:902:7241:b0:1bb:961e:dfbc with SMTP id c1-20020a170902724100b001bb961edfbcmr9254558pll.20.1692030698043; Mon, 14 Aug 2023 09:31:38 -0700 (PDT) Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207]) by smtp.gmail.com with ESMTPSA id t10-20020a170902bc4a00b001bdd51748f8sm3892743plz.271.2023.08.14.09.31.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Aug 2023 09:31:37 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , sergio.gonzalez.monroy@intel.com, Volodymyr Fialko , Reshma Pattan , Neil Horman , Richardson Bruce , Declan Doherty Subject: [PATCH v8 2/6] reorder: use a dynamic logtype Date: Mon, 14 Aug 2023 09:31:21 -0700 Message-Id: <20230814163125.63033-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230814163125.63033-1-stephen@networkplumber.org> References: <20230208044825.1682620-1-stephen@networkplumber.org> <20230814163125.63033-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Libraries should not be reusing RTE_LOGTYPE_USER1 instead of doing proper logtype registration. Fixes: b70b56032bff ("reorder: new library") Cc: sergio.gonzalez.monroy@intel.com Signed-off-by: Stephen Hemminger Acked-by: Volodymyr Fialko --- lib/reorder/rte_reorder.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c index b5428d1f7bfa..640719c3ecf9 100644 --- a/lib/reorder/rte_reorder.c +++ b/lib/reorder/rte_reorder.c @@ -16,6 +16,9 @@ #include "rte_reorder.h" +RTE_LOG_REGISTER_DEFAULT(reorder_logtype, INFO); +#define RTE_LOGTYPE_REORDER reorder_logtype + TAILQ_HEAD(rte_reorder_list, rte_tailq_entry); static struct rte_tailq_elem rte_reorder_tailq = { @@ -27,9 +30,6 @@ EAL_REGISTER_TAILQ(rte_reorder_tailq) #define RTE_REORDER_PREFIX "RO_" #define RTE_REORDER_NAMESIZE 32 -/* Macros for printing using RTE_LOG */ -#define RTE_LOGTYPE_REORDER RTE_LOGTYPE_USER1 - #define RTE_REORDER_SEQN_DYNFIELD_NAME "rte_reorder_seqn_dynfield" int rte_reorder_seqn_dynfield_offset = -1;