From patchwork Fri Aug 18 02:52:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 130488 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92DB641B5F; Fri, 18 Aug 2023 04:53:28 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 581DE4326A; Fri, 18 Aug 2023 04:53:08 +0200 (CEST) Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by mails.dpdk.org (Postfix) with ESMTP id 1695643255 for ; Fri, 18 Aug 2023 04:53:05 +0200 (CEST) Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-6bcbb0c40b1so450000a34.3 for ; Thu, 17 Aug 2023 19:53:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1692327184; x=1692931984; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1fhoi+hcR6PauwynPbCXhE7OxxF0DCkS+TarCv4n564=; b=PTnWl4D8hDitRSai6AcgpYY1lcXw5r/w12r6GskrwBGbwMbrmc6mlyCYB+xbTTQPZc np9OWrJSpG5Wg8E5PnFRW5wXsdLDJANgfcz1xshlbfrWOtjQB1YqSgRCg1CCEF8ck/Q6 sIarvOfmLnEJhnZuJdOO+vVG1Nxk5o8XIZcP6pQztHLwfvveflugZTP3cEwfvbVhUFmA 02baalpi+Fjd0Ev9SIU0A5cf4qbGV9I+bHqWton/Vk4jXa113zupJENA1mpbCMx41kku 6CwPmE9hKK70s56SvvMOcthhkQJkDMb8N3JRv5Ls/LG6P7rvzo5mRfPEnjzTB3H7VAdP twjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692327184; x=1692931984; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1fhoi+hcR6PauwynPbCXhE7OxxF0DCkS+TarCv4n564=; b=EsSPzitxayGc7PSn4Cq6orJwSZXGGWmVOw/O2/n0BLUj7GEAsx6WytjVk1osFrRVwG zzrmTRV1MrbeK/tJaUGuQG7Mn3TdisIvBJ7XCFo++veRlJcXboa1vGm0BDfpbBg0BnFH SBElXpGI7MIbzVkB6X3L3VrYyZwqeEza8j+PPSc4qnrUXd98Vdv6jqJmsUKlOC987Ceg T9lMikIVxIwOJzexpDLVacX2fpN/cdqmB7NAV0yeDfxLmjIkxswP/9I6PAIwYnlukPlo 3mTiqJUU+uLr91MadNY33Hx2Vi0LFjd8pTag8zaQKjouGjj1TiGv5GA+duz3LXUuQgma whtQ== X-Gm-Message-State: AOJu0YwoZXMWThuSVv18NWX3gyBpn2tmEtgtmWZZc55+DgRVbVX+yQQu EDdx3X/5iAYqduP5UgE2zc1J4QzeyJe//mnfwaBhmg== X-Google-Smtp-Source: AGHT+IEO6/YK3it/2xbx25dX/wHt+lWs9ZpkOx27uul1IGD8a9oVBuqH29TRTcxMBoEgU24X9NiWEQ== X-Received: by 2002:a05:6871:707:b0:1be:ffae:29a4 with SMTP id f7-20020a056871070700b001beffae29a4mr1514961oap.26.1692327184039; Thu, 17 Aug 2023 19:53:04 -0700 (PDT) Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207]) by smtp.gmail.com with ESMTPSA id ep13-20020a17090ae64d00b00262e485156esm2221246pjb.57.2023.08.17.19.53.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Aug 2023 19:53:03 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jochen Behrens Subject: [PATCH 04/14] net/vmxnet3: replace abort() with rte_panic() Date: Thu, 17 Aug 2023 19:52:39 -0700 Message-Id: <20230818025249.33994-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230818025249.33994-1-stephen@networkplumber.org> References: <20230818025249.33994-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Do the same thing but be better about wording. Signed-off-by: Stephen Hemminger --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c index 380f41f98be2..98bdd6523a4e 100644 --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c @@ -565,9 +565,8 @@ vmxnet3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, dgram_cksum); break; default: - PMD_TX_LOG(WARNING, "requested cksum offload not supported %#llx", - txm->ol_flags & RTE_MBUF_F_TX_L4_MASK); - abort(); + /* should probably count as tx error and drop instead */ + rte_panic("unsupported cksum offload: %#llx\n", txm->ol_flags); } deferred++; } else {