From patchwork Fri Aug 18 17:45:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 130529 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D5BE94309A; Fri, 18 Aug 2023 19:47:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45CFD43261; Fri, 18 Aug 2023 19:46:52 +0200 (CEST) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id A27764324F for ; Fri, 18 Aug 2023 19:46:48 +0200 (CEST) Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-6889288a31fso829562b3a.1 for ; Fri, 18 Aug 2023 10:46:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1692380807; x=1692985607; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v140Igs8/O/MPbJDz/fW1i3xBzKpk7TOBh1N0xFCfXI=; b=fbcbSEa836IuKolugLSMDmFkSdLUYEfqCIBYDNlYnOqQTOWeZ1PnIK2sOe/yhPAtWR ZCd/s9WydCOCxFKbO3/cRrnwC1Wzm2dzOsgP8EK5dS7GSyQPnVz2tcTubx4/XBEfGzCQ xr+Af4i1HNl2rgH/FVevArDGgihYjecX3ZdNFa04O60ltw5Ckqn7jHlqxqpRsXtjgvTa 7ekuown4ZjkD8ReSNgTzIIwV3jOziEZLBfM+EAZS7K5W7xd3vzN63EC61lmep4Vr11yD sCQV2NbyQpe6Kn+NHZawlwXD/cgyRbndnoTrQN6CWnipi2cPn6On+Wq4X8H7m8UkcQMg EOmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692380807; x=1692985607; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v140Igs8/O/MPbJDz/fW1i3xBzKpk7TOBh1N0xFCfXI=; b=Ya+VGdqYxpsBfZvYuK+mxkUTdd64O1j4ZivkmBaWX6uv2BfTVj8djngFFzpg3mc5Sr 853Xm+YwyLb5CCuNeNUWmd8B0Oy8oXlQ2PNukl59l1OGkDqP6TO/IPs95LhPtZM9as+1 HnX9pIqgeZmFVqcUgywOxTPHK8nqgxlA8P0+G1sijB0ZwwGufDNPj2ZkrYte5BSbwBgV TgTXZYeiOmmUPySD5YI1P4mXMZps0WgvxRiqtnEVGri0rGQqQ7I4/IUKUjjf2W+iqBm1 gvn+PBjjJ9gfY3RPN1GQD7cMJgaO+3oHfMsKix3UbTIPvd3pXdPiqOOndmOy3fniY1df +aww== X-Gm-Message-State: AOJu0YxoI3bPP5fJrqJiqE2NPoRuqRnbFAE9u+A8cxIjKL0yt+eoYTXi wznWh7MovAjQYXssDv29C4ocRNoWz36fSKGAGO4pyA== X-Google-Smtp-Source: AGHT+IHvWVwuPSysTRZuV1DBxeP25CbO0ZC7u8TBWkHJtnK3a/xXJvXG9mO9g0lHs+C9QcU5Pawxqg== X-Received: by 2002:a05:6a20:3c92:b0:13e:90aa:8c8b with SMTP id b18-20020a056a203c9200b0013e90aa8c8bmr4191071pzj.4.1692380807471; Fri, 18 Aug 2023 10:46:47 -0700 (PDT) Received: from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207]) by smtp.gmail.com with ESMTPSA id u20-20020aa78394000000b0066a2e8431a0sm1804610pfm.183.2023.08.18.10.46.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Aug 2023 10:46:47 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jochen Behrens Subject: [PATCH v2 04/13] net/vmxnet3: replace abort() with rte_panic() Date: Fri, 18 Aug 2023 10:45:28 -0700 Message-Id: <20230818174537.290222-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230818174537.290222-1-stephen@networkplumber.org> References: <20230818025249.33994-1-stephen@networkplumber.org> <20230818174537.290222-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Do the same thing but be better about wording. Signed-off-by: Stephen Hemminger --- drivers/net/vmxnet3/vmxnet3_rxtx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c index 380f41f98be2..695a1877185f 100644 --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c @@ -565,9 +565,9 @@ vmxnet3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, dgram_cksum); break; default: - PMD_TX_LOG(WARNING, "requested cksum offload not supported %#llx", - txm->ol_flags & RTE_MBUF_F_TX_L4_MASK); - abort(); + /* should probably count as tx error and drop instead */ + rte_panic("unsupported cksum offload: %"PRIx64"\n", + txm->ol_flags); } deferred++; } else {