diff mbox series

[2/3] test/event_crypto_adapter: skip unsupported test

Message ID 20230822131649.3509986-2-asasidharan@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series [1/3] event/cnxk: fix return values for capability API |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Aakash Sasidharan Aug. 22, 2023, 1:16 p.m. UTC 
Skip the test if rte_event_crypto_adapter_caps_get()
returns -ENOTSUP.

Signed-off-by: Aakash Sasidharan <asasidharan@marvell.com>
---
 app/test/test_event_crypto_adapter.c | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

Comments

Anoob Joseph Aug. 23, 2023, 4:01 a.m. UTC | #1 
> 
> Skip the test if rte_event_crypto_adapter_caps_get()
> returns -ENOTSUP.
> 
> Signed-off-by: Aakash Sasidharan <asasidharan@marvell.com>
> ---
>  app/test/test_event_crypto_adapter.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 

Acked-by: Anoob Joseph <anoobj@marvell.com>
Gujjar, Abhinandan S Aug. 23, 2023, 4:33 a.m. UTC | #2 
> -----Original Message-----
> From: Aakash Sasidharan <asasidharan@marvell.com>
> Sent: Tuesday, August 22, 2023 6:47 PM
> To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> Cc: jerinj@marvell.com; sthotton@marvell.com; anoobj@marvell.com;
> dev@dpdk.org; asasidharan@marvell.com
> Subject: [PATCH 2/3] test/event_crypto_adapter: skip unsupported test
> 
> Skip the test if rte_event_crypto_adapter_caps_get()
> returns -ENOTSUP.
> 
> Signed-off-by: Aakash Sasidharan <asasidharan@marvell.com>
> ---
>  app/test/test_event_crypto_adapter.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/app/test/test_event_crypto_adapter.c
> b/app/test/test_event_crypto_adapter.c
> index 24f66be69f..00b20fa443 100644
> --- a/app/test/test_event_crypto_adapter.c
> +++ b/app/test/test_event_crypto_adapter.c
> @@ -284,6 +284,9 @@ test_crypto_adapter_params(void)
>  	};
> 
>  	err = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> &cap);
> +	if (err == -ENOTSUP)
> +		return TEST_SKIPPED;
> +
>  	TEST_ASSERT_SUCCESS(err, "Failed to get adapter capabilities\n");
> 
>  	if (cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) { @@
> -1252,8 +1255,13 @@ test_crypto_adapter_create(void)
>  		.enqueue_depth = 8,
>  		.new_event_threshold = 1200,
>  	};
> +	uint32_t cap;
>  	int ret;
> 
> +	ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> &cap);
> +	if (ret == -ENOTSUP)
> +		return ret;
> +
rte_event_crypto_adapter_caps_get() is basic thing to check what is supported or not.
Not sure, purpose of this patch. Did you come across a case whether existing test was not working?
If so, please mention that in the patch commit.

>  	/* Create adapter with default port creation callback */
>  	ret = rte_event_crypto_adapter_create(TEST_ADAPTER_ID,
>  					      evdev,
> @@ -1274,6 +1282,9 @@ test_crypto_adapter_qp_add_del(void)
>  	int ret;
> 
>  	ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> &cap);
> +	if (ret == -ENOTSUP)
> +		return TEST_SKIPPED;
> +
>  	TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
> 
>  	if (cap &
> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) { @@
> -1309,6 +1320,9 @@ configure_event_crypto_adapter(enum
> rte_event_crypto_adapter_mode mode)
>  	int ret;
> 
>  	ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> &cap);
> +	if (ret == -ENOTSUP)
> +		return ret;
> +
>  	TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
> 
>  	/* Skip mode and capability mismatch check for SW eventdev */ @@
> -1475,6 +1489,9 @@ crypto_adapter_teardown(void)  {
>  	int ret;
> 
> +	if (!crypto_adapter_setup_done)
> +		return;
> +
>  	ret = rte_event_crypto_adapter_stop(TEST_ADAPTER_ID);
>  	if (ret < 0)
>  		RTE_LOG(ERR, USER1, "Failed to stop adapter!");
> --
> 2.25.1
Aakash Sasidharan Aug. 23, 2023, 7:48 a.m. UTC | #3 
Hi Abhinandan,

Please see inline.

> -----Original Message-----
> From: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> Sent: Wednesday, August 23, 2023 10:04 AM
> To: Aakash Sasidharan <asasidharan@marvell.com>
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Shijith Thotton
> <sthotton@marvell.com>; Anoob Joseph <anoobj@marvell.com>;
> dev@dpdk.org
> Subject: [EXT] RE: [PATCH 2/3] test/event_crypto_adapter: skip unsupported
> test
> 
> External Email
> 
> ----------------------------------------------------------------------
> 
> 
> > -----Original Message-----
> > From: Aakash Sasidharan <asasidharan@marvell.com>
> > Sent: Tuesday, August 22, 2023 6:47 PM
> > To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> > Cc: jerinj@marvell.com; sthotton@marvell.com; anoobj@marvell.com;
> > dev@dpdk.org; asasidharan@marvell.com
> > Subject: [PATCH 2/3] test/event_crypto_adapter: skip unsupported test
> >
> > Skip the test if rte_event_crypto_adapter_caps_get()
> > returns -ENOTSUP.
> >
> > Signed-off-by: Aakash Sasidharan <asasidharan@marvell.com>
> > ---
> >  app/test/test_event_crypto_adapter.c | 17 +++++++++++++++++
> >  1 file changed, 17 insertions(+)
> >
> > diff --git a/app/test/test_event_crypto_adapter.c
> > b/app/test/test_event_crypto_adapter.c
> > index 24f66be69f..00b20fa443 100644
> > --- a/app/test/test_event_crypto_adapter.c
> > +++ b/app/test/test_event_crypto_adapter.c
> > @@ -284,6 +284,9 @@ test_crypto_adapter_params(void)
> >  	};
> >
> >  	err = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> &cap);
> > +	if (err == -ENOTSUP)
> > +		return TEST_SKIPPED;
> > +
> >  	TEST_ASSERT_SUCCESS(err, "Failed to get adapter capabilities\n");
> >
> >  	if (cap &
> > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) {
> @@
> > -1252,8 +1255,13 @@ test_crypto_adapter_create(void)
> >  		.enqueue_depth = 8,
> >  		.new_event_threshold = 1200,
> >  	};
> > +	uint32_t cap;
> >  	int ret;
> >
> > +	ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> > &cap);
> > +	if (ret == -ENOTSUP)
> > +		return ret;
> > +
> rte_event_crypto_adapter_caps_get() is basic thing to check what is
> supported or not.
> Not sure, purpose of this patch. Did you come across a case whether existing
> test was not working?
> If so, please mention that in the patch commit.
> 
[Aakash] This is required for event_cnxk because it can support crypto adapter
only with crypto_cnxk and not with other cryptodevs.

> >  	/* Create adapter with default port creation callback */
> >  	ret = rte_event_crypto_adapter_create(TEST_ADAPTER_ID,
> >  					      evdev,
> > @@ -1274,6 +1282,9 @@ test_crypto_adapter_qp_add_del(void)
> >  	int ret;
> >
> >  	ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> &cap);
> > +	if (ret == -ENOTSUP)
> > +		return TEST_SKIPPED;
> > +
> >  	TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
> >
> >  	if (cap &
> > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) {
> @@
> > -1309,6 +1320,9 @@ configure_event_crypto_adapter(enum
> > rte_event_crypto_adapter_mode mode)
> >  	int ret;
> >
> >  	ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> &cap);
> > +	if (ret == -ENOTSUP)
> > +		return ret;
> > +
> >  	TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
> >
> >  	/* Skip mode and capability mismatch check for SW eventdev */ @@
> > -1475,6 +1489,9 @@ crypto_adapter_teardown(void)  {
> >  	int ret;
> >
> > +	if (!crypto_adapter_setup_done)
> > +		return;
> > +
> >  	ret = rte_event_crypto_adapter_stop(TEST_ADAPTER_ID);
> >  	if (ret < 0)
> >  		RTE_LOG(ERR, USER1, "Failed to stop adapter!");
> > --
> > 2.25.1
Aakash Sasidharan Aug. 23, 2023, 8:16 a.m. UTC | #4 
Hi Abhinandan,
 
Please see inline.

> -----Original Message-----
> From: Aakash Sasidharan
> Sent: Wednesday, August 23, 2023 1:18 PM
> To: 'Gujjar, Abhinandan S' <abhinandan.gujjar@intel.com>
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Shijith Thotton
> <sthotton@marvell.com>; Anoob Joseph <anoobj@marvell.com>;
> dev@dpdk.org
> Subject: RE: [PATCH 2/3] test/event_crypto_adapter: skip unsupported test
> 
> Hi Abhinandan,
> 
> Please see inline.
> 
> > -----Original Message-----
> > From: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> > Sent: Wednesday, August 23, 2023 10:04 AM
> > To: Aakash Sasidharan <asasidharan@marvell.com>
> > Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Shijith Thotton
> > <sthotton@marvell.com>; Anoob Joseph <anoobj@marvell.com>;
> > dev@dpdk.org
> > Subject: [EXT] RE: [PATCH 2/3] test/event_crypto_adapter: skip
> > unsupported test
> >
> > External Email
> >
> > ----------------------------------------------------------------------
> >
> >
> > > -----Original Message-----
> > > From: Aakash Sasidharan <asasidharan@marvell.com>
> > > Sent: Tuesday, August 22, 2023 6:47 PM
> > > To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> > > Cc: jerinj@marvell.com; sthotton@marvell.com; anoobj@marvell.com;
> > > dev@dpdk.org; asasidharan@marvell.com
> > > Subject: [PATCH 2/3] test/event_crypto_adapter: skip unsupported
> > > test
> > >
> > > Skip the test if rte_event_crypto_adapter_caps_get()
> > > returns -ENOTSUP.
> > >
> > > Signed-off-by: Aakash Sasidharan <asasidharan@marvell.com>
> > > ---
> > >  app/test/test_event_crypto_adapter.c | 17 +++++++++++++++++
> > >  1 file changed, 17 insertions(+)
> > >
> > > diff --git a/app/test/test_event_crypto_adapter.c
> > > b/app/test/test_event_crypto_adapter.c
> > > index 24f66be69f..00b20fa443 100644
> > > --- a/app/test/test_event_crypto_adapter.c
> > > +++ b/app/test/test_event_crypto_adapter.c
> > > @@ -284,6 +284,9 @@ test_crypto_adapter_params(void)
> > >  	};
> > >
> > >  	err = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> > &cap);
> > > +	if (err == -ENOTSUP)
> > > +		return TEST_SKIPPED;
> > > +
> > >  	TEST_ASSERT_SUCCESS(err, "Failed to get adapter capabilities\n");
> > >
> > >  	if (cap &
> > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) {
> > @@
> > > -1252,8 +1255,13 @@ test_crypto_adapter_create(void)
> > >  		.enqueue_depth = 8,
> > >  		.new_event_threshold = 1200,
> > >  	};
> > > +	uint32_t cap;
> > >  	int ret;
> > >
> > > +	ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> > > &cap);
> > > +	if (ret == -ENOTSUP)
> > > +		return ret;
> > > +
> > rte_event_crypto_adapter_caps_get() is basic thing to check what is
> > supported or not.
> > Not sure, purpose of this patch. Did you come across a case whether
> > existing test was not working?
> > If so, please mention that in the patch commit.
> >
> [Aakash] This is required for event_cnxk because it can support crypto
> adapter only with crypto_cnxk and not with other cryptodevs.
> 
[Aakash] Just clarifying, PMD may return -ENOTSUP if the event device that is compatible with
the specified crypto adapter is not available. Above check is to handle the same.

> > >  	/* Create adapter with default port creation callback */
> > >  	ret = rte_event_crypto_adapter_create(TEST_ADAPTER_ID,
> > >  					      evdev,
> > > @@ -1274,6 +1282,9 @@ test_crypto_adapter_qp_add_del(void)
> > >  	int ret;
> > >
> > >  	ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> > &cap);
> > > +	if (ret == -ENOTSUP)
> > > +		return TEST_SKIPPED;
> > > +
> > >  	TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
> > >
> > >  	if (cap &
> > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) {
> > @@
> > > -1309,6 +1320,9 @@ configure_event_crypto_adapter(enum
> > > rte_event_crypto_adapter_mode mode)
> > >  	int ret;
> > >
> > >  	ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> > &cap);
> > > +	if (ret == -ENOTSUP)
> > > +		return ret;
> > > +
> > >  	TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
> > >
> > >  	/* Skip mode and capability mismatch check for SW eventdev */ @@
> > > -1475,6 +1489,9 @@ crypto_adapter_teardown(void)  {
> > >  	int ret;
> > >
> > > +	if (!crypto_adapter_setup_done)
> > > +		return;
> > > +
> > >  	ret = rte_event_crypto_adapter_stop(TEST_ADAPTER_ID);
> > >  	if (ret < 0)
> > >  		RTE_LOG(ERR, USER1, "Failed to stop adapter!");
> > > --
> > > 2.25.1
Gujjar, Abhinandan S Aug. 23, 2023, 8:37 a.m. UTC | #5 
> -----Original Message-----
> From: Aakash Sasidharan <asasidharan@marvell.com>
> Sent: Wednesday, August 23, 2023 1:19 PM
> To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Shijith Thotton
> <sthotton@marvell.com>; Anoob Joseph <anoobj@marvell.com>;
> dev@dpdk.org
> Subject: RE: [PATCH 2/3] test/event_crypto_adapter: skip unsupported test
> 
> Hi Abhinandan,
> 
> Please see inline.
> 
> > -----Original Message-----
> > From: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> > Sent: Wednesday, August 23, 2023 10:04 AM
> > To: Aakash Sasidharan <asasidharan@marvell.com>
> > Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Shijith Thotton
> > <sthotton@marvell.com>; Anoob Joseph <anoobj@marvell.com>;
> > dev@dpdk.org
> > Subject: [EXT] RE: [PATCH 2/3] test/event_crypto_adapter: skip
> > unsupported test
> >
> > External Email
> >
> > ----------------------------------------------------------------------
> >
> >
> > > -----Original Message-----
> > > From: Aakash Sasidharan <asasidharan@marvell.com>
> > > Sent: Tuesday, August 22, 2023 6:47 PM
> > > To: Gujjar, Abhinandan S <abhinandan.gujjar@intel.com>
> > > Cc: jerinj@marvell.com; sthotton@marvell.com; anoobj@marvell.com;
> > > dev@dpdk.org; asasidharan@marvell.com
> > > Subject: [PATCH 2/3] test/event_crypto_adapter: skip unsupported
> > > test
> > >
> > > Skip the test if rte_event_crypto_adapter_caps_get()
> > > returns -ENOTSUP.
> > >
> > > Signed-off-by: Aakash Sasidharan <asasidharan@marvell.com>
> > > ---
> > >  app/test/test_event_crypto_adapter.c | 17 +++++++++++++++++
> > >  1 file changed, 17 insertions(+)
> > >
> > > diff --git a/app/test/test_event_crypto_adapter.c
> > > b/app/test/test_event_crypto_adapter.c
> > > index 24f66be69f..00b20fa443 100644
> > > --- a/app/test/test_event_crypto_adapter.c
> > > +++ b/app/test/test_event_crypto_adapter.c
> > > @@ -284,6 +284,9 @@ test_crypto_adapter_params(void)
> > >  	};
> > >
> > >  	err = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> > &cap);
> > > +	if (err == -ENOTSUP)
> > > +		return TEST_SKIPPED;
> > > +
> > >  	TEST_ASSERT_SUCCESS(err, "Failed to get adapter capabilities\n");
> > >
> > >  	if (cap &
> > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) {
> > @@
> > > -1252,8 +1255,13 @@ test_crypto_adapter_create(void)
> > >  		.enqueue_depth = 8,
> > >  		.new_event_threshold = 1200,
> > >  	};
> > > +	uint32_t cap;
> > >  	int ret;
> > >
> > > +	ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> > > &cap);
> > > +	if (ret == -ENOTSUP)
> > > +		return ret;
> > > +
> > rte_event_crypto_adapter_caps_get() is basic thing to check what is
> > supported or not.
> > Not sure, purpose of this patch. Did you come across a case whether
> > existing test was not working?
> > If so, please mention that in the patch commit.
> >
> [Aakash] This is required for event_cnxk because it can support crypto
> adapter only with crypto_cnxk and not with other cryptodevs.
Ok.

Acked-by: Abhinandan Gujjar <abhinandan.gujjar@intel.com>

> 
> > >  	/* Create adapter with default port creation callback */
> > >  	ret = rte_event_crypto_adapter_create(TEST_ADAPTER_ID,
> > >  					      evdev,
> > > @@ -1274,6 +1282,9 @@ test_crypto_adapter_qp_add_del(void)
> > >  	int ret;
> > >
> > >  	ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> > &cap);
> > > +	if (ret == -ENOTSUP)
> > > +		return TEST_SKIPPED;
> > > +
> > >  	TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
> > >
> > >  	if (cap &
> > > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) {
> > @@
> > > -1309,6 +1320,9 @@ configure_event_crypto_adapter(enum
> > > rte_event_crypto_adapter_mode mode)
> > >  	int ret;
> > >
> > >  	ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID,
> > &cap);
> > > +	if (ret == -ENOTSUP)
> > > +		return ret;
> > > +
> > >  	TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
> > >
> > >  	/* Skip mode and capability mismatch check for SW eventdev */ @@
> > > -1475,6 +1489,9 @@ crypto_adapter_teardown(void)  {
> > >  	int ret;
> > >
> > > +	if (!crypto_adapter_setup_done)
> > > +		return;
> > > +
> > >  	ret = rte_event_crypto_adapter_stop(TEST_ADAPTER_ID);
> > >  	if (ret < 0)
> > >  		RTE_LOG(ERR, USER1, "Failed to stop adapter!");
> > > --
> > > 2.25.1
diff mbox series

Patch

diff --git a/app/test/test_event_crypto_adapter.c b/app/test/test_event_crypto_adapter.c
index 24f66be69f..00b20fa443 100644
--- a/app/test/test_event_crypto_adapter.c
+++ b/app/test/test_event_crypto_adapter.c
@@ -284,6 +284,9 @@  test_crypto_adapter_params(void)
 	};
 
 	err = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, &cap);
+	if (err == -ENOTSUP)
+		return TEST_SKIPPED;
+
 	TEST_ASSERT_SUCCESS(err, "Failed to get adapter capabilities\n");
 
 	if (cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) {
@@ -1252,8 +1255,13 @@  test_crypto_adapter_create(void)
 		.enqueue_depth = 8,
 		.new_event_threshold = 1200,
 	};
+	uint32_t cap;
 	int ret;
 
+	ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, &cap);
+	if (ret == -ENOTSUP)
+		return ret;
+
 	/* Create adapter with default port creation callback */
 	ret = rte_event_crypto_adapter_create(TEST_ADAPTER_ID,
 					      evdev,
@@ -1274,6 +1282,9 @@  test_crypto_adapter_qp_add_del(void)
 	int ret;
 
 	ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, &cap);
+	if (ret == -ENOTSUP)
+		return TEST_SKIPPED;
+
 	TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
 
 	if (cap & RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) {
@@ -1309,6 +1320,9 @@  configure_event_crypto_adapter(enum rte_event_crypto_adapter_mode mode)
 	int ret;
 
 	ret = rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, &cap);
+	if (ret == -ENOTSUP)
+		return ret;
+
 	TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n");
 
 	/* Skip mode and capability mismatch check for SW eventdev */
@@ -1475,6 +1489,9 @@  crypto_adapter_teardown(void)
 {
 	int ret;
 
+	if (!crypto_adapter_setup_done)
+		return;
+
 	ret = rte_event_crypto_adapter_stop(TEST_ADAPTER_ID);
 	if (ret < 0)
 		RTE_LOG(ERR, USER1, "Failed to stop adapter!");