From patchwork Fri Aug 25 10:13:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simei Su X-Patchwork-Id: 130758 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B0ED430FF; Fri, 25 Aug 2023 12:14:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 61FFB4327B; Fri, 25 Aug 2023 12:14:14 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 96F3743276 for ; Fri, 25 Aug 2023 12:14:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692958452; x=1724494452; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=K6U4zzIIJ5pfU5YKkw2l5gTE0FwzYV/o33BF0pqN/iQ=; b=ST1zVRuWIEAsassed0seUCD424PfaEUm/tOgwiWaY+9Nu/iAaPB1ktpf 0j3gC7zlGcxuGJ5XeTAZxHiqgtSCoJZwsSy63EcEi72etrzn6VySdMQj8 HW1m8QtVcxUHCkDg+ZDTf/TtsSejuAW2PU6hBvGkwu1B4HkuOE4eQNqkT kZ4Gfra5ZDrRJRk5jpTRlWf+mgzqIAG9cAQ4eL6TXF1VSJfyKNBxEuncT RCcfheVm4c9tbFQCu+4q/1gLRVqMlgqRhlAuJtz2W7z6D5bbmU7xzAl5A 26EFw28fJAPNK1e9PUe6tE+6xR8uuYpGNIA/h5qfT+/zFHikG7mZOkh/h g==; X-IronPort-AV: E=McAfee;i="6600,9927,10812"; a="441028068" X-IronPort-AV: E=Sophos;i="6.02,195,1688454000"; d="scan'208";a="441028068" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2023 03:14:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10812"; a="772439728" X-IronPort-AV: E=Sophos;i="6.02,195,1688454000"; d="scan'208";a="772439728" Received: from dpdk-simei-icelake.sh.intel.com ([10.67.110.167]) by orsmga001.jf.intel.com with ESMTP; 25 Aug 2023 03:14:09 -0700 From: Simei Su To: jingjing.wu@intel.com, beilei.xing@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org, mingxia.liu@intel.com, wenjing.qiao@intel.com, Simei Su , Pavan Kumar Linga Subject: [PATCH v2 11/17] common/idpf/base: refactor descriptor 'ret val' stripping Date: Fri, 25 Aug 2023 18:13:38 +0800 Message-Id: <20230825101344.1828774-12-simei.su@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230825101344.1828774-1-simei.su@intel.com> References: <20230809013308.1449103-1-wenjing.qiao@intel.com> <20230825101344.1828774-1-simei.su@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Conditional check is not necessary to strip and get status bits from the descriptor. Signed-off-by: Pavan Kumar Linga Signed-off-by: Simei Su --- drivers/common/idpf/base/idpf_controlq.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/common/idpf/base/idpf_controlq.c b/drivers/common/idpf/base/idpf_controlq.c index 7b12dfab18..da5c930578 100644 --- a/drivers/common/idpf/base/idpf_controlq.c +++ b/drivers/common/idpf/base/idpf_controlq.c @@ -426,11 +426,8 @@ static int __idpf_ctlq_clean_sq(struct idpf_ctlq_info *cq, u16 *clean_count, if (!force && !(LE16_TO_CPU(desc->flags) & IDPF_CTLQ_FLAG_DD)) break; - desc_err = LE16_TO_CPU(desc->ret_val); - if (desc_err) { - /* strip off FW internal code */ - desc_err &= 0xff; - } + /* strip off FW internal code */ + desc_err = LE16_TO_CPU(desc->ret_val) & 0xff; msg_status[i] = cq->bi.tx_msg[ntc]; if (!msg_status[i])