From patchwork Fri Aug 25 10:13:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simei Su X-Patchwork-Id: 130753 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 195B0430FF; Fri, 25 Aug 2023 12:14:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6581743260; Fri, 25 Aug 2023 12:13:55 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 79BDA42D13 for ; Fri, 25 Aug 2023 12:13:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692958427; x=1724494427; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=2IZ95EFgtuBwWfZ2Cljxl8KUDlp8As5FUsoPz1UWklo=; b=PxNWwPBB0UEQDe31nXcQdXz7NvJjr/dcKa17j4Tb+JoRrm0atpO2dsdq QxbTQm1RD2iUhYkpFqP3Qww2bkn24oxNVAJ0mYh7/4H8RAhSMGLDL1KnP HsIMWHJSj/h53D6nSbBKvyoXEu7lcziowmQ8WJ7j5/CCViLnHd0wQMZRb ir+9ga/PpQA5IYW0gH+DjJfxBcploMoBRpJe9TIMrmsYXXZqqCr/OTiXQ 5zpXy3Fop9Zk6x8hV2eyrWfpk9TQOIvV6m+IXwlcGjeEzqcUt+qA/YDCS j3NhSamUM/0qKSOsXvRC6f+oOtEyiLHNx3JUGTzhk/itkswasKjimuC6G Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10812"; a="441027945" X-IronPort-AV: E=Sophos;i="6.02,195,1688454000"; d="scan'208";a="441027945" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Aug 2023 03:13:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10812"; a="772439499" X-IronPort-AV: E=Sophos;i="6.02,195,1688454000"; d="scan'208";a="772439499" Received: from dpdk-simei-icelake.sh.intel.com ([10.67.110.167]) by orsmga001.jf.intel.com with ESMTP; 25 Aug 2023 03:13:44 -0700 From: Simei Su To: jingjing.wu@intel.com, beilei.xing@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org, mingxia.liu@intel.com, wenjing.qiao@intel.com, Simei Su , Julianx Grajkowski Subject: [PATCH v2 06/17] common/idpf/base: add necessary check Date: Fri, 25 Aug 2023 18:13:33 +0800 Message-Id: <20230825101344.1828774-7-simei.su@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230825101344.1828774-1-simei.su@intel.com> References: <20230809013308.1449103-1-wenjing.qiao@intel.com> <20230825101344.1828774-1-simei.su@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add necessary check for payload and message buffer. Signed-off-by: Julianx Grajkowski Signed-off-by: Simei Su --- .mailmap | 1 + drivers/common/idpf/base/idpf_common.c | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap index 3879b5a33f..7400692544 100644 --- a/.mailmap +++ b/.mailmap @@ -1643,3 +1643,4 @@ Zhenning Xiao Josh Hay Madhu Chittim Shailendra Bhatnagar +Julianx Grajkowski diff --git a/drivers/common/idpf/base/idpf_common.c b/drivers/common/idpf/base/idpf_common.c index fbf71416fd..9610916aa9 100644 --- a/drivers/common/idpf/base/idpf_common.c +++ b/drivers/common/idpf/base/idpf_common.c @@ -239,8 +239,10 @@ int idpf_clean_arq_element(struct idpf_hw *hw, e->desc.ret_val = msg.status; e->desc.datalen = msg.data_len; if (msg.data_len > 0) { - if (!msg.ctx.indirect.payload) - return -EINVAL; + if (!msg.ctx.indirect.payload || !msg.ctx.indirect.payload->va || + !e->msg_buf) { + return -EFAULT; + } e->buf_len = msg.data_len; msg_data_len = msg.data_len; idpf_memcpy(e->msg_buf, msg.ctx.indirect.payload->va, msg_data_len,