From patchwork Wed Aug 30 15:59:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 130918 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DAFD41FD1; Wed, 30 Aug 2023 18:07:14 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB9DA42D6A; Wed, 30 Aug 2023 18:00:19 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 94187402E2; Wed, 30 Aug 2023 17:59:55 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1693411195; x=1724947195; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=Vaef2TE5CsJjJO1uxXTElcfWslXvx4sL2mIjJl2a884=; b=OsgSR5YxUBMEp5zq+WZah+Cx2xzST/SK+ItGhYdQsUsNEFw/xAf4z76W nzowNjzvCLLbokWislBjXL4DIytnNNfRdD0J8ljXf/2MwScpskkxLeEd7 F16YwVYLGxgkg7OWDu69b/rBcHH6o2iRYBFVF5WalWbcSbnENJSIsdc5+ /XU2RtoAWMumqA1OkQkbQS/Wjo2U+/oXIZr3nNLgsCdmfOoZgG/D9+Sgf O5c1IzBIkA/PhoUn0OTMsZ7R9hDmYZxHcOZ1f9CksgZ7xEua8qi4rWoE3 7tiJB4TinxijmJH8gsPbEPnuEB0Lx0F4NcRei5TsAveCET8+1fR0kg0Re Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10818"; a="360674204" X-IronPort-AV: E=Sophos;i="6.02,214,1688454000"; d="scan'208";a="360674204" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Aug 2023 08:59:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10818"; a="739142740" X-IronPort-AV: E=Sophos;i="6.02,214,1688454000"; d="scan'208";a="739142740" Received: from silpixa00401385.ir.intel.com ([10.237.214.14]) by orsmga002.jf.intel.com with ESMTP; 30 Aug 2023 08:59:53 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: Yuying Zhang , Beilei Xing , Jingjing Wu , Bruce Richardson , stable@dpdk.org Subject: [PATCH 3/4] net/iavf: fix restart of Rx queue on reconfigure Date: Wed, 30 Aug 2023 16:59:18 +0100 Message-Id: <20230830155919.592390-4-bruce.richardson@intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230830155919.592390-1-bruce.richardson@intel.com> References: <20230830155919.592390-1-bruce.richardson@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org After reconfiguring an RX queue the mbuf_initializer value was not being correctly set. Fix this by calling the appropriate function if vector processing is enabled. This mirrors the behaviour by the i40e driver. Fixes: 319c421f3890 ("net/avf: enable SSE Rx Tx") Cc: jingjing.wu@intel.com Cc: stable@dpdk.org Signed-off-by: Bruce Richardson --- drivers/net/iavf/iavf_rxtx.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c index f7df4665d1..347f686831 100644 --- a/drivers/net/iavf/iavf_rxtx.c +++ b/drivers/net/iavf/iavf_rxtx.c @@ -755,6 +755,12 @@ iavf_dev_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx, if (check_rx_vec_allow(rxq) == false) ad->rx_vec_allowed = false; + /* check vector conflict */ + if (ad->rx_vec_allowed && iavf_rxq_vec_setup(rxq)) { + PMD_DRV_LOG(ERR, "Failed vector rx setup."); + return -EINVAL; + } + return 0; }