From patchwork Tue Sep 5 16:39:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Nikhilesh Bhagavatula X-Patchwork-Id: 131179 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C5A22424F4; Tue, 5 Sep 2023 18:39:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A38AF40E78; Tue, 5 Sep 2023 18:39:19 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by mails.dpdk.org (Postfix) with ESMTP id 31C3E400D7 for ; Tue, 5 Sep 2023 18:39:18 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 385C6w1p026839 for ; Tue, 5 Sep 2023 09:39:17 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=pfpt0220; bh=tacWIsZdxJk/qZxjYmreA+IhUzHy8CEnzscK8bF0HO8=; b=Q6vHEVZ1qGJEBDLt7UWQvDSPDIxJi59R4NifP6B8K0BmaGDpJgrxAycE3RrGyY1N5oEP GI9fWZW7kwqU95xtB20Z4OjrLUK4loakzfEXNNET9Nd8DNNQU+c/z+W5EFDPX+JO0Ydn e6VdwFBg+dc/ekMQZfBysvwWulc0sQWmoSPxooKkYkAs2aR/b9DmAu3x2cSoUd804UpX qiTWg6dAPX3ClBz3Lw/OJfZtEEL9zxiQ0pZZnZd+vRS+cRERtHug9FNNvUjzYwYzoO3D lVx8iZJlcpKIlakKMxucWSUS/NdjQGcG7T9c8z3zO9HO2vcz4aB9FCCBDIDp6S/k56v/ rA== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3sv4jkaje0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Tue, 05 Sep 2023 09:39:17 -0700 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Tue, 5 Sep 2023 09:39:15 -0700 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Tue, 5 Sep 2023 09:39:15 -0700 Received: from MININT-80QBFE8.corp.innovium.com (MININT-80QBFE8.marvell.com [10.28.164.106]) by maili.marvell.com (Postfix) with ESMTP id D76CF3F7065; Tue, 5 Sep 2023 09:39:13 -0700 (PDT) From: To: , Pavan Nikhilesh , "Shijith Thotton" CC: Subject: [PATCH 2/3] event/cnxk: remove checks from op release Date: Tue, 5 Sep 2023 22:09:07 +0530 Message-ID: <20230905163908.19946-2-pbhagavatula@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230905163908.19946-1-pbhagavatula@marvell.com> References: <20230905163908.19946-1-pbhagavatula@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: K63YARG8ZTyeVM4cD2oouyBYs7H0MUMA X-Proofpoint-ORIG-GUID: K63YARG8ZTyeVM4cD2oouyBYs7H0MUMA X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.957,Hydra:6.0.601,FMLib:17.11.176.26 definitions=2023-09-05_10,2023-09-05_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Pavan Nikhilesh Remove expensive fastpath checks from op release, remove explicit release in CN9K tx routine. Signed-off-by: Pavan Nikhilesh --- drivers/event/cnxk/cn9k_worker.h | 17 ----------------- drivers/event/cnxk/cnxk_worker.h | 6 ------ 2 files changed, 23 deletions(-) diff --git a/drivers/event/cnxk/cn9k_worker.h b/drivers/event/cnxk/cn9k_worker.h index 9ddab095ac..ee659e80d6 100644 --- a/drivers/event/cnxk/cn9k_worker.h +++ b/drivers/event/cnxk/cn9k_worker.h @@ -156,15 +156,6 @@ cn9k_sso_hws_dual_forward_event(struct cn9k_sso_hws_dual *dws, uint64_t base, } } -static __rte_always_inline void -cn9k_sso_tx_tag_flush(uint64_t base) -{ - if (unlikely(CNXK_TT_FROM_TAG(plt_read64(base + SSOW_LF_GWS_TAG)) == - SSO_TT_EMPTY)) - return; - plt_write64(0, base + SSOW_LF_GWS_OP_SWTAG_FLUSH); -} - static __rte_always_inline void cn9k_wqe_to_mbuf(uint64_t wqe, const uint64_t mbuf, uint8_t port_id, const uint32_t tag, const uint32_t flags, @@ -727,7 +718,6 @@ cn9k_sso_hws_event_tx(uint64_t base, struct rte_event *ev, uint64_t *cmd, uint64_t *txq_data, const uint32_t flags) { struct rte_mbuf *m = ev->mbuf; - uint16_t ref_cnt = m->refcnt; struct cn9k_eth_txq *txq; /* Perform header writes before barrier for TSO */ @@ -800,13 +790,6 @@ cn9k_sso_hws_event_tx(uint64_t base, struct rte_event *ev, uint64_t *cmd, } done: - if (flags & NIX_TX_OFFLOAD_MBUF_NOFF_F) { - if (ref_cnt > 1) - return 1; - } - - cn9k_sso_tx_tag_flush(base); - return 1; } diff --git a/drivers/event/cnxk/cnxk_worker.h b/drivers/event/cnxk/cnxk_worker.h index 2bd41f8a5e..0e0d728ba4 100644 --- a/drivers/event/cnxk/cnxk_worker.h +++ b/drivers/event/cnxk/cnxk_worker.h @@ -54,12 +54,6 @@ cnxk_sso_hws_swtag_untag(uintptr_t swtag_untag_op) static __rte_always_inline void cnxk_sso_hws_swtag_flush(uint64_t base) { - /* Ensure that there is no previous flush is pending. */ - while (plt_read64(base + SSOW_LF_GWS_PENDSTATE) & BIT_ULL(56)) - ; - if (CNXK_TT_FROM_TAG(plt_read64(base + SSOW_LF_GWS_TAG)) == - SSO_TT_EMPTY) - return; plt_write64(0, base + SSOW_LF_GWS_OP_SWTAG_FLUSH); }