From patchwork Fri Sep 15 02:17:28 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simei Su X-Patchwork-Id: 131451 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5D4044259D; Fri, 15 Sep 2023 04:18:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6578140E03; Fri, 15 Sep 2023 04:17:19 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id 8DB9940E4A for ; Fri, 15 Sep 2023 04:17:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694744237; x=1726280237; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=DvkS7icNFXqLT20/6VpQCZ8UmjWxHtFbTLsSrCgkrRs=; b=njEUaoukjgu9a9Y3P+OU1SfoIVlK/h2ZJHR4MZaSG3lBO5HsCZ67ZlMH 0z9VBz7YcxABuSPSbRm1bwEVmds1CkFtXwn0+/+o2P2cTLbFiFDxGw2QD zB0C/836s2GLwgWjX0HJH/YHwhU+mx+PF4UerHS6tuzE5hj32VgLih6+B X/bugxt1p3cywuDT7k+7hmWnGTWFy/DHAzAvLRSk6n5kJvX0HAyKk5yTJ 8SFoCasTBjsTHZX/7zqJRS+tZiVGTNFdXK8C3/tZqBCrlU0lGdMFivaNq nuusfVU7rF+Xje2qEwybadB6PzL4gmvJtVx9sfMPupi25VS6cNiq+Fh3W A==; X-IronPort-AV: E=McAfee;i="6600,9927,10833"; a="410078002" X-IronPort-AV: E=Sophos;i="6.02,147,1688454000"; d="scan'208";a="410078002" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2023 19:17:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10833"; a="1075622841" X-IronPort-AV: E=Sophos;i="6.02,147,1688454000"; d="scan'208";a="1075622841" Received: from dpdk-simei-icelake.sh.intel.com ([10.67.110.167]) by fmsmga005.fm.intel.com with ESMTP; 14 Sep 2023 19:17:15 -0700 From: Simei Su To: jingjing.wu@intel.com, beilei.xing@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org, mingxia.liu@intel.com, wenjing.qiao@intel.com, Simei Su , Pavan Kumar Linga Subject: [PATCH v3 15/17] common/idpf/base: don't declare union with 'flex' Date: Fri, 15 Sep 2023 10:17:28 +0800 Message-Id: <20230915021730.2681882-16-simei.su@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230915021730.2681882-1-simei.su@intel.com> References: <20230825101344.1828774-1-simei.su@intel.com> <20230915021730.2681882-1-simei.su@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In idpf_flex_tx_desc structure, instead of naming the union with 'flex', use no name union as the union name is not really necessary there. This reduces the level of indirection in the hotpath. Signed-off-by: Pavan Kumar Linga Signed-off-by: Simei Su --- drivers/common/idpf/base/idpf_lan_txrx.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/common/idpf/base/idpf_lan_txrx.h b/drivers/common/idpf/base/idpf_lan_txrx.h index f213c49e47..1e19aeafac 100644 --- a/drivers/common/idpf/base/idpf_lan_txrx.h +++ b/drivers/common/idpf/base/idpf_lan_txrx.h @@ -226,11 +226,11 @@ enum idpf_tx_flex_desc_cmd_bits { struct idpf_flex_tx_desc { __le64 buf_addr; /* Packet buffer address */ struct { - __le16 cmd_dtype; #define IDPF_FLEX_TXD_QW1_DTYPE_S 0 #define IDPF_FLEX_TXD_QW1_DTYPE_M GENMASK(4, 0) #define IDPF_FLEX_TXD_QW1_CMD_S 5 #define IDPF_FLEX_TXD_QW1_CMD_M GENMASK(15, 5) + __le16 cmd_dtype; union { /* DTYPE = IDPF_TX_DESC_DTYPE_FLEX_DATA_(0x03) */ u8 raw[4]; @@ -247,7 +247,7 @@ struct idpf_flex_tx_desc { __le16 l2tag1; __le16 l2tag2; } l2tags; - } flex; + }; __le16 buf_size; } qw1; };