From patchwork Fri Sep 15 02:17:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simei Su X-Patchwork-Id: 131442 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 957454259D; Fri, 15 Sep 2023 04:17:33 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7EADC406B8; Fri, 15 Sep 2023 04:16:58 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id D765740685 for ; Fri, 15 Sep 2023 04:16:56 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694744217; x=1726280217; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=98RdeuJiB6CIOb6I2WK9JABZRx9inHDn4qiXOl9Q5Ys=; b=g4R4xaZlernI4JEPY4HNrWYwqnfOV6gHxW7JocPSmvnn/O5GrBFA7xhh No2JwbRn2Nbjy/g+VY4Hu2tKaMBNnSQe9Ov7BQoqg/BSP0t7YHRJodtDc N3mpwxEt5wV01PG1wzQ7QBOBGVW7TaMw3Jiu2TmMM5IRaDCfs/25gevDN yorSUSQs1dzwlDxZ+7q6Y0vOgbRr4OSUp260j92Z5l/dyS7pMCessqFK9 3siOF1+7iORJ8xNyqVI1Dito0XyseH7my6bMqsWd6pP84lylKOmi0yI8b htAyQhjwpSmj8cDRpwFirZ3EWgwpSmi3r7Ezy9B+7mfpLZhhCv4D+YI+v A==; X-IronPort-AV: E=McAfee;i="6600,9927,10833"; a="410077953" X-IronPort-AV: E=Sophos;i="6.02,147,1688454000"; d="scan'208";a="410077953" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2023 19:16:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10833"; a="1075622754" X-IronPort-AV: E=Sophos;i="6.02,147,1688454000"; d="scan'208";a="1075622754" Received: from dpdk-simei-icelake.sh.intel.com ([10.67.110.167]) by fmsmga005.fm.intel.com with ESMTP; 14 Sep 2023 19:16:54 -0700 From: Simei Su To: jingjing.wu@intel.com, beilei.xing@intel.com, qi.z.zhang@intel.com Cc: dev@dpdk.org, mingxia.liu@intel.com, wenjing.qiao@intel.com, Simei Su , Julianx Grajkowski Subject: [PATCH v3 06/17] common/idpf/base: add necessary check Date: Fri, 15 Sep 2023 10:17:19 +0800 Message-Id: <20230915021730.2681882-7-simei.su@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230915021730.2681882-1-simei.su@intel.com> References: <20230825101344.1828774-1-simei.su@intel.com> <20230915021730.2681882-1-simei.su@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add necessary check for payload and message buffer. Signed-off-by: Julianx Grajkowski Signed-off-by: Simei Su --- .mailmap | 1 + drivers/common/idpf/base/idpf_common.c | 6 ++++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap index 75d534c53d..23aed53102 100644 --- a/.mailmap +++ b/.mailmap @@ -1644,3 +1644,4 @@ Zhenning Xiao Josh Hay Madhu Chittim Shailendra Bhatnagar +Julianx Grajkowski diff --git a/drivers/common/idpf/base/idpf_common.c b/drivers/common/idpf/base/idpf_common.c index fbf71416fd..9610916aa9 100644 --- a/drivers/common/idpf/base/idpf_common.c +++ b/drivers/common/idpf/base/idpf_common.c @@ -239,8 +239,10 @@ int idpf_clean_arq_element(struct idpf_hw *hw, e->desc.ret_val = msg.status; e->desc.datalen = msg.data_len; if (msg.data_len > 0) { - if (!msg.ctx.indirect.payload) - return -EINVAL; + if (!msg.ctx.indirect.payload || !msg.ctx.indirect.payload->va || + !e->msg_buf) { + return -EFAULT; + } e->buf_len = msg.data_len; msg_data_len = msg.data_len; idpf_memcpy(e->msg_buf, msg.ctx.indirect.payload->va, msg_data_len,