From patchwork Wed Sep 20 12:52:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomer Shmilovich X-Patchwork-Id: 131727 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6565425F0; Wed, 20 Sep 2023 14:53:43 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 264EF427E6; Wed, 20 Sep 2023 14:53:33 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2058.outbound.protection.outlook.com [40.107.94.58]) by mails.dpdk.org (Postfix) with ESMTP id 8FCF2427E6 for ; Wed, 20 Sep 2023 14:53:31 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fhEpjwwhgynF6OtkEq/NUO8vsSnQQjJ0X8QF+s7Zm519eTBRADnJgLVQM7aZc2y4c1KBkjm7go3j7nep5VdvhSSWuTKqr6lhJiywAgy0bvNvY7EVd1aBM7G9NTqKQttx1enTyw39lAbWYek68034JkTZjXnnkRnjEd0+ZTvc0QnRu2xnXKstOpNAyQ5p2V7DF1uLtaqeYS0XOOmleIvONktQFl7dmx3uPx/QsVbXHGfHv00/dcS3iD70+4q6DtHllw5pT6YKq372GxhrXqMoEFAbqTwwmQU20MmLdZ4O1X6WARirHqxG62o50nDQXLFEQiFYbtkorQWR1TBfNDCLEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=XOLICeB5PWOUE5PVmYqYWDwFkt+e8ea+Lwq5XKyiQEo=; b=E85xgrC+DDWf+O75o1oy6EBMtAbN3oM/W0OWRkN9aWloWxZNX94nDfrpS+9aENScKu+0oi5jWmJCVg2OCg2Nzox52TQjlHDbqzOWeM67zq+8A4b30IatUMIpCcJl34B1GnsDjD0f7FGEp2k1VQhwj2jX0HySUjQb/1ciO0gydrT8PV8sesstXMnBXr5OUX8odN/lMw/xTc9lO3sM1lJQmvb5GUAL1TSHN6P9t79rrgg5C1ncD8cQBd0C/0ylrLVK6abQ5pu7quucS+gg41MRTwQIzk1RqX3z67YQ8nb3o8XmmDjWX29L4Kz3lPQ2zNF0GOgjyOv61lDI1bZPMj6L2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XOLICeB5PWOUE5PVmYqYWDwFkt+e8ea+Lwq5XKyiQEo=; b=g4TQWiz3Q87CTZpuobFFhYdZ56Llc/ZYtJcBeqkFMRDItth3QfpVm7097is2wSdcDK2WElAuJ/TslwQHkRqy7vyUt5caykRLqhY4wmhMGPqWCqfDMy61iSxm46N6h/0o7tZuUo+4B15V/9KExF6NaKbC7RO2XkBWCxahJh2xnej5Uo4RRvULaB1WVm5ki+FuvkBm2c7GiHDJwPy6OdpRqSWsl/QQ9Uw/bVd+5GQz9j8Aeq1TbTA/FKKrjEuQCL+sQ4TWIuFkjHXbq6uPJwlkUZcWMSRl0v6UVLgmp/b6DbEbzE5brz0RhFdzyD0a4UlT3x73psbnEARQ9JGFcCj7Dw== Received: from BL1P221CA0026.NAMP221.PROD.OUTLOOK.COM (2603:10b6:208:2c5::27) by SJ0PR12MB6760.namprd12.prod.outlook.com (2603:10b6:a03:44c::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.28; Wed, 20 Sep 2023 12:53:26 +0000 Received: from BL02EPF0001A108.namprd05.prod.outlook.com (2603:10b6:208:2c5:cafe::81) by BL1P221CA0026.outlook.office365.com (2603:10b6:208:2c5::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.29 via Frontend Transport; Wed, 20 Sep 2023 12:53:25 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF0001A108.mail.protection.outlook.com (10.167.241.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.20 via Frontend Transport; Wed, 20 Sep 2023 12:53:25 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 20 Sep 2023 05:53:12 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 20 Sep 2023 05:53:10 -0700 From: Tomer Shmilovich To: Thomas Monjalon , Ori Kam , "Ferruh Yigit" , Andrew Rybchenko CC: Subject: [PATCH 1/2] ethdev: add group set miss actions API Date: Wed, 20 Sep 2023 12:52:48 +0000 Message-ID: <20230920125250.804055-2-tshmilovich@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230920125250.804055-1-tshmilovich@nvidia.com> References: <20230920125250.804055-1-tshmilovich@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail202.nvidia.com (10.129.68.7) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF0001A108:EE_|SJ0PR12MB6760:EE_ X-MS-Office365-Filtering-Correlation-Id: d17a780a-9559-4ba4-7824-08dbb9d89455 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1B1uE7bGE7rkuYJD7LTDeKWszSiW1Bbrsb65vM+n+5gYIWFlOxJ0A9kw0rKN9UNOGDoBBBr+BmIA+g0afv+oqQQb02rReVretHAVb9W3QK8BU4MeI4v3+CNXBgqPAZgyLIROwJVIuFVgDs321ry3KAPxgrSP3W78dcPy52eL8Tvi9cZkKwkxMtPjqPK9/dyvNFSqbSQncJwvHdOc0uNryGcRU3odaE3QUBLokR0wM8nyUO8B+rm00SHIBycTIPCG1W/m/B2Q/FNCDQ94EcCZ4Rr2VB8e+4aDfL6qlZDADfvh1EgmVAuX9cPhe0s5eV4lgOyZvt2AsNEsfZvaI1os0oWy9uS/Hb/7ttsUkd06CgfDAuZE4LYWLLZy+pXy3zzphCyRPsVbM6mmZHgGUNaQHfZCrlzxrXEbhxEdJiiQNcQmzBBzSmKPeSW45njNd4znIcTIj/RfWrs5ml1oZ9QiaNxXm85J15NQw0T3dNzGKX8BvbiiYBa+KIFyx1YfHX+FGSmE7f7wcBf4mkWAfyFtAA4KzosVoz09xOoE5smJ+RaYMbC2ZISozdVGey80C8nMYTNiEORqAW9cyXiGHO1Q2rvf5xycDZwbgnryFsZ1Gw7yixe7+yCLDLYXU9kfRfHBjrVCIKDChFdo1aheRkUqFuHdsiDVdV/PDc/uJPHyfPJew+vweNQC7xKawyoQkwvgAwFUqPltV2HRUFmCnzIHnAru9AkwjW1AYN7Why2RW6tCCLb+b9XWZOpk0plv35FR X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(396003)(39860400002)(346002)(376002)(136003)(451199024)(1800799009)(82310400011)(186009)(46966006)(40470700004)(36840700001)(6666004)(7696005)(426003)(47076005)(83380400001)(40460700003)(86362001)(55016003)(36756003)(82740400003)(7636003)(356005)(40480700001)(36860700001)(336012)(2906002)(478600001)(4326008)(5660300002)(26005)(8936002)(41300700001)(316002)(1076003)(110136005)(70206006)(70586007)(6286002)(2616005)(16526019)(8676002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2023 12:53:25.3729 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d17a780a-9559-4ba4-7824-08dbb9d89455 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF0001A108.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6760 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Introduce new group set miss actions API: rte_flow_group_set_miss_actions(). A group's miss actions are a set of actions to be performed in case of a miss on a group, meaning a packet didn't hit any rules in the group. This API function allows a user to set a group's miss actions. Signed-off-by: Tomer Shmilovich Acked-by: Ori Kam --- .mailmap | 1 + doc/guides/prog_guide/rte_flow.rst | 30 ++++++++++++++++++++++ doc/guides/rel_notes/release_23_11.rst | 5 ++++ lib/ethdev/rte_flow.c | 22 ++++++++++++++++ lib/ethdev/rte_flow.h | 35 ++++++++++++++++++++++++++ lib/ethdev/rte_flow_driver.h | 7 ++++++ lib/ethdev/version.map | 3 +++ 7 files changed, 103 insertions(+) diff --git a/.mailmap b/.mailmap index 864d33ee46..0cd6be849e 100644 --- a/.mailmap +++ b/.mailmap @@ -1411,6 +1411,7 @@ Tom Barbette Tom Crugnale Tom Millington Tom Rix +Tomer Shmilovich Tone Zhang Tonghao Zhang Tony Nguyen diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst index 5bc998a433..590d2a770e 100644 --- a/doc/guides/prog_guide/rte_flow.rst +++ b/doc/guides/prog_guide/rte_flow.rst @@ -3758,6 +3758,36 @@ Information about the number of available resources can be retrieved via struct rte_flow_queue_info *queue_info, struct rte_flow_error *error); +Group Miss Actions +~~~~~~~~~~~~~~~~~~ + +In an application, many flow rules share common group attributes, meaning they can be grouped and +classified together. A user can explicitly specify a set of actions performed on a packet when it +did not match any flows rules in a group using the following API: + +.. code-block:: c + + int + rte_flow_group_set_miss_actions(uint16_t port_id, + uint32_t group_id, + const struct rte_flow_group_attr *attr, + const struct rte_flow_action actions[], + struct rte_flow_error *error); + +For example, to configure a RTE_FLOW_TYPE_JUMP action as a miss action for ingress group 1: + +.. code-block:: c + + struct rte_flow_group_attr attr = {.ingress = 1}; + struct rte_flow_action act[] = { + /* Setting miss actions to jump to group 3 */ + [0] = {.type = RTE_FLOW_ACTION_TYPE_JUMP, + .conf = &(struct rte_flow_action_jump){.group = 3}}, + [1] = {.type = RTE_FLOW_ACTION_TYPE_END}, + }; + struct rte_flow_error err; + rte_flow_group_set_miss_actions(port, 1, &attr, act, &err); + Flow templates ~~~~~~~~~~~~~~ diff --git a/doc/guides/rel_notes/release_23_11.rst b/doc/guides/rel_notes/release_23_11.rst index 333e1d95a2..da0ddc2078 100644 --- a/doc/guides/rel_notes/release_23_11.rst +++ b/doc/guides/rel_notes/release_23_11.rst @@ -41,6 +41,11 @@ DPDK Release 23.11 New Features ------------ +* **Added flow group set miss actions.** + Introduced ``rte_flow_group_set_miss_actions()`` API to explicitly set a group's miss actions, + which are the actions to be performed on packets that didn't match any of the flow rules + in the group. + .. This section should contain new features added in this release. Sample format: diff --git a/lib/ethdev/rte_flow.c b/lib/ethdev/rte_flow.c index 271d854f78..a98d87265f 100644 --- a/lib/ethdev/rte_flow.c +++ b/lib/ethdev/rte_flow.c @@ -1973,6 +1973,28 @@ rte_flow_template_table_destroy(uint16_t port_id, NULL, rte_strerror(ENOTSUP)); } +int +rte_flow_group_set_miss_actions(uint16_t port_id, + uint32_t group_id, + const struct rte_flow_group_attr *attr, + const struct rte_flow_action actions[], + struct rte_flow_error *error) +{ + struct rte_eth_dev *dev = &rte_eth_devices[port_id]; + const struct rte_flow_ops *ops = rte_flow_ops_get(port_id, error); + + if (unlikely(!ops)) + return -rte_errno; + if (likely(!!ops->group_set_miss_actions)) { + return flow_err(port_id, + ops->group_set_miss_actions(dev, group_id, attr, actions, error), + error); + } + return rte_flow_error_set(error, ENOTSUP, + RTE_FLOW_ERROR_TYPE_UNSPECIFIED, + NULL, rte_strerror(ENOTSUP)); +} + struct rte_flow * rte_flow_async_create(uint16_t port_id, uint32_t queue_id, diff --git a/lib/ethdev/rte_flow.h b/lib/ethdev/rte_flow.h index 2ebb76dbc0..82548a8b93 100644 --- a/lib/ethdev/rte_flow.h +++ b/lib/ethdev/rte_flow.h @@ -129,6 +129,12 @@ struct rte_flow_attr { uint32_t reserved:29; /**< Reserved, must be zero. */ }; +struct rte_flow_group_attr { + uint32_t ingress:1; + uint32_t egress:1; + uint32_t transfer:1; +}; + /** * Matching pattern item types. * @@ -5828,6 +5834,35 @@ rte_flow_template_table_destroy(uint16_t port_id, struct rte_flow_template_table *template_table, struct rte_flow_error *error); +/** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Set group miss actions. + * + * @param port_id + * Port identifier of Ethernet device. + * @param group_id + * Identifier of a group to set miss actions for. + * @param attr + * Group attributes. + * @param actions + * List of group miss actions. + * @param[out] error + * Perform verbose error reporting if not NULL. + * PMDs initialize this structure in case of error only. + * + * @return + * 0 on success, a negative errno value otherwise and rte_errno is set. + */ +__rte_experimental +int +rte_flow_group_set_miss_actions(uint16_t port_id, + uint32_t group_id, + const struct rte_flow_group_attr *attr, + const struct rte_flow_action actions[], + struct rte_flow_error *error); + /** * @warning * @b EXPERIMENTAL: this API may change without prior notice. diff --git a/lib/ethdev/rte_flow_driver.h b/lib/ethdev/rte_flow_driver.h index f9fb01b8a2..3ced086c47 100644 --- a/lib/ethdev/rte_flow_driver.h +++ b/lib/ethdev/rte_flow_driver.h @@ -227,6 +227,13 @@ struct rte_flow_ops { (struct rte_eth_dev *dev, struct rte_flow_template_table *template_table, struct rte_flow_error *err); + /** See rte_flow_group_set_miss_actions() */ + int (*group_set_miss_actions) + (struct rte_eth_dev *dev, + uint32_t group_id, + const struct rte_flow_group_attr *attr, + const struct rte_flow_action actions[], + struct rte_flow_error *err); /** See rte_flow_async_create() */ struct rte_flow *(*async_create) (struct rte_eth_dev *dev, diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map index b965d6aa52..ff9b92f21e 100644 --- a/lib/ethdev/version.map +++ b/lib/ethdev/version.map @@ -312,6 +312,9 @@ EXPERIMENTAL { rte_flow_async_action_list_handle_query_update; rte_flow_async_actions_update; rte_flow_restore_info_dynflag; + + # added in 23.11 + rte_flow_group_set_miss_actions; }; INTERNAL {