[v4,02/12] eventdev: api to get DMA adapter capabilities

Message ID 20230926103233.3956431-3-amitprakashs@marvell.com (mailing list archive)
State Superseded, archived
Delegated to: Jerin Jacob
Headers
Series event DMA adapter library support |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Amit Prakash Shukla Sept. 26, 2023, 10:32 a.m. UTC
  Added a new eventdev API rte_event_dma_adapter_caps_get(), to get
DMA adapter capabilities supported by the driver.

Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
---
 lib/eventdev/meson.build    |  2 +-
 lib/eventdev/rte_eventdev.c | 23 +++++++++++++++++++++++
 lib/eventdev/rte_eventdev.h |  2 +-
 lib/meson.build             |  2 +-
 4 files changed, 26 insertions(+), 3 deletions(-)
  

Comments

Jerin Jacob Sept. 27, 2023, 6:20 p.m. UTC | #1
On Tue, Sep 26, 2023 at 4:03 PM Amit Prakash Shukla
<amitprakashs@marvell.com> wrote:
>
> Added a new eventdev API rte_event_dma_adapter_caps_get(), to get
> DMA adapter capabilities supported by the driver.

Patches from 2: Keep following heading template

eventdev/dma: support ...

example:
eventdev/dma: support adapter capabilities get


> Signed-off-by: Amit Prakash Shukla <amitprakashs@marvell.com>
> ---
>  lib/eventdev/meson.build    |  2 +-
>  lib/eventdev/rte_eventdev.c | 23 +++++++++++++++++++++++
>  lib/eventdev/rte_eventdev.h |  2 +-
>  lib/meson.build             |  2 +-
>  4 files changed, 26 insertions(+), 3 deletions(-)
>
> diff --git a/lib/eventdev/meson.build b/lib/eventdev/meson.build
> index 21347f7c4c..b46bbbc9aa 100644
> --- a/lib/eventdev/meson.build
> +++ b/lib/eventdev/meson.build
> @@ -43,5 +43,5 @@ driver_sdk_headers += files(
>          'event_timer_adapter_pmd.h',
>  )
>
> -deps += ['ring', 'ethdev', 'hash', 'mempool', 'mbuf', 'timer', 'cryptodev']
> +deps += ['ring', 'ethdev', 'hash', 'mempool', 'mbuf', 'timer', 'cryptodev', 'dmadev']
>  deps += ['telemetry']
> diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c
> index 6ab4524332..60509c6efb 100644
> --- a/lib/eventdev/rte_eventdev.c
> +++ b/lib/eventdev/rte_eventdev.c
> @@ -20,6 +20,7 @@
>  #include <rte_errno.h>
>  #include <ethdev_driver.h>
>  #include <rte_cryptodev.h>
> +#include <rte_dmadev.h>
>  #include <cryptodev_pmd.h>
>  #include <rte_telemetry.h>
>
> @@ -224,6 +225,28 @@ rte_event_eth_tx_adapter_caps_get(uint8_t dev_id, uint16_t eth_port_id,
>                         : 0;
>  }
>
> +int
> +rte_event_dma_adapter_caps_get(uint8_t dev_id, uint8_t dma_dev_id, uint32_t *caps)
> +{
> +       struct rte_eventdev *dev;
> +
> +       RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);
> +       if (!rte_dma_is_valid(dma_dev_id))
> +               return -EINVAL;
> +
> +       dev = &rte_eventdevs[dev_id];
> +
> +       if (caps == NULL)
> +               return -EINVAL;
> +
> +       *caps = 0;
> +
> +       if (dev->dev_ops->dma_adapter_caps_get)
> +               return (*dev->dev_ops->dma_adapter_caps_get)(dev, dma_dev_id, caps);
> +
> +       return 0;
> +}
> +
>  static inline int
>  event_dev_queue_config(struct rte_eventdev *dev, uint8_t nb_queues)
>  {
> diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h
> index 2c6ecc7f8f..41743f91b1 100644
> --- a/lib/eventdev/rte_eventdev.h
> +++ b/lib/eventdev/rte_eventdev.h
> @@ -1504,7 +1504,7 @@ rte_event_crypto_adapter_caps_get(uint8_t dev_id, uint8_t cdev_id,
>   */
>  __rte_experimental
>  int
> -rte_event_dma_adapter_caps_get(uint8_t dev_id, int16_t dmadev_id, uint32_t *caps);
> +rte_event_dma_adapter_caps_get(uint8_t dev_id, uint8_t dmadev_id, uint32_t *caps);

Squash this to first patch.
  

Patch

diff --git a/lib/eventdev/meson.build b/lib/eventdev/meson.build
index 21347f7c4c..b46bbbc9aa 100644
--- a/lib/eventdev/meson.build
+++ b/lib/eventdev/meson.build
@@ -43,5 +43,5 @@  driver_sdk_headers += files(
         'event_timer_adapter_pmd.h',
 )
 
-deps += ['ring', 'ethdev', 'hash', 'mempool', 'mbuf', 'timer', 'cryptodev']
+deps += ['ring', 'ethdev', 'hash', 'mempool', 'mbuf', 'timer', 'cryptodev', 'dmadev']
 deps += ['telemetry']
diff --git a/lib/eventdev/rte_eventdev.c b/lib/eventdev/rte_eventdev.c
index 6ab4524332..60509c6efb 100644
--- a/lib/eventdev/rte_eventdev.c
+++ b/lib/eventdev/rte_eventdev.c
@@ -20,6 +20,7 @@ 
 #include <rte_errno.h>
 #include <ethdev_driver.h>
 #include <rte_cryptodev.h>
+#include <rte_dmadev.h>
 #include <cryptodev_pmd.h>
 #include <rte_telemetry.h>
 
@@ -224,6 +225,28 @@  rte_event_eth_tx_adapter_caps_get(uint8_t dev_id, uint16_t eth_port_id,
 			: 0;
 }
 
+int
+rte_event_dma_adapter_caps_get(uint8_t dev_id, uint8_t dma_dev_id, uint32_t *caps)
+{
+	struct rte_eventdev *dev;
+
+	RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL);
+	if (!rte_dma_is_valid(dma_dev_id))
+		return -EINVAL;
+
+	dev = &rte_eventdevs[dev_id];
+
+	if (caps == NULL)
+		return -EINVAL;
+
+	*caps = 0;
+
+	if (dev->dev_ops->dma_adapter_caps_get)
+		return (*dev->dev_ops->dma_adapter_caps_get)(dev, dma_dev_id, caps);
+
+	return 0;
+}
+
 static inline int
 event_dev_queue_config(struct rte_eventdev *dev, uint8_t nb_queues)
 {
diff --git a/lib/eventdev/rte_eventdev.h b/lib/eventdev/rte_eventdev.h
index 2c6ecc7f8f..41743f91b1 100644
--- a/lib/eventdev/rte_eventdev.h
+++ b/lib/eventdev/rte_eventdev.h
@@ -1504,7 +1504,7 @@  rte_event_crypto_adapter_caps_get(uint8_t dev_id, uint8_t cdev_id,
  */
 __rte_experimental
 int
-rte_event_dma_adapter_caps_get(uint8_t dev_id, int16_t dmadev_id, uint32_t *caps);
+rte_event_dma_adapter_caps_get(uint8_t dev_id, uint8_t dmadev_id, uint32_t *caps);
 
 /* Ethdev Tx adapter capability bitmap flags */
 #define RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT	0x1
diff --git a/lib/meson.build b/lib/meson.build
index 53155be8e9..f3191f10b6 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -33,6 +33,7 @@  libraries = [
         'compressdev',
         'cryptodev',
         'distributor',
+        'dmadev',
         'efd',
         'eventdev',
         'gpudev',
@@ -48,7 +49,6 @@  libraries = [
         'rawdev',
         'regexdev',
         'mldev',
-        'dmadev',
         'rib',
         'reorder',
         'sched',