From patchwork Thu Sep 28 13:09:11 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shun Hao X-Patchwork-Id: 132140 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39F8C42661; Thu, 28 Sep 2023 15:10:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5D6EF40A8A; Thu, 28 Sep 2023 15:09:57 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2069.outbound.protection.outlook.com [40.107.244.69]) by mails.dpdk.org (Postfix) with ESMTP id 8E89A40DCE for ; Thu, 28 Sep 2023 15:09:55 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jp5s/b/hxiAj24JJR7Rotxkddc7gZdi3sv75ESzKB71J60rcwvvgSlZC9Ku7LWU6QkkPsEeFYROu+NDvRUtR9xjHBRaifz75llo1BZK/Fzi4o3aSCKLtqOdh21VXLleBTr0ZZgIsoYJCJk5rG+nrPbl1izmkbZr2c39mJ/5CCfEIy8x+qccFb7DQRJVZZuTnPeR1Xxp2KBS/3rrghIck7JKYdc2jYXggn1UIzoqjipiBdCYxnrzt+RNBQQlsIMPC9eR5wLBkXgDp/UhmA9QLWFABfR8r1R0c6jqmaqfWd7jJ06KqhpWCvuzNY7ey3x32lGPc5FNoPLTJ1PZJv5ci8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=yEBZPdE/3CayOpns2bEQvBwBpM/sAWl0oFj2ltxbVFI=; b=Fo0gR2Y5o1MURanMx0BoXcaoiTIoMa6Q63wuiB8qi5ktg9bCfOZ7ClHbnT65G5BpDVFnvQqoVIPxuloP7TAzPFQdDoXBLYsrDrjkHs7SIn89z2JlYsCrQ3uQ/XxQtZU31K9guYe6sRGkT1FRtuolXQVeKc7KqKaoqSu7HNWciUwFQQXk2x0YeDdkvOTXvJRA87qFeMUahgeTMmFhiLfTNcZYrjucOtgbt2ZR6i9cmdHO4B3GB/9y2mWg1430B9SP4Gzu3+URHKgiNEfUFQr9Es5hdq/2l2+Hn+WI51G+4TSW9URn2K1kp5NIYswXmURRiOVlwbUimQkmwSSJ0FRKjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yEBZPdE/3CayOpns2bEQvBwBpM/sAWl0oFj2ltxbVFI=; b=Dc/WwTjjxVkTlnt2TbbKqq5dvQVfJIezI8X7WEYNjBPhn7f9Vd26/p/+JBAuoL0r4rFLylOe9/9ux98nXe/RRHOfABFlvBNri0x9aZFQJNrN3Me7Cl7H93xPb/85ANB83reJJWEy9P7Fn6SkfVXlBwL18q0h2q0sbTEADIsnpfYV90Y3hA8i8CApxMXmc2rc3vJFRD6/o1YHkxO2mIHFlOrc1r0SsE2X59ZrK4JQE40QeYapk81Kb6R9J0fOs7jOcImyAYJJvy9LzsKPTk+7ks+M9tVPaAQS7G6C+9ntU+78XBNiaCJgZgg7bIVCTgJo8EgJp9uyAu8xbbGHV0iO8Q== Received: from BL1P221CA0018.NAMP221.PROD.OUTLOOK.COM (2603:10b6:208:2c5::30) by SJ2PR12MB9006.namprd12.prod.outlook.com (2603:10b6:a03:540::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.32; Thu, 28 Sep 2023 13:09:52 +0000 Received: from MN1PEPF0000ECD8.namprd02.prod.outlook.com (2603:10b6:208:2c5:cafe::80) by BL1P221CA0018.outlook.office365.com (2603:10b6:208:2c5::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.25 via Frontend Transport; Thu, 28 Sep 2023 13:09:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by MN1PEPF0000ECD8.mail.protection.outlook.com (10.167.242.137) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.14 via Frontend Transport; Thu, 28 Sep 2023 13:09:52 +0000 Received: from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 28 Sep 2023 06:09:36 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail202.nvidia.com (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Thu, 28 Sep 2023 06:09:34 -0700 From: Shun Hao To: , , , "Suanming Mou" CC: , , Hamdan Igbaria , Alex Vesker Subject: [PATCH v1 1/3] net/mlx5/hws: add creation of packet reformat DevX obj Date: Thu, 28 Sep 2023 16:09:11 +0300 Message-ID: <20230928130913.2583907-2-shunh@nvidia.com> X-Mailer: git-send-email 2.20.0 In-Reply-To: <20230928130913.2583907-1-shunh@nvidia.com> References: <20230928130913.2583907-1-shunh@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail202.nvidia.com (10.129.68.7) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MN1PEPF0000ECD8:EE_|SJ2PR12MB9006:EE_ X-MS-Office365-Filtering-Correlation-Id: f1aa06ba-3316-400d-b124-08dbc02433cc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: S2S2wgfBDx6z0VrALmNcCeq8p0lEWh5m+u/qlMUzhas3FDGxgGiK7OtFH4Qgfa/8ukF8DSBxSZv0PDhC2W3iBt9GUCxlpAbHCKEXSMKv321uJPqXfOfzkr8SvmmG60DPMYEKG+IYeZtBJVxMx5kCkxcuOSor95qFCG7ilauKPaOfjxZWjkodcAaXIamR4mHRAbCDsFIKW4K1joDDPDxNzZIXxiHu5d4tVjmDpbXFGz1M102mHRbkgM72OavdyJhlrIMBDmje2lfLARjRH6En726ZyWdbXk3U55dgGechAwcdbRGxhO8BBdN8nhfLzONHRn7qHmxUSPz6mhinr0u044qrsZcnY+OwMT3bhGJpLHFO3foSLvZ82tiJ1L099YQ3RcEcW5e9chkbCD5Q3EJdzHC0P84/2Uc6rtSI3ZKopr4uhzOJWiFsP4ShzkUayOJPww+9JuCEGkrJ2IFhUkgQRaYtSuGMB5ttsiDjVYnDZB02HLezd+gFxodM5g6RB0/APHR+JAui/wjEjTBvP5wSyMkfP0UnNvBJzm1Si+PTGGWkz3rye//JZ7mJAiVcbgloBWwysgulYqDim7uYHIiVZRu2ScoctQMHrZoaP7IKMxkJKrGK4yxDH60s7IZR4uLRMXTclrHD2vy7gNSykEvln55mpfjKORPxWZdEzCiTNrckVgtOq0+RFFJavleBXyD/s/4BC1xcangoMsFgJQ8qJL4kl42uq0sQj5tG+OszV5GPxIcS1sTH1zzhJgb8RyF7 X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(396003)(39860400002)(376002)(136003)(346002)(230922051799003)(1800799009)(64100799003)(82310400011)(186009)(451199024)(36840700001)(40470700004)(46966006)(40460700003)(66899024)(5660300002)(83380400001)(40480700001)(55016003)(316002)(41300700001)(6666004)(36756003)(8676002)(70586007)(70206006)(36860700001)(478600001)(6636002)(54906003)(8936002)(7636003)(110136005)(86362001)(47076005)(7696005)(82740400003)(2906002)(4326008)(356005)(426003)(2616005)(107886003)(26005)(6286002)(1076003)(336012)(16526019); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Sep 2023 13:09:52.1434 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f1aa06ba-3316-400d-b124-08dbc02433cc X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: MN1PEPF0000ECD8.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9006 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Hamdan Igbaria Add support for creation of packet reformat object, via the ALLOC_PACKET_REFORMAT_CONTEXT command. Signed-off-by: Hamdan Igbaria Acked-by: Alex Vesker --- drivers/common/mlx5/mlx5_prm.h | 39 +++++++++++++++++ drivers/net/mlx5/hws/mlx5dr_cmd.c | 60 ++++++++++++++++++++++++++ drivers/net/mlx5/hws/mlx5dr_cmd.h | 11 +++++ drivers/net/mlx5/hws/mlx5dr_internal.h | 5 +++ drivers/net/mlx5/hws/mlx5dr_send.c | 5 --- 5 files changed, 115 insertions(+), 5 deletions(-) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h index 51f426c614..6749f2c037 100644 --- a/drivers/common/mlx5/mlx5_prm.h +++ b/drivers/common/mlx5/mlx5_prm.h @@ -1213,6 +1213,8 @@ enum { MLX5_CMD_OP_CREATE_FLOW_GROUP = 0x933, MLX5_CMD_OP_SET_FLOW_TABLE_ENTRY = 0x936, MLX5_CMD_OP_MODIFY_FLOW_TABLE = 0x93c, + MLX5_CMD_OP_ALLOC_PACKET_REFORMAT_CONTEXT = 0x93d, + MLX5_CMD_OP_DEALLOC_PACKET_REFORMAT_CONTEXT = 0x93e, MLX5_CMD_OP_ALLOC_FLOW_COUNTER = 0x939, MLX5_CMD_OP_QUERY_FLOW_COUNTER = 0x93b, MLX5_CMD_OP_CREATE_GENERAL_OBJECT = 0xa00, @@ -5180,6 +5182,43 @@ struct mlx5_ifc_modify_flow_table_out_bits { u8 reserved_at_40[0x60]; }; +struct mlx5_ifc_packet_reformat_context_in_bits { + u8 reformat_type[0x8]; + u8 reserved_at_8[0x4]; + u8 reformat_param_0[0x4]; + u8 reserved_at_16[0x6]; + u8 reformat_data_size[0xa]; + + u8 reformat_param_1[0x8]; + u8 reserved_at_40[0x8]; + u8 reformat_data[6][0x8]; + + u8 more_reformat_data[][0x8]; +}; + +struct mlx5_ifc_alloc_packet_reformat_context_in_bits { + u8 opcode[0x10]; + u8 uid[0x10]; + + u8 reserved_at_20[0x10]; + u8 op_mod[0x10]; + + u8 reserved_at_40[0xa0]; + + u8 packet_reformat_context[]; +}; + +struct mlx5_ifc_alloc_packet_reformat_out_bits { + u8 status[0x8]; + u8 reserved_at_8[0x18]; + + u8 syndrome[0x20]; + + u8 packet_reformat_id[0x20]; + + u8 reserved_at_60[0x20]; +}; + /* CQE format mask. */ #define MLX5E_CQE_FORMAT_MASK 0xc diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.c b/drivers/net/mlx5/hws/mlx5dr_cmd.c index 7771aeb8cf..d20ec7f0c4 100644 --- a/drivers/net/mlx5/hws/mlx5dr_cmd.c +++ b/drivers/net/mlx5/hws/mlx5dr_cmd.c @@ -779,6 +779,66 @@ mlx5dr_cmd_sq_create(struct ibv_context *ctx, return devx_obj; } +struct mlx5dr_devx_obj * +mlx5dr_cmd_packet_reformat_create(struct ibv_context *ctx, + struct mlx5dr_cmd_packet_reformat_create_attr *attr) +{ + uint32_t out[DEVX_ST_SZ_DW(alloc_packet_reformat_out)] = {0}; + size_t insz, cmd_data_sz, cmd_total_sz; + struct mlx5dr_devx_obj *devx_obj; + void *prctx; + void *pdata; + void *in; + + cmd_total_sz = DEVX_ST_SZ_BYTES(alloc_packet_reformat_context_in); + cmd_total_sz += DEVX_ST_SZ_BYTES(packet_reformat_context_in); + cmd_data_sz = DEVX_FLD_SZ_BYTES(packet_reformat_context_in, reformat_data); + insz = align(cmd_total_sz + attr->data_sz - cmd_data_sz, DW_SIZE); + in = simple_calloc(1, insz); + if (!in) { + rte_errno = ENOMEM; + return NULL; + } + + MLX5_SET(alloc_packet_reformat_context_in, in, opcode, + MLX5_CMD_OP_ALLOC_PACKET_REFORMAT_CONTEXT); + + prctx = DEVX_ADDR_OF(alloc_packet_reformat_context_in, in, + packet_reformat_context); + pdata = DEVX_ADDR_OF(packet_reformat_context_in, prctx, reformat_data); + + MLX5_SET(packet_reformat_context_in, prctx, reformat_type, attr->type); + MLX5_SET(packet_reformat_context_in, prctx, reformat_param_0, attr->reformat_param_0); + MLX5_SET(packet_reformat_context_in, prctx, reformat_data_size, attr->data_sz); + memcpy(pdata, attr->data, attr->data_sz); + + devx_obj = simple_malloc(sizeof(*devx_obj)); + if (!devx_obj) { + DR_LOG(ERR, "Failed to allocate memory for packet reformat object"); + rte_errno = ENOMEM; + goto out_free_in; + } + + devx_obj->obj = mlx5_glue->devx_obj_create(ctx, in, insz, out, sizeof(out)); + if (!devx_obj->obj) { + DR_LOG(ERR, "Failed to create packet reformat"); + rte_errno = errno; + goto out_free_devx; + } + + devx_obj->id = MLX5_GET(alloc_packet_reformat_out, out, packet_reformat_id); + + simple_free(in); + + return devx_obj; + +out_free_devx: + simple_free(devx_obj); +out_free_in: + simple_free(in); + return NULL; +} + int mlx5dr_cmd_sq_modify_rdy(struct mlx5dr_devx_obj *devx_obj) { uint32_t out[MLX5_ST_SZ_DW(modify_sq_out)] = {0}; diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.h b/drivers/net/mlx5/hws/mlx5dr_cmd.h index e57013c309..ee427c1829 100644 --- a/drivers/net/mlx5/hws/mlx5dr_cmd.h +++ b/drivers/net/mlx5/hws/mlx5dr_cmd.h @@ -155,6 +155,13 @@ struct mlx5dr_cmd_allow_other_vhca_access_attr { uint8_t access_key[ACCESS_KEY_LEN]; }; +struct mlx5dr_cmd_packet_reformat_create_attr { + uint8_t type; + size_t data_sz; + void *data; + uint8_t reformat_param_0; +}; + struct mlx5dr_cmd_query_ft_caps { uint8_t max_level; uint8_t reparse; @@ -270,6 +277,10 @@ mlx5dr_cmd_header_modify_pattern_create(struct ibv_context *ctx, uint32_t pattern_length, uint8_t *actions); +struct mlx5dr_devx_obj * +mlx5dr_cmd_packet_reformat_create(struct ibv_context *ctx, + struct mlx5dr_cmd_packet_reformat_create_attr *attr); + struct mlx5dr_devx_obj * mlx5dr_cmd_set_fte(struct ibv_context *ctx, uint32_t table_type, diff --git a/drivers/net/mlx5/hws/mlx5dr_internal.h b/drivers/net/mlx5/hws/mlx5dr_internal.h index c3c077667d..3770d28e62 100644 --- a/drivers/net/mlx5/hws/mlx5dr_internal.h +++ b/drivers/net/mlx5/hws/mlx5dr_internal.h @@ -91,4 +91,9 @@ static inline uint64_t roundup_pow_of_two(uint64_t n) return n == 1 ? 1 : 1ULL << log2above(n); } +static inline unsigned long align(unsigned long val, unsigned long align) +{ + return (val + align - 1) & ~(align - 1); +} + #endif /* MLX5DR_INTERNAL_H_ */ diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5dr_send.c index e58fdeb117..622d574bfa 100644 --- a/drivers/net/mlx5/hws/mlx5dr_send.c +++ b/drivers/net/mlx5/hws/mlx5dr_send.c @@ -668,11 +668,6 @@ static int mlx5dr_send_ring_create_sq_obj(struct mlx5dr_context *ctx, return err; } -static inline unsigned long align(unsigned long val, unsigned long align) -{ - return (val + align - 1) & ~(align - 1); -} - static int mlx5dr_send_ring_open_sq(struct mlx5dr_context *ctx, struct mlx5dr_send_engine *queue, struct mlx5dr_send_ring_sq *sq,