From patchwork Fri Sep 29 20:38:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joshua Washington X-Patchwork-Id: 132248 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D693142677; Fri, 29 Sep 2023 22:38:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5EA064027E; Fri, 29 Sep 2023 22:38:58 +0200 (CEST) Received: from mail-yw1-f201.google.com (mail-yw1-f201.google.com [209.85.128.201]) by mails.dpdk.org (Postfix) with ESMTP id 867ED40273 for ; Fri, 29 Sep 2023 22:38:57 +0200 (CEST) Received: by mail-yw1-f201.google.com with SMTP id 00721157ae682-59f8315aabfso182454557b3.0 for ; Fri, 29 Sep 2023 13:38:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1696019937; x=1696624737; darn=dpdk.org; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=A/9/a1KJDJ8xOxR1PrP4GdcLKtSEPQJ+BR7ZM2BnjqM=; b=aHpmHKbq9xcH8O89byVU0RH19CLSP0esyB2roH1L/z5g09RPrMGLNTvVBpUcne7DbO Ch/IQOLOighr7psRd3FT3i0lqLxhunHc6hCZgeH3/W/9E13QK7vYZB3Iwm0WuTHmebeE WJvRgYa0l1EjAnoFxahyOlq0NhinZadxEj1p1WktqPr9VbLQ/YaVVn7QGmTgUNEzdGvP Rph/QjYZYVsjj5MbwZEqXL9Fi5lnwGb7yypSvQLq6WtABZhiL2GlGd509xXEkHHE0DGI r3UL/X900wokaMdodE+UcLF9AarbtINjP+70BZ4AyuOYPwfOhy2BLyrAFWQ2QkcP8tiG 6i7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696019937; x=1696624737; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=A/9/a1KJDJ8xOxR1PrP4GdcLKtSEPQJ+BR7ZM2BnjqM=; b=C3qVAw+v883P7DNvb/csPMSMHtAD6UOBmOeCzHyojGw+dps/18TOu2yB5INRfoYU5p cExWu7JURD2q/aQDBYq7XiBgqS8kXX5fOC8TurAuN0U5Zc19jcUf63nMFz2LNMDxxlTb t7oXxOnH3hRuNeToHgYuHEljMu0hUmTKgUVGjS5S11FuVUj8lzK2B2qQfICROOScONP4 7mxOW9RyoBtGrWXcrQUUJHrs4aXkrLxZ+uDuHkZ0b0tvzm/BzS7xEZtGV8i5Ug+WKMgU FhXIU18kjyie3VQCZsMzPIPeA/c1NoiCK/mPCawoOEHVUQR3sEsvDhp6UZw55gOEbQ4M nI7A== X-Gm-Message-State: AOJu0YwfLHg6MXbYRUf9rdn5uhWfjdcobgkbDYsF6vg6M3t8IBg74M9b 1CRheynEbTIyP/6bdUbrw1x1It0jHZUJWA== X-Google-Smtp-Source: AGHT+IHh7WeSmwpI4nX7T933NRC/NEYfrsn6DNN0U4jfXRGrbT1mFdmq2oaJnUCu6NE15WfvPZQBODm7+rtiYQ== X-Received: from joshwash.sea.corp.google.com ([2620:15c:11c:202:f217:1a2a:72fb:2458]) (user=joshwash job=sendgmr) by 2002:a25:e681:0:b0:d85:ad61:1591 with SMTP id d123-20020a25e681000000b00d85ad611591mr79171ybh.11.1696019936832; Fri, 29 Sep 2023 13:38:56 -0700 (PDT) Date: Fri, 29 Sep 2023 13:38:25 -0700 Mime-Version: 1.0 X-Mailer: git-send-email 2.42.0.582.g8ccd20d70d-goog Message-ID: <20230929203825.3136449-1-joshwash@google.com> Subject: [PATCH] net/gve: allow GVE MTU greater than RTE_ETHER_MTU From: Joshua Washington To: Junfeng Guo , Jeroen de Borst , Rushil Gupta , Joshua Washington Cc: dev@dpdk.org, Ferruh Yigit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This patch corrects the MTU setting behavior in the GVE DPDK driver to remove the artificial upper limit of RTE_ETHER_MTU. Instead, the max MTU is dictated by the default value of the MTU that the device sends during initialization, which will always be the maximum supported MTU. Signed-off-by: Joshua Washington --- drivers/net/gve/gve_ethdev.c | 5 +++-- drivers/net/gve/gve_ethdev.h | 3 --- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c index 9b25f3036b..b441f96623 100644 --- a/drivers/net/gve/gve_ethdev.c +++ b/drivers/net/gve/gve_ethdev.c @@ -7,6 +7,7 @@ #include "base/gve_register.h" #include "base/gve_osdep.h" #include "gve_version.h" +#include "rte_ether.h" static void gve_write_version(uint8_t *driver_version_register) @@ -297,8 +298,8 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info) dev_info->max_tx_queues = priv->max_nb_txq; dev_info->min_rx_bufsize = GVE_MIN_BUF_SIZE; dev_info->max_rx_pktlen = GVE_MAX_RX_PKTLEN; - dev_info->max_mtu = GVE_MAX_MTU; - dev_info->min_mtu = GVE_MIN_MTU; + dev_info->max_mtu = priv->max_mtu; + dev_info->min_mtu = RTE_ETHER_MIN_MTU; dev_info->rx_offload_capa = 0; dev_info->tx_offload_capa = diff --git a/drivers/net/gve/gve_ethdev.h b/drivers/net/gve/gve_ethdev.h index ca94a09a2f..1cba282128 100644 --- a/drivers/net/gve/gve_ethdev.h +++ b/drivers/net/gve/gve_ethdev.h @@ -23,9 +23,6 @@ #define GVE_MIN_BUF_SIZE 1024 #define GVE_MAX_RX_PKTLEN 65535 -#define GVE_MAX_MTU RTE_ETHER_MTU -#define GVE_MIN_MTU RTE_ETHER_MIN_MTU - #define GVE_TX_CKSUM_OFFLOAD_MASK ( \ RTE_MBUF_F_TX_L4_MASK | \ RTE_MBUF_F_TX_TCP_SEG)