From patchwork Fri Oct 20 20:57:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 133097 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8BDF8431BE; Fri, 20 Oct 2023 23:00:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8D1C242E0B; Fri, 20 Oct 2023 22:58:36 +0200 (CEST) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 9495442DC5 for ; Fri, 20 Oct 2023 22:58:29 +0200 (CEST) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1cac925732fso8487155ad.1 for ; Fri, 20 Oct 2023 13:58:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1697835508; x=1698440308; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OSgmuRxyJdBRui1S5fbE0mz3Smj8BgEW3QoXryVscQ8=; b=rFZJgwpLmoue3/Fgpn3b5wTmbjgYjB1AOHglVEZ1lMr0jAVZnPD3k+L/LamZeasmbT 9Qs9KHwMUuT9F+/8umwLTYaTz0w06z6iS4JqeYHFc9S4wJ+uDgsFIxXBRtb+2kiNnLmx nDY2EKRFnRIPz+hzM80X+1XCnRHX18WVZbNerTFlGyHpHZKCaRyo0KMknje8cO2a9wVd bWESmlgsrRXag3GNTQf6g5ZaX58ihhOB1dc/PY98+oxV2N92SmUjMK2N3Q25+APV6B0A Xbq9YlTVbO/jCZcE/W3I13bn78lDuTFpHXfwPcVlRSW8CWUBpQ/1Ust1WwxwK4Ilu631 ETvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697835508; x=1698440308; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OSgmuRxyJdBRui1S5fbE0mz3Smj8BgEW3QoXryVscQ8=; b=ZetPxKA09mP2Fpzdtx/ejtBunMAX6R21QxO6Huewtj2oEhI2s9niGNxLXi6nGfG19i uZurdD1ZEkmGwW4aBWwOtYEGjOPKXJZAdLYuyVvjGsID2+2pKa9hRowPIwrqZ2qc9SpV u9WJFDooot6H8heTCubmMwHTgpOlOXgbqi0v4k8OC4lKjpAHiEXTt3D8J+fhKsAKv86X YUPVWJYthtGo+HPTIAnhlB6sFLIWrv5UaAWQ2YfM7IJAcjdTcGu6XgglgKCniy2nFSKe 6couxmHdG9qo+JOhdM16oXWkrGmG69sBraIoYb2BDAYlHIWgdOSCTxvmDmSo0YcqQmhZ 9Z9A== X-Gm-Message-State: AOJu0YwqxIy14W/Zr+c4zecdO6R2u5EyUlmuie+IwArdxgME4trH6ZXd 0UxigNobKyVNg2gA/iccJ7v3532zL9XlR61MeV2DDw== X-Google-Smtp-Source: AGHT+IHlqmoM8BaoXbRWdbEB6rRZavYkdxAwtrb1de618FMaei9mFM6g0AYeW6OrlsjxvXkHhFZV4Q== X-Received: by 2002:a17:903:246:b0:1c5:bc83:557b with SMTP id j6-20020a170903024600b001c5bc83557bmr3388329plh.51.1697835508600; Fri, 20 Oct 2023 13:58:28 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id u17-20020a170902e5d100b001c61512f2a6sm1930961plf.220.2023.10.20.13.58.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 13:58:28 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Akhil Goyal Subject: [PATCH v5 19/26] security: remove experimental flag from macsec Date: Fri, 20 Oct 2023 13:57:52 -0700 Message-Id: <20231020205759.195126-20-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231020205759.195126-1-stephen@networkplumber.org> References: <20230808173527.186042-1-stephen@networkplumber.org> <20231020205759.195126-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rte_security API's for macsec were added in 22.11. Therefore remove the experimental tag. There is also one helper function for setting packet metadata that should have been marked internal. Signed-off-by: Stephen Hemminger Acked-by: Akhil Goyal --- lib/security/rte_security.h | 27 --------------------------- lib/security/version.map | 18 +++++++++--------- 2 files changed, 9 insertions(+), 36 deletions(-) diff --git a/lib/security/rte_security.h b/lib/security/rte_security.h index d2d2af23d5d2..a19544906f21 100644 --- a/lib/security/rte_security.h +++ b/lib/security/rte_security.h @@ -815,7 +815,6 @@ rte_security_session_create(void *instance, * - On success returns 0 * - On failure returns a negative errno value. */ -__rte_experimental int rte_security_session_update(void *instance, void *sess, @@ -851,9 +850,6 @@ int rte_security_session_destroy(void *instance, void *sess); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Create MACsec security channel (SC). * * @param instance security instance @@ -865,15 +861,11 @@ rte_security_session_destroy(void *instance, void *sess); * - -ENOMEM if PMD is not capable to create more SC. * - other negative value for other errors. */ -__rte_experimental int rte_security_macsec_sc_create(void *instance, struct rte_security_macsec_sc *conf); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Destroy MACsec security channel (SC). * * @param instance security instance @@ -884,15 +876,11 @@ rte_security_macsec_sc_create(void *instance, * - -EINVAL if sc_id is invalid or instance is NULL. * - -EBUSY if sc is being used by some session. */ -__rte_experimental int rte_security_macsec_sc_destroy(void *instance, uint16_t sc_id, enum rte_security_macsec_direction dir); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Create MACsec security association (SA). * * @param instance security instance @@ -904,15 +892,11 @@ rte_security_macsec_sc_destroy(void *instance, uint16_t sc_id, * - -ENOMEM if PMD is not capable to create more SAs. * - other negative value for other errors. */ -__rte_experimental int rte_security_macsec_sa_create(void *instance, struct rte_security_macsec_sa *conf); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Destroy MACsec security association (SA). * * @param instance security instance @@ -923,7 +907,6 @@ rte_security_macsec_sa_create(void *instance, * - -EINVAL if sa_id is invalid or instance is NULL. * - -EBUSY if sa is being used by some session. */ -__rte_experimental int rte_security_macsec_sa_destroy(void *instance, uint16_t sa_id, enum rte_security_macsec_direction dir); @@ -1059,7 +1042,6 @@ rte_security_session_fast_mdata_set(void *sess, uint64_t fdata) } /** Function to call PMD specific function pointer set_pkt_metadata() */ -__rte_experimental int __rte_security_set_pkt_metadata(void *instance, void *sess, struct rte_mbuf *m, void *params); @@ -1230,16 +1212,12 @@ struct rte_security_stats { * - On success, return 0 * - On failure, a negative value */ -__rte_experimental int rte_security_session_stats_get(void *instance, void *sess, struct rte_security_stats *stats); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Get MACsec SA statistics. * * @param instance security instance @@ -1250,16 +1228,12 @@ rte_security_session_stats_get(void *instance, * - On success, return 0. * - On failure, a negative value. */ -__rte_experimental int rte_security_macsec_sa_stats_get(void *instance, uint16_t sa_id, enum rte_security_macsec_direction dir, struct rte_security_macsec_sa_stats *stats); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Get MACsec SC statistics. * * @param instance security instance @@ -1270,7 +1244,6 @@ rte_security_macsec_sa_stats_get(void *instance, * - On success, return 0. * - On failure, a negative value. */ -__rte_experimental int rte_security_macsec_sc_stats_get(void *instance, uint16_t sc_id, enum rte_security_macsec_direction dir, diff --git a/lib/security/version.map b/lib/security/version.map index e07fca33a1e6..54c9a556798d 100644 --- a/lib/security/version.map +++ b/lib/security/version.map @@ -1,19 +1,12 @@ DPDK_24 { global: + __rte_security_set_pkt_metadata; rte_security_capabilities_get; rte_security_capability_get; rte_security_session_create; rte_security_session_destroy; rte_security_session_get_size; - - local: *; -}; - -EXPERIMENTAL { - global: - - __rte_security_set_pkt_metadata; rte_security_dynfield_offset; rte_security_macsec_sa_create; rte_security_macsec_sa_destroy; @@ -23,8 +16,15 @@ EXPERIMENTAL { rte_security_macsec_sc_stats_get; rte_security_session_stats_get; rte_security_session_update; - rte_security_oop_dynfield_offset; + local: *; +}; + +EXPERIMENTAL { + global: + + # Added in 23.11 + rte_security_oop_dynfield_offset; rte_security_rx_inject_configure; rte_security_inb_pkt_rx_inject; };