From patchwork Mon Oct 23 12:42:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Etelson X-Patchwork-Id: 133175 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33EB3431E2; Mon, 23 Oct 2023 14:42:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A474640A77; Mon, 23 Oct 2023 14:42:51 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id 63169406B7 for ; Mon, 23 Oct 2023 14:42:50 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=D9l9HHzqzvm+96EzYiGR4fxu9VY5GqD0s1wXlK85lkryV/Fb4NcA+ntOAd3yIhSKIvTPDOhaWj2gjGhdcm4rTP5egXvGtjwkQqgbQ8Wkf0TssfPPwzbu7gYEaCrlNlSKhSP0Zjml7we4UUAnsRJqgNTtveP0iABfchBTscqF511MbJEtHoufZG7LHES67lismd3h3B6VffRFlUOLmka3YiIegkk5usrMLBhoDWaB8uQoJxEFLzrzNq2WphQZ8wMHYNK5ETz6zqbBCZfXAcqml1IzqcbgO674YFeaFrsStAyQmlEv8kc9kjElC4GDVfxaYNFyqqk+DVMxTivK2P+0Sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s3n+GgbuKpe+3Sih6/N0v65MIva9E0f8+3x4VhtZJfc=; b=HqHgJms/4n/M1znxyaj3kyhZ9im2dxD1fPwCOlf6/DvbijhniVru7atQiOuDl2HMNeEE+Qrlg4EZ3zNy8MK82fv2FQfLd5hNWhyIktuxp4uL8Y2hvkLXo7yJUPrmC7QFR9XfQgQPpCPAuhk3t6xfgFabTRjSQecOrTiSIZuVEjh5TBPn5jJScmRWYPdZz5eYPewiu0GbwwD1i/azX9rsAu76IcSzoo+aVFjr7viaPVDANv18Orii3BW9317shgIQrV+e3kCOOOyBbuxTuwSD5r0kDjz5Ne3HWz9FCCD5B5pGqNReKJxDYhyRg1lTXdE8Yt1A6np472cuGZHqNKprGA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s3n+GgbuKpe+3Sih6/N0v65MIva9E0f8+3x4VhtZJfc=; b=sHWblUNyfs/A4hhejfBuoPsNrAS/W3EitW3vJofGSDdcfjHg4448eSF63TieBAKwGps/Xq5/29MuLoAB5DPz8sr7EdzfbUUC+qMk9FBkMBWVOb1xZNJy2r89nw5xQHLYbv8s2jSuoyO9Jw9ihsp0arzVvuJU8litpfRSGLGj7oEILmVOWz6bQePqjhxbMvMHqcOB3h7P4lrGqZ607KSnTubFSYJpwxB+Iz1JtE9UPxZiZSpUFNJjrpr1qs3lPvcJCPTs2G9YRIYAMrWsPpyMBL6B6XEvjuRlfo6ZlERX8jx542jcNOEvGevU34I2gq9qDxW+6Z2oPSDqs9VBExVsEg== Received: from CH2PR20CA0002.namprd20.prod.outlook.com (2603:10b6:610:58::12) by SN7PR12MB7105.namprd12.prod.outlook.com (2603:10b6:806:2a0::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.23; Mon, 23 Oct 2023 12:42:48 +0000 Received: from CO1PEPF000044F2.namprd05.prod.outlook.com (2603:10b6:610:58:cafe::55) by CH2PR20CA0002.outlook.office365.com (2603:10b6:610:58::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6907.33 via Frontend Transport; Mon, 23 Oct 2023 12:42:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1PEPF000044F2.mail.protection.outlook.com (10.167.241.72) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.15 via Frontend Transport; Mon, 23 Oct 2023 12:42:47 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 23 Oct 2023 05:42:46 -0700 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Mon, 23 Oct 2023 05:42:43 -0700 From: Gregory Etelson To: CC: , =?utf-8?b?wqA=?= , , Hamdan Igbaria , Suanming Mou , Matan Azrad , Viacheslav Ovsiienko , Ori Kam Subject: [PATCH v4 01/10] net/mlx5/hws: add support for reformat DevX object Date: Mon, 23 Oct 2023 15:42:16 +0300 Message-ID: <20231023124225.141461-2-getelson@nvidia.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231023124225.141461-1-getelson@nvidia.com> References: <20231017080928.30454-1-getelson@nvidia.com> <20231023124225.141461-1-getelson@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1PEPF000044F2:EE_|SN7PR12MB7105:EE_ X-MS-Office365-Filtering-Correlation-Id: d4a046af-accb-41ea-9720-08dbd3c58fb0 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dXIM1juZyOjllTU73ShT7xFN1iw2Zb4KC0N31hm55bsoyLu7Yo6uQjpzRUteT6OpVdQ75o8mJNmPD25hBsn+uphx+5Tkae68SCNk8Ydqq7FlEQcEdkx7sq/Vco2uxY+rZ2HkhTlABMZjDTO7kC+cfjlEmhyNHMxEX7UKfN2w3LsVEbP3DPTeCIMrkKsWHK6+frHUjUKTCiOXArXKSyNimEjbH1COUgYugJr8mgXM9/Ne9IB0yTTZjVtUNhfGz0lC2Fv+NQJMxpcdA5rlqvUIVYgvxnI/BG1FWByC6uetEMDWpwBLdl0g+Hg9JtRXXhuK/SwJ3TqZ8KQHQv3far3nIn3eC5gWinqmnMa0eVodn3apvuuSs9/63Y5fdD2AHgCVfr+Dmwhp6Y1XKAa9cITjnTl6q3FEUjsjZGWIig3ObDpLgbrW/HtkdjQel5c3wYvDXadhIFQS2sxAVsjy1W7WtPAKM3TNwvkVJ5+WOrmHbl0Bh4eeZMzcQDDFXZ8aPjzh2ZQwTgb23X6cbE5VWQ5e28hwIEoXBV8KqJnF78BdDHh1Ng0HHENyJ2tBkYVO96OJQuxtcrwUrkhi3KQQpDj1QjQ+BGEHnAphxhY+wO824f+9kJJfRjPXsjQpUZCe6ZuW12yZyTyX15auLf2ULSKafMTmR76M1IRQKzAE8w39li8ZnNbxXfHBZGp8YG8oubyQbGPyuY+6Pvd+WAgUNBhKq5OHwqywZtuGWBvhImAYQfKMeQtqefiFgnVo53ZGJhpF X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(39860400002)(396003)(346002)(136003)(376002)(230922051799003)(186009)(451199024)(82310400011)(64100799003)(1800799009)(40470700004)(36840700001)(46966006)(4326008)(55016003)(40480700001)(40460700003)(7636003)(8676002)(36860700001)(426003)(82740400003)(356005)(86362001)(36756003)(8936002)(2906002)(47076005)(2616005)(5660300002)(1076003)(6286002)(83380400001)(26005)(336012)(16526019)(107886003)(66899024)(54906003)(7696005)(478600001)(6666004)(70206006)(41300700001)(6916009)(70586007)(316002); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Oct 2023 12:42:47.4383 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d4a046af-accb-41ea-9720-08dbd3c58fb0 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1PEPF000044F2.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7105 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Hamdan Igbaria Add support for creation of packet reformat object, via the ALLOC_PACKET_REFORMAT_CONTEXT command. Signed-off-by: Hamdan Igbaria Acked-by: Suanming Mou --- drivers/common/mlx5/mlx5_prm.h | 39 +++++++++++++++++ drivers/net/mlx5/hws/mlx5dr_cmd.c | 60 ++++++++++++++++++++++++++ drivers/net/mlx5/hws/mlx5dr_cmd.h | 11 +++++ drivers/net/mlx5/hws/mlx5dr_internal.h | 5 +++ drivers/net/mlx5/hws/mlx5dr_send.c | 5 --- 5 files changed, 115 insertions(+), 5 deletions(-) diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h index 6e181a0eca..4192fff55b 100644 --- a/drivers/common/mlx5/mlx5_prm.h +++ b/drivers/common/mlx5/mlx5_prm.h @@ -1218,6 +1218,8 @@ enum { MLX5_CMD_OP_CREATE_FLOW_GROUP = 0x933, MLX5_CMD_OP_SET_FLOW_TABLE_ENTRY = 0x936, MLX5_CMD_OP_MODIFY_FLOW_TABLE = 0x93c, + MLX5_CMD_OP_ALLOC_PACKET_REFORMAT_CONTEXT = 0x93d, + MLX5_CMD_OP_DEALLOC_PACKET_REFORMAT_CONTEXT = 0x93e, MLX5_CMD_OP_ALLOC_FLOW_COUNTER = 0x939, MLX5_CMD_OP_QUERY_FLOW_COUNTER = 0x93b, MLX5_CMD_OP_CREATE_GENERAL_OBJECT = 0xa00, @@ -5191,6 +5193,43 @@ struct mlx5_ifc_modify_flow_table_out_bits { u8 reserved_at_40[0x60]; }; +struct mlx5_ifc_packet_reformat_context_in_bits { + u8 reformat_type[0x8]; + u8 reserved_at_8[0x4]; + u8 reformat_param_0[0x4]; + u8 reserved_at_16[0x6]; + u8 reformat_data_size[0xa]; + + u8 reformat_param_1[0x8]; + u8 reserved_at_40[0x8]; + u8 reformat_data[6][0x8]; + + u8 more_reformat_data[][0x8]; +}; + +struct mlx5_ifc_alloc_packet_reformat_context_in_bits { + u8 opcode[0x10]; + u8 uid[0x10]; + + u8 reserved_at_20[0x10]; + u8 op_mod[0x10]; + + u8 reserved_at_40[0xa0]; + + u8 packet_reformat_context[]; +}; + +struct mlx5_ifc_alloc_packet_reformat_out_bits { + u8 status[0x8]; + u8 reserved_at_8[0x18]; + + u8 syndrome[0x20]; + + u8 packet_reformat_id[0x20]; + + u8 reserved_at_60[0x20]; +}; + /* CQE format mask. */ #define MLX5E_CQE_FORMAT_MASK 0xc diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.c b/drivers/net/mlx5/hws/mlx5dr_cmd.c index 594c59aee3..0ccbaee961 100644 --- a/drivers/net/mlx5/hws/mlx5dr_cmd.c +++ b/drivers/net/mlx5/hws/mlx5dr_cmd.c @@ -780,6 +780,66 @@ mlx5dr_cmd_sq_create(struct ibv_context *ctx, return devx_obj; } +struct mlx5dr_devx_obj * +mlx5dr_cmd_packet_reformat_create(struct ibv_context *ctx, + struct mlx5dr_cmd_packet_reformat_create_attr *attr) +{ + uint32_t out[MLX5_ST_SZ_DW(alloc_packet_reformat_out)] = {0}; + size_t insz, cmd_data_sz, cmd_total_sz; + struct mlx5dr_devx_obj *devx_obj; + void *prctx; + void *pdata; + void *in; + + cmd_total_sz = MLX5_ST_SZ_BYTES(alloc_packet_reformat_context_in); + cmd_total_sz += MLX5_ST_SZ_BYTES(packet_reformat_context_in); + cmd_data_sz = MLX5_FLD_SZ_BYTES(packet_reformat_context_in, reformat_data); + insz = align(cmd_total_sz + attr->data_sz - cmd_data_sz, DW_SIZE); + in = simple_calloc(1, insz); + if (!in) { + rte_errno = ENOMEM; + return NULL; + } + + MLX5_SET(alloc_packet_reformat_context_in, in, opcode, + MLX5_CMD_OP_ALLOC_PACKET_REFORMAT_CONTEXT); + + prctx = MLX5_ADDR_OF(alloc_packet_reformat_context_in, in, + packet_reformat_context); + pdata = MLX5_ADDR_OF(packet_reformat_context_in, prctx, reformat_data); + + MLX5_SET(packet_reformat_context_in, prctx, reformat_type, attr->type); + MLX5_SET(packet_reformat_context_in, prctx, reformat_param_0, attr->reformat_param_0); + MLX5_SET(packet_reformat_context_in, prctx, reformat_data_size, attr->data_sz); + memcpy(pdata, attr->data, attr->data_sz); + + devx_obj = simple_malloc(sizeof(*devx_obj)); + if (!devx_obj) { + DR_LOG(ERR, "Failed to allocate memory for packet reformat object"); + rte_errno = ENOMEM; + goto out_free_in; + } + + devx_obj->obj = mlx5_glue->devx_obj_create(ctx, in, insz, out, sizeof(out)); + if (!devx_obj->obj) { + DR_LOG(ERR, "Failed to create packet reformat"); + rte_errno = errno; + goto out_free_devx; + } + + devx_obj->id = MLX5_GET(alloc_packet_reformat_out, out, packet_reformat_id); + + simple_free(in); + + return devx_obj; + +out_free_devx: + simple_free(devx_obj); +out_free_in: + simple_free(in); + return NULL; +} + int mlx5dr_cmd_sq_modify_rdy(struct mlx5dr_devx_obj *devx_obj) { uint32_t out[MLX5_ST_SZ_DW(modify_sq_out)] = {0}; diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.h b/drivers/net/mlx5/hws/mlx5dr_cmd.h index 8a495db9b3..f45b6c6b07 100644 --- a/drivers/net/mlx5/hws/mlx5dr_cmd.h +++ b/drivers/net/mlx5/hws/mlx5dr_cmd.h @@ -155,6 +155,13 @@ struct mlx5dr_cmd_allow_other_vhca_access_attr { uint8_t access_key[ACCESS_KEY_LEN]; }; +struct mlx5dr_cmd_packet_reformat_create_attr { + uint8_t type; + size_t data_sz; + void *data; + uint8_t reformat_param_0; +}; + struct mlx5dr_cmd_query_ft_caps { uint8_t max_level; uint8_t reparse; @@ -285,6 +292,10 @@ mlx5dr_cmd_forward_tbl_create(struct ibv_context *ctx, void mlx5dr_cmd_forward_tbl_destroy(struct mlx5dr_cmd_forward_tbl *tbl); +struct mlx5dr_devx_obj * +mlx5dr_cmd_packet_reformat_create(struct ibv_context *ctx, + struct mlx5dr_cmd_packet_reformat_create_attr *attr); + struct mlx5dr_devx_obj * mlx5dr_cmd_alias_obj_create(struct ibv_context *ctx, struct mlx5dr_cmd_alias_obj_create_attr *alias_attr); diff --git a/drivers/net/mlx5/hws/mlx5dr_internal.h b/drivers/net/mlx5/hws/mlx5dr_internal.h index c3c077667d..3770d28e62 100644 --- a/drivers/net/mlx5/hws/mlx5dr_internal.h +++ b/drivers/net/mlx5/hws/mlx5dr_internal.h @@ -91,4 +91,9 @@ static inline uint64_t roundup_pow_of_two(uint64_t n) return n == 1 ? 1 : 1ULL << log2above(n); } +static inline unsigned long align(unsigned long val, unsigned long align) +{ + return (val + align - 1) & ~(align - 1); +} + #endif /* MLX5DR_INTERNAL_H_ */ diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5dr_send.c index e58fdeb117..622d574bfa 100644 --- a/drivers/net/mlx5/hws/mlx5dr_send.c +++ b/drivers/net/mlx5/hws/mlx5dr_send.c @@ -668,11 +668,6 @@ static int mlx5dr_send_ring_create_sq_obj(struct mlx5dr_context *ctx, return err; } -static inline unsigned long align(unsigned long val, unsigned long align) -{ - return (val + align - 1) & ~(align - 1); -} - static int mlx5dr_send_ring_open_sq(struct mlx5dr_context *ctx, struct mlx5dr_send_engine *queue, struct mlx5dr_send_ring_sq *sq,