From patchwork Tue Oct 24 02:54:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 133249 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30196431EB; Tue, 24 Oct 2023 04:56:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C109F42E2B; Tue, 24 Oct 2023 04:54:54 +0200 (CEST) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id E737C42DF4 for ; Tue, 24 Oct 2023 04:54:47 +0200 (CEST) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-6b497c8575aso3989700b3a.1 for ; Mon, 23 Oct 2023 19:54:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1698116087; x=1698720887; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rMDj5Y+VmkY4guvpu3/eTGeh1/fdRwujrJsdsJyCRAo=; b=2GAfl1xsnmkJr3pdc4izIldVZy5NdSddc//LAiT438ElFe9Fh6IsSm3NeSsI/8fCil vRlRyWq6/v3c44cu5lK8AuDdh/jFBySIso9HJM2OSv87SQ5VytgNZrMBOWPuFN1+RRUL bcguwDAzy9ozitqN8YBBjnzPFLHxY6bd6NzCkJvYEkGaMD8jq4CAgkcoB5c/ZtMjmaRD IupCdDEeQrxH3CuK1eAMEqPfcpS0f48hstZTmFy7tr2QPO2AHjeTUZzuMyz7Fnt/Sp4/ 3hZUKPN2YZZCrHemqOxt1z1px6oY95KLB/pH7D7zhJP69ghCnJIyNK7RIk6wBDTBqTmF 5kYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698116087; x=1698720887; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=rMDj5Y+VmkY4guvpu3/eTGeh1/fdRwujrJsdsJyCRAo=; b=NyBwJXTKIfI+Nqa71pZGFbdkg9LRP7gVI3yYoMho6QYeUOKgcPIA0/ApVGSZuf2Ckw P/PNK5pCkmsZl/dT5AnxH5fMcZ0J0t8RMn5lA2SFpWjWQMRjzVM73ukwORKphhv8zZ8g pYvEVc5BjSQHikybHFOas+zf4/prVIA9QX38fDBd1jg5TQ2/HwecOoUEA66DRCVmQXVp 9A8QyAH9337Eq0x8E2ETQJhIyTsQ8HEkB7QlhMDpY26b2ebki447fuvx7Rcdkg+JvPgx SPU5kRIhQDbFaa3fKP1EfR3p59WivWCQVVkae4vAYQtzJupsoFWxTIwLxOrdIEoWWn1v mRGg== X-Gm-Message-State: AOJu0Ywvz3EpRyVHrr8VkZ5qc8DKO6HXLOzMz8foz9P8VMK9arYqii72 V585wde7NKxAv1EtHMJsr9qVCpdwCpkE2o0xqsEXQg== X-Google-Smtp-Source: AGHT+IHKnukDSEgVWXeCzW/MG/gPFrUwpVPd9GvX5eos3giqpr6RDSaXVBazIcCgos36yDjqaCr/gQ== X-Received: by 2002:a05:6a00:b8d:b0:6be:265:1bf7 with SMTP id g13-20020a056a000b8d00b006be02651bf7mr12066921pfj.34.1698116086852; Mon, 23 Oct 2023 19:54:46 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id b22-20020aa79516000000b0069b772c4325sm6802348pfp.87.2023.10.23.19.54.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 19:54:46 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , David Hunt , Anatoly Burakov Subject: [PATCH v7 15/25] power: remove experimental from API's Date: Mon, 23 Oct 2023 19:54:12 -0700 Message-Id: <20231024025422.126021-16-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231024025422.126021-1-stephen@networkplumber.org> References: <20230808173527.186042-1-stephen@networkplumber.org> <20231024025422.126021-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The power management API's were last changed in 22.11 release. Signed-off-by: Stephen Hemminger Acked-by: David Hunt --- lib/power/rte_power.h | 4 --- lib/power/rte_power_guest_channel.h | 4 --- lib/power/rte_power_pmd_mgmt.h | 40 ----------------------------- lib/power/rte_power_uncore.h | 2 -- lib/power/version.map | 37 +++++++++++--------------- 5 files changed, 15 insertions(+), 72 deletions(-) diff --git a/lib/power/rte_power.h b/lib/power/rte_power.h index e79bf1c4dd0c..4b624a01c5d7 100644 --- a/lib/power/rte_power.h +++ b/lib/power/rte_power.h @@ -25,9 +25,6 @@ enum power_management_env {PM_ENV_NOT_SET, PM_ENV_ACPI_CPUFREQ, PM_ENV_KVM_VM, PM_ENV_AMD_PSTATE_CPUFREQ}; /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice - * * Check if a specific power management environment type is supported on a * currently running system. * @@ -39,7 +36,6 @@ enum power_management_env {PM_ENV_NOT_SET, PM_ENV_ACPI_CPUFREQ, PM_ENV_KVM_VM, * - 0 if unsupported * - -1 if error, with rte_errno indicating reason for error. */ -__rte_experimental int rte_power_check_env_supported(enum power_management_env env); /** diff --git a/lib/power/rte_power_guest_channel.h b/lib/power/rte_power_guest_channel.h index b5de1bd24318..55b76dfc4c08 100644 --- a/lib/power/rte_power_guest_channel.h +++ b/lib/power/rte_power_guest_channel.h @@ -135,9 +135,6 @@ int rte_power_guest_channel_send_msg(struct rte_power_channel_packet *pkt, unsigned int lcore_id); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice. - * * Receive a message contained in pkt over the Virtio-Serial * from the host endpoint. * @@ -155,7 +152,6 @@ int rte_power_guest_channel_send_msg(struct rte_power_channel_packet *pkt, * - 0 on success. * - Negative on error. */ -__rte_experimental int rte_power_guest_channel_receive_msg(void *pkt, size_t pkt_len, unsigned int lcore_id); diff --git a/lib/power/rte_power_pmd_mgmt.h b/lib/power/rte_power_pmd_mgmt.h index 0f1a2eb22eb4..456145661917 100644 --- a/lib/power/rte_power_pmd_mgmt.h +++ b/lib/power/rte_power_pmd_mgmt.h @@ -33,9 +33,6 @@ enum rte_power_pmd_mgmt_type { }; /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice. - * * Enable power management on a specified Ethernet device Rx queue and lcore. * * @note This function is not thread-safe. @@ -55,16 +52,12 @@ enum rte_power_pmd_mgmt_type { * 0 on success * <0 on error */ -__rte_experimental int rte_power_ethdev_pmgmt_queue_enable(unsigned int lcore_id, uint16_t port_id, uint16_t queue_id, enum rte_power_pmd_mgmt_type mode); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice. - * * Disable power management on a specified Ethernet device Rx queue and lcore. * * @note This function is not thread-safe. @@ -82,42 +75,30 @@ rte_power_ethdev_pmgmt_queue_enable(unsigned int lcore_id, * 0 on success * <0 on error */ -__rte_experimental int rte_power_ethdev_pmgmt_queue_disable(unsigned int lcore_id, uint16_t port_id, uint16_t queue_id); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice. - * * Set a emptypoll_max to specified value. Used to specify the number of empty * polls to wait before entering sleep state. * * @param max * The value to set emptypoll_max to. */ -__rte_experimental void rte_power_pmd_mgmt_set_emptypoll_max(unsigned int max); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice. - * * Get the current value of emptypoll_max. * * @return * The current emptypoll_max value */ -__rte_experimental unsigned int rte_power_pmd_mgmt_get_emptypoll_max(void); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice. - * * Set the pause_duration. Used to adjust the pause mode callback duration. * * @note Duration must be greater than zero. @@ -128,27 +109,19 @@ rte_power_pmd_mgmt_get_emptypoll_max(void); * 0 on success * <0 on error */ -__rte_experimental int rte_power_pmd_mgmt_set_pause_duration(unsigned int duration); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice. - * * Get the current value of pause_duration. * * @return * The current pause_duration value. */ -__rte_experimental unsigned int rte_power_pmd_mgmt_get_pause_duration(void); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice. - * * Set the min frequency to be used for frequency scaling or zero to use defaults. * * @note Supported by: Pstate mode. @@ -161,14 +134,10 @@ rte_power_pmd_mgmt_get_pause_duration(void); * 0 on success * <0 on error */ -__rte_experimental int rte_power_pmd_mgmt_set_scaling_freq_min(unsigned int lcore, unsigned int min); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice. - * * Set the max frequency to be used for frequency scaling or zero to use defaults. * * @note Supported by: Pstate mode. @@ -182,14 +151,10 @@ rte_power_pmd_mgmt_set_scaling_freq_min(unsigned int lcore, unsigned int min); * 0 on success * <0 on error */ -__rte_experimental int rte_power_pmd_mgmt_set_scaling_freq_max(unsigned int lcore, unsigned int max); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice. - * * Get the current configured min frequency used for frequency scaling. * * @note Supported by: Pstate mode. @@ -202,14 +167,10 @@ rte_power_pmd_mgmt_set_scaling_freq_max(unsigned int lcore, unsigned int max); * , in KiloHertz, used for frequency scaling. * <0 on error */ -__rte_experimental int rte_power_pmd_mgmt_get_scaling_freq_min(unsigned int lcore); /** - * @warning - * @b EXPERIMENTAL: this API may change, or be removed, without prior notice. - * * Get the current configured max frequency used for frequency scaling. * * @note Supported by: Pstate mode. @@ -222,7 +183,6 @@ rte_power_pmd_mgmt_get_scaling_freq_min(unsigned int lcore); * , in KiloHertz, used for frequency scaling. * <0 on error */ -__rte_experimental int rte_power_pmd_mgmt_get_scaling_freq_max(unsigned int lcore); diff --git a/lib/power/rte_power_uncore.h b/lib/power/rte_power_uncore.h index 295017b7f429..a6a19019225c 100644 --- a/lib/power/rte_power_uncore.h +++ b/lib/power/rte_power_uncore.h @@ -74,7 +74,6 @@ enum rte_uncore_power_mgmt_env rte_power_get_uncore_env(void); * - 0 on success. * - Negative on error. */ -__rte_experimental int rte_power_uncore_init(unsigned int pkg, unsigned int die); @@ -96,7 +95,6 @@ rte_power_uncore_init(unsigned int pkg, unsigned int die); * - 0 on success. * - Negative on error. */ -__rte_experimental int rte_power_uncore_exit(unsigned int pkg, unsigned int die); diff --git a/lib/power/version.map b/lib/power/version.map index 53627b59f189..ad92a65f913e 100644 --- a/lib/power/version.map +++ b/lib/power/version.map @@ -1,6 +1,9 @@ DPDK_24 { global: + rte_power_check_env_supported; + rte_power_ethdev_pmgmt_queue_disable; + rte_power_ethdev_pmgmt_queue_enable; rte_power_exit; rte_power_freq_disable_turbo; rte_power_freq_down; @@ -12,27 +15,10 @@ DPDK_24 { rte_power_get_capabilities; rte_power_get_env; rte_power_get_freq; + rte_power_get_uncore_freq; + rte_power_guest_channel_receive_msg; rte_power_guest_channel_send_msg; rte_power_init; - rte_power_set_env; - rte_power_set_freq; - rte_power_turbo_status; - rte_power_unset_env; - - local: *; -}; - -EXPERIMENTAL { - global: - - rte_power_check_env_supported; - rte_power_guest_channel_receive_msg; - - # added in 21.02 - rte_power_ethdev_pmgmt_queue_disable; - rte_power_ethdev_pmgmt_queue_enable; - - # added in 22.07 rte_power_pmd_mgmt_get_emptypoll_max; rte_power_pmd_mgmt_get_pause_duration; rte_power_pmd_mgmt_get_scaling_freq_max; @@ -41,10 +27,10 @@ EXPERIMENTAL { rte_power_pmd_mgmt_set_pause_duration; rte_power_pmd_mgmt_set_scaling_freq_max; rte_power_pmd_mgmt_set_scaling_freq_min; - - # added in 22.11 - rte_power_get_uncore_freq; + rte_power_set_env; + rte_power_set_freq; rte_power_set_uncore_freq; + rte_power_turbo_status; rte_power_uncore_exit; rte_power_uncore_freq_max; rte_power_uncore_freq_min; @@ -52,6 +38,13 @@ EXPERIMENTAL { rte_power_uncore_get_num_freqs; rte_power_uncore_get_num_pkgs; rte_power_uncore_init; + rte_power_unset_env; + + local: *; +}; + +EXPERIMENTAL { + global: # added in 23.11 rte_power_get_uncore_env;