From patchwork Tue Oct 24 02:53:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 133236 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BA8A431EB; Tue, 24 Oct 2023 04:54:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8CF8540EE5; Tue, 24 Oct 2023 04:54:37 +0200 (CEST) Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) by mails.dpdk.org (Postfix) with ESMTP id 8CE5740A76 for ; Tue, 24 Oct 2023 04:54:35 +0200 (CEST) Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-6ba54c3ed97so3880480b3a.2 for ; Mon, 23 Oct 2023 19:54:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1698116074; x=1698720874; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tys2+Rbas78abmp2lZkxnmA5eQ/E9vQyCtq1vgD2nPg=; b=HUZFt4WR3K4tTOz281ce/QCT8xQN103J4T7cgF6aQksyIIaULGDL5Pp9CytgPA6QRl hBLm4Rq/C9M+I3KF9tVC0RJZN5QneQyhpd0dvL1bjX6j6sTbCkFxXa45c9f+VrV/mj/p A3xZ8lz7gQ+VE1A4TiApvurlbXVyYABZSTG/S9QIJfhbow8Qn8d/qMywL818tPWkOvxm T+IH+g4LdIyt9fBrFqdIe9Tmb7xuHPYTMi3sqm6ht/Zk26ijkeN8J8gMgU3/OPIxriVM f8T04oNwBPG5uePPg+PoTBz2LvwNBSmL7bB6yb6IPNWqaBuFYp+Qm9mZG1VDCqEXLvdf ZdAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698116074; x=1698720874; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tys2+Rbas78abmp2lZkxnmA5eQ/E9vQyCtq1vgD2nPg=; b=J9rzow4RxOuLkTR9C7cHhcF7xOp3i55FZy3hJx7hcrCWjvxEY3rJ0ry/nNNI+a2gxa FS1pvnZgIqYUH60z4PTqDJ3KG6rvZSDhBDw4b3TrMjgFznDIczhtpqFcvIdN7G7lvMyk 8lE0XG81bg0h537aNr1BbKfQU12X0Q9W3VHDMRUExNiutpdjHF2VmHgL35ahO7q5QjEN F6Vi33hBQAfsf7RAG6dIJ+rY+X2MTBz7s7wrDdcJfHox+XgBoiFjCmn8LceEabs9eJBn GmKn93u9epV9F3VF0vQZw1MCkTcEEgLMIW/VvVSqW/AzM43VFLPK+0DDL7DiTGOcdkyY g0Dw== X-Gm-Message-State: AOJu0YwSlReCOiNgaAGfv3jW3sBcw8fM7XAZ26zjysv6Vc3DZzLpNfC2 8O++hXb2qDYkO3iqM+6sMaFoHCTJgktqrZFji+rjbQ== X-Google-Smtp-Source: AGHT+IEyTJLcMDyPxfhZYQ8pFDl2CcTDgPUyEkr1qcM9cGndJEe9zXbY98qtSuLILO3WSYfglMJ8ig== X-Received: by 2002:a05:6a20:12c7:b0:172:918b:3907 with SMTP id v7-20020a056a2012c700b00172918b3907mr1384380pzg.54.1698116074561; Mon, 23 Oct 2023 19:54:34 -0700 (PDT) Received: from hermes.local (204-195-126-68.wavecable.com. [204.195.126.68]) by smtp.gmail.com with ESMTPSA id b22-20020aa79516000000b0069b772c4325sm6802348pfp.87.2023.10.23.19.54.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 19:54:33 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Bruce Richardson Subject: [PATCH v7 02/25] cmdline: make experimental API's stable Date: Mon, 23 Oct 2023 19:53:59 -0700 Message-Id: <20231024025422.126021-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231024025422.126021-1-stephen@networkplumber.org> References: <20230808173527.186042-1-stephen@networkplumber.org> <20231024025422.126021-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org These API's have all ben around for several releases. Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- lib/cmdline/cmdline.h | 1 - lib/cmdline/cmdline_parse.h | 4 ---- lib/cmdline/cmdline_rdline.h | 4 ---- lib/cmdline/version.map | 26 ++++++++------------------ 4 files changed, 8 insertions(+), 27 deletions(-) diff --git a/lib/cmdline/cmdline.h b/lib/cmdline/cmdline.h index 992c84591456..dd41e1054378 100644 --- a/lib/cmdline/cmdline.h +++ b/lib/cmdline/cmdline.h @@ -39,7 +39,6 @@ void cmdline_printf(const struct cmdline *cl, const char *fmt, ...) int cmdline_in(struct cmdline *cl, const char *buf, int size); int cmdline_write_char(struct rdline *rdl, char c); -__rte_experimental struct rdline * cmdline_get_rdline(struct cmdline *cl); diff --git a/lib/cmdline/cmdline_parse.h b/lib/cmdline/cmdline_parse.h index a852ac411c59..41b4db1f76f9 100644 --- a/lib/cmdline/cmdline_parse.h +++ b/lib/cmdline/cmdline_parse.h @@ -155,9 +155,6 @@ typedef cmdline_parse_inst_t *cmdline_parse_ctx_t; int cmdline_parse(struct cmdline *cl, const char *buf); /** - * @warning - * @b EXPERIMENTAL: this API may change without prior notice - * * Try to parse a buffer according to the specified context, but do not * perform any function calls if parse is successful. * @@ -166,7 +163,6 @@ int cmdline_parse(struct cmdline *cl, const char *buf); * CMDLINE_PARSE_BAD_ARGS on error and returns the parsed line length (>=0) * on successful parse. */ -__rte_experimental int cmdline_parse_check(struct cmdline *cl, const char *buf); /** diff --git a/lib/cmdline/cmdline_rdline.h b/lib/cmdline/cmdline_rdline.h index 1b4cc7ce5773..c6bb6bbbb36a 100644 --- a/lib/cmdline/cmdline_rdline.h +++ b/lib/cmdline/cmdline_rdline.h @@ -58,7 +58,6 @@ typedef int (rdline_complete_t)(struct rdline *rdl, const char *buf, * * \return New rdline object on success, NULL on failure. */ -__rte_experimental struct rdline *rdline_new(rdline_write_char_t *write_char, rdline_validate_t *validate, rdline_complete_t *complete, @@ -70,7 +69,6 @@ struct rdline *rdline_new(rdline_write_char_t *write_char, * \param rdl A pointer to an initialized struct rdline. * If NULL, this function is a no-op. */ -__rte_experimental void rdline_free(struct rdline *rdl); /** @@ -163,13 +161,11 @@ char *rdline_get_history_item(struct rdline *rdl, unsigned int i); /** * Get maximum history buffer size. */ -__rte_experimental size_t rdline_get_history_buffer_size(struct rdline *rdl); /** * Get the opaque pointer supplied on struct rdline creation. */ -__rte_experimental void *rdline_get_opaque(struct rdline *rdl); #ifdef __cplusplus diff --git a/lib/cmdline/version.map b/lib/cmdline/version.map index 97166789016c..88174e39bcb7 100644 --- a/lib/cmdline/version.map +++ b/lib/cmdline/version.map @@ -30,11 +30,13 @@ DPDK_24 { cmdline_get_help_num; cmdline_get_help_portlist; cmdline_get_help_string; + cmdline_get_rdline; cmdline_in; cmdline_interact; cmdline_isendoftoken; cmdline_new; cmdline_parse; + cmdline_parse_check; cmdline_parse_etheraddr; cmdline_parse_ipaddr; cmdline_parse_num; @@ -51,37 +53,25 @@ DPDK_24 { cmdline_token_portlist_ops; cmdline_token_string_ops; cmdline_write_char; + rdline_add_history; rdline_char_in; rdline_clear_history; + rdline_free; rdline_get_buffer; + rdline_get_history_buffer_size; rdline_get_history_item; + rdline_get_opaque; + rdline_new; rdline_newline; rdline_quit; rdline_redisplay; rdline_reset; rdline_restart; rdline_stop; + vt100_init; vt100_parser; local: *; }; - -EXPERIMENTAL { - global: - - # added in 20.11 - cmdline_get_rdline; - - # added in 21.11 - rdline_new; - rdline_free; - rdline_get_history_buffer_size; - rdline_get_opaque; - - # added in 22.07 - cmdline_parse_check; - - local: *; -};